Commit e4bf797a authored by Andrew Lunn's avatar Andrew Lunn Committed by David S. Miller

DT: phy.txt: Clarify expected compatible values

PHY devices may only list compatibility with clause 22, 45, and if
they need to be more specific, their PHY identifier values. No other
compatible strings are allowed.  Make this clear in the documentation,
and remove examples where make/model compatible strings are listed.
Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ae461131
...@@ -68,7 +68,7 @@ ethernet@f0b60000 { ...@@ -68,7 +68,7 @@ ethernet@f0b60000 {
phy1: ethernet-phy@1 { phy1: ethernet-phy@1 {
max-speed = <1000>; max-speed = <1000>;
reg = <0x1>; reg = <0x1>;
compatible = "brcm,28nm-gphy", "ethernet-phy-ieee802.3-c22"; compatible = "ethernet-phy-ieee802.3-c22";
}; };
}; };
}; };
...@@ -115,7 +115,7 @@ ethernet@f0ba0000 { ...@@ -115,7 +115,7 @@ ethernet@f0ba0000 {
phy0: ethernet-phy@0 { phy0: ethernet-phy@0 {
max-speed = <1000>; max-speed = <1000>;
reg = <0x0>; reg = <0x0>;
compatible = "brcm,bcm53125", "ethernet-phy-ieee802.3-c22"; compatible = "ethernet-phy-ieee802.3-c22";
}; };
}; };
}; };
...@@ -38,7 +38,6 @@ Example : ...@@ -38,7 +38,6 @@ Example :
phy11: ethernet-phy@1 { phy11: ethernet-phy@1 {
reg = <1>; reg = <1>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -48,7 +47,6 @@ Example : ...@@ -48,7 +47,6 @@ Example :
}; };
phy12: ethernet-phy@2 { phy12: ethernet-phy@2 {
reg = <2>; reg = <2>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -58,7 +56,6 @@ Example : ...@@ -58,7 +56,6 @@ Example :
}; };
phy13: ethernet-phy@3 { phy13: ethernet-phy@3 {
reg = <3>; reg = <3>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -68,7 +65,6 @@ Example : ...@@ -68,7 +65,6 @@ Example :
}; };
phy14: ethernet-phy@4 { phy14: ethernet-phy@4 {
reg = <4>; reg = <4>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -85,7 +81,6 @@ Example : ...@@ -85,7 +81,6 @@ Example :
phy21: ethernet-phy@1 { phy21: ethernet-phy@1 {
reg = <1>; reg = <1>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -95,7 +90,6 @@ Example : ...@@ -95,7 +90,6 @@ Example :
}; };
phy22: ethernet-phy@2 { phy22: ethernet-phy@2 {
reg = <2>; reg = <2>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -105,7 +99,6 @@ Example : ...@@ -105,7 +99,6 @@ Example :
}; };
phy23: ethernet-phy@3 { phy23: ethernet-phy@3 {
reg = <3>; reg = <3>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -115,7 +108,6 @@ Example : ...@@ -115,7 +108,6 @@ Example :
}; };
phy24: ethernet-phy@4 { phy24: ethernet-phy@4 {
reg = <4>; reg = <4>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
......
...@@ -47,7 +47,6 @@ Example : ...@@ -47,7 +47,6 @@ Example :
phy11: ethernet-phy@1 { phy11: ethernet-phy@1 {
reg = <1>; reg = <1>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -57,7 +56,6 @@ Example : ...@@ -57,7 +56,6 @@ Example :
}; };
phy12: ethernet-phy@2 { phy12: ethernet-phy@2 {
reg = <2>; reg = <2>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -67,7 +65,6 @@ Example : ...@@ -67,7 +65,6 @@ Example :
}; };
phy13: ethernet-phy@3 { phy13: ethernet-phy@3 {
reg = <3>; reg = <3>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -77,7 +74,6 @@ Example : ...@@ -77,7 +74,6 @@ Example :
}; };
phy14: ethernet-phy@4 { phy14: ethernet-phy@4 {
reg = <4>; reg = <4>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -94,7 +90,6 @@ Example : ...@@ -94,7 +90,6 @@ Example :
phy21: ethernet-phy@1 { phy21: ethernet-phy@1 {
reg = <1>; reg = <1>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -104,7 +99,6 @@ Example : ...@@ -104,7 +99,6 @@ Example :
}; };
phy22: ethernet-phy@2 { phy22: ethernet-phy@2 {
reg = <2>; reg = <2>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -114,7 +108,6 @@ Example : ...@@ -114,7 +108,6 @@ Example :
}; };
phy23: ethernet-phy@3 { phy23: ethernet-phy@3 {
reg = <3>; reg = <3>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
...@@ -124,7 +117,6 @@ Example : ...@@ -124,7 +117,6 @@ Example :
}; };
phy24: ethernet-phy@4 { phy24: ethernet-phy@4 {
reg = <4>; reg = <4>;
compatible = "marvell,88e1149r";
marvell,reg-init = <3 0x10 0 0x5777>, marvell,reg-init = <3 0x10 0 0x5777>,
<3 0x11 0 0x00aa>, <3 0x11 0 0x00aa>,
<3 0x12 0 0x4105>, <3 0x12 0 0x4105>,
......
...@@ -17,8 +17,7 @@ Optional Properties: ...@@ -17,8 +17,7 @@ Optional Properties:
"ethernet-phy-ieee802.3-c22" or "ethernet-phy-ieee802.3-c45" for "ethernet-phy-ieee802.3-c22" or "ethernet-phy-ieee802.3-c45" for
PHYs that implement IEEE802.3 clause 22 or IEEE802.3 clause 45 PHYs that implement IEEE802.3 clause 22 or IEEE802.3 clause 45
specifications. If neither of these are specified, the default is to specifications. If neither of these are specified, the default is to
assume clause 22. The compatible list may also contain other assume clause 22.
elements.
If the phy's identifier is known then the list may contain an entry If the phy's identifier is known then the list may contain an entry
of the form: "ethernet-phy-idAAAA.BBBB" where of the form: "ethernet-phy-idAAAA.BBBB" where
...@@ -28,6 +27,9 @@ Optional Properties: ...@@ -28,6 +27,9 @@ Optional Properties:
4 hex digits. This is the chip vendor OUI bits 19:24, 4 hex digits. This is the chip vendor OUI bits 19:24,
followed by 10 bits of a vendor specific ID. followed by 10 bits of a vendor specific ID.
The compatible list should not contain other values than those
listed here.
- max-speed: Maximum PHY supported speed (10, 100, 1000...) - max-speed: Maximum PHY supported speed (10, 100, 1000...)
- broken-turn-around: If set, indicates the PHY device does not correctly - broken-turn-around: If set, indicates the PHY device does not correctly
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment