Commit e4ecafb1 authored by Mathieu Malaterre's avatar Mathieu Malaterre Committed by Michael Ellerman

cxl: remove a dead branch

In commit 14baf4d9 ("cxl: Add guest-specific code") the following code
was added:

	if (afu->crs_len < 0) {
		dev_err(&afu->dev, "Unexpected configuration record size value\n");
		return -EINVAL;
	}

However the variable `crs_len` is of type u64 and cannot be compared < 0.
Remove the dead code section. Fix the following warning treated as error
with W=1:

../drivers/misc/cxl/guest.c:919:19: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
Signed-off-by: default avatarMathieu Malaterre <malat@debian.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 2fff0f07
...@@ -913,11 +913,6 @@ static int afu_properties_look_ok(struct cxl_afu *afu) ...@@ -913,11 +913,6 @@ static int afu_properties_look_ok(struct cxl_afu *afu)
return -EINVAL; return -EINVAL;
} }
if (afu->crs_len < 0) {
dev_err(&afu->dev, "Unexpected configuration record size value\n");
return -EINVAL;
}
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment