Commit e5017716 authored by Dan Carpenter's avatar Dan Carpenter Committed by Bartlomiej Zolnierkiewicz

fbdev: sbuslib: integer overflow in sbusfb_ioctl_helper()

The "index + count" addition can overflow.  Both come directly from the
user.  This bug leads to an information leak.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: Peter Malone <peter.malone@gmail.com>
Cc: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Mathieu Malaterre <malat@debian.org>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
parent d8bad911
...@@ -171,7 +171,7 @@ int sbusfb_ioctl_helper(unsigned long cmd, unsigned long arg, ...@@ -171,7 +171,7 @@ int sbusfb_ioctl_helper(unsigned long cmd, unsigned long arg,
get_user(ublue, &c->blue)) get_user(ublue, &c->blue))
return -EFAULT; return -EFAULT;
if (index + count > cmap->len) if (index > cmap->len || count > cmap->len - index)
return -EINVAL; return -EINVAL;
for (i = 0; i < count; i++) { for (i = 0; i < count; i++) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment