Commit e555db93 authored by Brian King's avatar Brian King Committed by James Bottomley

[SCSI] use sysfs configured timeout for EH Start Unit timeout

Use the sysfs configurable timeout when issuing a START_UNIT
command from the scsi error handler. This is needed for devices which
take longer than thirty seconds to respond to the start
unit. The problem was observed when sending a start unit
to a disk array device in an ipr RAID adapter, which results
in the adapter firmware sending potentially multiple commands
to physical devices as a result of this command, which ended
up timing out sometimes. This patch does not change the default
value used for this command.
Signed-off-by: default avatarBrian King <brking@linux.vnet.ibm.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 2a4aa2c4
...@@ -38,7 +38,6 @@ ...@@ -38,7 +38,6 @@
#include "scsi_logging.h" #include "scsi_logging.h"
#define SENSE_TIMEOUT (10*HZ) #define SENSE_TIMEOUT (10*HZ)
#define START_UNIT_TIMEOUT (30*HZ)
/* /*
* These should *probably* be handled by the host itself. * These should *probably* be handled by the host itself.
...@@ -936,7 +935,7 @@ static int scsi_eh_try_stu(struct scsi_cmnd *scmd) ...@@ -936,7 +935,7 @@ static int scsi_eh_try_stu(struct scsi_cmnd *scmd)
for (i = 0; rtn == NEEDS_RETRY && i < 2; i++) for (i = 0; rtn == NEEDS_RETRY && i < 2; i++)
rtn = scsi_send_eh_cmnd(scmd, stu_command, 6, rtn = scsi_send_eh_cmnd(scmd, stu_command, 6,
START_UNIT_TIMEOUT, 0); scmd->device->timeout, 0);
if (rtn == SUCCESS) if (rtn == SUCCESS)
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment