selftests: mqueue: return Kselftest Skip code for skipped tests

When mqueue test is skipped because of unmet dependencies and/or
unsupported configuration, it exits with error which is treated as
a fail by the Kselftest framework. This leads to false negative
result even when the test could not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Change it to use ksft_exit_skip() when the test is skipped.
Signed-off-by: default avatarShuah Khan (Samsung OSG) <shuah@kernel.org>
parent e1890c50
...@@ -33,6 +33,8 @@ ...@@ -33,6 +33,8 @@
#include <mqueue.h> #include <mqueue.h>
#include <error.h> #include <error.h>
#include "../kselftest.h"
static char *usage = static char *usage =
"Usage:\n" "Usage:\n"
" %s path\n" " %s path\n"
...@@ -262,12 +264,10 @@ int main(int argc, char *argv[]) ...@@ -262,12 +264,10 @@ int main(int argc, char *argv[])
} }
} }
if (getuid() != 0) { if (getuid() != 0)
fprintf(stderr, "Not running as root, but almost all tests " ksft_exit_skip("Not running as root, but almost all tests "
"require root in order to modify\nsystem settings. " "require root in order to modify\nsystem settings. "
"Exiting.\n"); "Exiting.\n");
exit(1);
}
/* Find out what files there are for us to make tweaks in */ /* Find out what files there are for us to make tweaks in */
def_msgs = fopen(DEF_MSGS, "r+"); def_msgs = fopen(DEF_MSGS, "r+");
......
...@@ -39,6 +39,8 @@ ...@@ -39,6 +39,8 @@
#include <popt.h> #include <popt.h>
#include <error.h> #include <error.h>
#include "../kselftest.h"
static char *usage = static char *usage =
"Usage:\n" "Usage:\n"
" %s [-c #[,#..] -f] path\n" " %s [-c #[,#..] -f] path\n"
...@@ -626,12 +628,10 @@ int main(int argc, char *argv[]) ...@@ -626,12 +628,10 @@ int main(int argc, char *argv[])
cpus_to_pin[0] = cpus_online - 1; cpus_to_pin[0] = cpus_online - 1;
} }
if (getuid() != 0) { if (getuid() != 0)
fprintf(stderr, "Not running as root, but almost all tests " ksft_exit_skip("Not running as root, but almost all tests "
"require root in order to modify\nsystem settings. " "require root in order to modify\nsystem settings. "
"Exiting.\n"); "Exiting.\n");
exit(1);
}
max_msgs = fopen(MAX_MSGS, "r+"); max_msgs = fopen(MAX_MSGS, "r+");
max_msgsize = fopen(MAX_MSGSIZE, "r+"); max_msgsize = fopen(MAX_MSGSIZE, "r+");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment