Commit e87359ef authored by Dan Carpenter's avatar Dan Carpenter Committed by Takashi Iwai

ALSA: usb-audio: harmless underflow in snd_audigy2nx_led_put()

We want to verify that "value" is either zero or one, so we test if it
is greater than one.  Unfortunately, this is a signed int so it could
also be negative.  I think this is harmless but it introduces a static
checker warning.  Let's make "value" unsigned.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent b7631a12
...@@ -338,7 +338,7 @@ static int snd_audigy2nx_led_put(struct snd_kcontrol *kcontrol, ...@@ -338,7 +338,7 @@ static int snd_audigy2nx_led_put(struct snd_kcontrol *kcontrol,
struct usb_mixer_elem_list *list = snd_kcontrol_chip(kcontrol); struct usb_mixer_elem_list *list = snd_kcontrol_chip(kcontrol);
struct usb_mixer_interface *mixer = list->mixer; struct usb_mixer_interface *mixer = list->mixer;
int index = kcontrol->private_value & 0xff; int index = kcontrol->private_value & 0xff;
int value = ucontrol->value.integer.value[0]; unsigned int value = ucontrol->value.integer.value[0];
int old_value = kcontrol->private_value >> 8; int old_value = kcontrol->private_value >> 8;
int err; int err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment