Commit e9edda69 authored by Alejandro Martinez Ruiz's avatar Alejandro Martinez Ruiz Committed by Jeff Garzik

netdev: convert non-obvious instances to use ARRAY_SIZE()

This will convert remaining non-obvious or naive calculations of array
sizes to use ARRAY_SIZE() macro.
Signed-off-by: default avatarAlejandro Martinez Ruiz <alex@flawedcode.org>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 88a15f2e
...@@ -4443,7 +4443,7 @@ static struct { ...@@ -4443,7 +4443,7 @@ static struct {
{REG_MAC_COLL_EXCESS}, {REG_MAC_COLL_EXCESS},
{REG_MAC_COLL_LATE} {REG_MAC_COLL_LATE}
}; };
#define CAS_REG_LEN (sizeof(ethtool_register_table)/sizeof(int)) #define CAS_REG_LEN ARRAY_SIZE(ethtool_register_table)
#define CAS_MAX_REGS (sizeof (u32)*CAS_REG_LEN) #define CAS_MAX_REGS (sizeof (u32)*CAS_REG_LEN)
static void cas_read_regs(struct cas *cp, u8 *ptr, int len) static void cas_read_regs(struct cas *cp, u8 *ptr, int len)
......
...@@ -840,7 +840,7 @@ toshoboe_probe (struct toshoboe_cb *self) ...@@ -840,7 +840,7 @@ toshoboe_probe (struct toshoboe_cb *self)
/* test 1: SIR filter and back to back */ /* test 1: SIR filter and back to back */
for (j = 0; j < (sizeof (bauds) / sizeof (int)); ++j) for (j = 0; j < ARRAY_SIZE(bauds); ++j)
{ {
int fir = (j > 1); int fir = (j > 1);
toshoboe_stopchip (self); toshoboe_stopchip (self);
......
...@@ -93,7 +93,7 @@ static int __init init_reg_offset(struct net_device *dev,unsigned long base_addr ...@@ -93,7 +93,7 @@ static int __init init_reg_offset(struct net_device *dev,unsigned long base_addr
bus_width = *(volatile unsigned char *)ABWCR; bus_width = *(volatile unsigned char *)ABWCR;
bus_width &= 1 << ((base_addr >> 21) & 7); bus_width &= 1 << ((base_addr >> 21) & 7);
for (i = 0; i < sizeof(reg_offset) / sizeof(u32); i++) for (i = 0; i < ARRAY_SIZE(reg_offset); i++)
if (bus_width == 0) if (bus_width == 0)
reg_offset[i] = i * 2 + 1; reg_offset[i] = i * 2 + 1;
else else
...@@ -115,7 +115,7 @@ static int h8300_ne_irq[] = {EXT_IRQ5}; ...@@ -115,7 +115,7 @@ static int h8300_ne_irq[] = {EXT_IRQ5};
static inline int init_dev(struct net_device *dev) static inline int init_dev(struct net_device *dev)
{ {
if (h8300_ne_count < (sizeof(h8300_ne_base) / sizeof(unsigned long))) { if (h8300_ne_count < ARRAY_SIZE(h8300_ne_base)) {
dev->base_addr = h8300_ne_base[h8300_ne_count]; dev->base_addr = h8300_ne_base[h8300_ne_count];
dev->irq = h8300_ne_irq[h8300_ne_count]; dev->irq = h8300_ne_irq[h8300_ne_count];
h8300_ne_count++; h8300_ne_count++;
......
...@@ -9034,7 +9034,7 @@ static int tg3_do_mem_test(struct tg3 *tp, u32 offset, u32 len) ...@@ -9034,7 +9034,7 @@ static int tg3_do_mem_test(struct tg3 *tp, u32 offset, u32 len)
int i; int i;
u32 j; u32 j;
for (i = 0; i < sizeof(test_pattern)/sizeof(u32); i++) { for (i = 0; i < ARRAY_SIZE(test_pattern); i++) {
for (j = 0; j < len; j += 4) { for (j = 0; j < len; j += 4) {
u32 val; u32 val;
......
...@@ -1041,7 +1041,7 @@ static struct InfoLeaf infoleaf_array[] = { ...@@ -1041,7 +1041,7 @@ static struct InfoLeaf infoleaf_array[] = {
{DC21142, dc21142_infoleaf}, {DC21142, dc21142_infoleaf},
{DC21143, dc21143_infoleaf} {DC21143, dc21143_infoleaf}
}; };
#define INFOLEAF_SIZE (sizeof(infoleaf_array)/(sizeof(int)+sizeof(int *))) #define INFOLEAF_SIZE ARRAY_SIZE(infoleaf_array)
/* /*
** List the SROM info block functions ** List the SROM info block functions
...@@ -1056,7 +1056,7 @@ static int (*dc_infoblock[])(struct net_device *dev, u_char, u_char *) = { ...@@ -1056,7 +1056,7 @@ static int (*dc_infoblock[])(struct net_device *dev, u_char, u_char *) = {
compact_infoblock compact_infoblock
}; };
#define COMPACT (sizeof(dc_infoblock)/sizeof(int *) - 1) #define COMPACT (ARRAY_SIZE(dc_infoblock) - 1)
/* /*
** Miscellaneous defines... ** Miscellaneous defines...
......
...@@ -1342,11 +1342,11 @@ static int sdla_set_config(struct net_device *dev, struct ifmap *map) ...@@ -1342,11 +1342,11 @@ static int sdla_set_config(struct net_device *dev, struct ifmap *map)
if (flp->initialized) if (flp->initialized)
return(-EINVAL); return(-EINVAL);
for(i=0;i < sizeof(valid_port) / sizeof (int) ; i++) for(i=0; i < ARRAY_SIZE(valid_port); i++)
if (valid_port[i] == map->base_addr) if (valid_port[i] == map->base_addr)
break; break;
if (i == sizeof(valid_port) / sizeof(int)) if (i == ARRAY_SIZE(valid_port))
return(-EINVAL); return(-EINVAL);
if (!request_region(map->base_addr, SDLA_IO_EXTENTS, dev->name)){ if (!request_region(map->base_addr, SDLA_IO_EXTENTS, dev->name)){
...@@ -1487,12 +1487,12 @@ static int sdla_set_config(struct net_device *dev, struct ifmap *map) ...@@ -1487,12 +1487,12 @@ static int sdla_set_config(struct net_device *dev, struct ifmap *map)
} }
} }
for(i=0;i < sizeof(valid_mem) / sizeof (int) ; i++) for(i=0; i < ARRAY_SIZE(valid_mem); i++)
if (valid_mem[i] == map->mem_start) if (valid_mem[i] == map->mem_start)
break; break;
err = -EINVAL; err = -EINVAL;
if (i == sizeof(valid_mem) / sizeof(int)) if (i == ARRAY_SIZE(valid_mem))
goto fail2; goto fail2;
if (flp->type == SDLA_S502A && (map->mem_start & 0xF000) >> 12 == 0x0E) if (flp->type == SDLA_S502A && (map->mem_start & 0xF000) >> 12 == 0x0E)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment