Commit eaeb3b74 authored by Dmitry Bogdanov's avatar Dmitry Bogdanov Committed by David S. Miller

net: aquantia: fix LRO with FCS error

Driver stops producing skbs on ring if a packet with FCS error
was coalesced into LRO session. Ring gets hang forever.

Thats a logical error in driver processing descriptors:
When rx_stat indicates MAC Error, next pointer and eop flags
are not filled. This confuses driver so it waits for descriptor 0
to be filled by HW.

Solution is fill next pointer and eop flag even for packets with FCS error.

Fixes: bab6de8f ("net: ethernet: aquantia: Atlantic A0 and B0 specific functions.")
Signed-off-by: default avatarIgor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: default avatarDmitry Bogdanov <dmitry.bogdanov@aquantia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f38f1ee8
...@@ -713,38 +713,41 @@ static int hw_atl_b0_hw_ring_rx_receive(struct aq_hw_s *self, ...@@ -713,38 +713,41 @@ static int hw_atl_b0_hw_ring_rx_receive(struct aq_hw_s *self,
if ((rx_stat & BIT(0)) || rxd_wb->type & 0x1000U) { if ((rx_stat & BIT(0)) || rxd_wb->type & 0x1000U) {
/* MAC error or DMA error */ /* MAC error or DMA error */
buff->is_error = 1U; buff->is_error = 1U;
} else { }
if (self->aq_nic_cfg->is_rss) { if (self->aq_nic_cfg->is_rss) {
/* last 4 byte */ /* last 4 byte */
u16 rss_type = rxd_wb->type & 0xFU; u16 rss_type = rxd_wb->type & 0xFU;
if (rss_type && rss_type < 0x8U) { if (rss_type && rss_type < 0x8U) {
buff->is_hash_l4 = (rss_type == 0x4 || buff->is_hash_l4 = (rss_type == 0x4 ||
rss_type == 0x5); rss_type == 0x5);
buff->rss_hash = rxd_wb->rss_hash; buff->rss_hash = rxd_wb->rss_hash;
}
} }
}
if (HW_ATL_B0_RXD_WB_STAT2_EOP & rxd_wb->status) { if (HW_ATL_B0_RXD_WB_STAT2_EOP & rxd_wb->status) {
buff->len = rxd_wb->pkt_len % buff->len = rxd_wb->pkt_len %
AQ_CFG_RX_FRAME_MAX; AQ_CFG_RX_FRAME_MAX;
buff->len = buff->len ? buff->len = buff->len ?
buff->len : AQ_CFG_RX_FRAME_MAX; buff->len : AQ_CFG_RX_FRAME_MAX;
buff->next = 0U; buff->next = 0U;
buff->is_eop = 1U; buff->is_eop = 1U;
} else {
buff->len =
rxd_wb->pkt_len > AQ_CFG_RX_FRAME_MAX ?
AQ_CFG_RX_FRAME_MAX : rxd_wb->pkt_len;
if (HW_ATL_B0_RXD_WB_STAT2_RSCCNT &
rxd_wb->status) {
/* LRO */
buff->next = rxd_wb->next_desc_ptr;
++ring->stats.rx.lro_packets;
} else { } else {
if (HW_ATL_B0_RXD_WB_STAT2_RSCCNT & /* jumbo */
rxd_wb->status) { buff->next =
/* LRO */ aq_ring_next_dx(ring,
buff->next = rxd_wb->next_desc_ptr; ring->hw_head);
++ring->stats.rx.lro_packets; ++ring->stats.rx.jumbo_packets;
} else {
/* jumbo */
buff->next =
aq_ring_next_dx(ring,
ring->hw_head);
++ring->stats.rx.jumbo_packets;
}
} }
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment