Commit ec83e4c9 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

Merge tag 'usb-serial-5.4-rc4' of...

Merge tag 'usb-serial-5.4-rc4' of https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial into usb-linus

Johan writes:

USB-serial fixes for 5.4-rc4

Here's a fix for a long-standing locking bug in ti_usb_3410_5052 and
related clean up.

Both have been in linux-next with no reported issues.
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>

* tag 'usb-serial-5.4-rc4' of https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial:
  USB: serial: ti_usb_3410_5052: clean up serial data access
  USB: serial: ti_usb_3410_5052: fix port-close races
parents 7a759197 bc25770f
...@@ -776,7 +776,6 @@ static void ti_close(struct usb_serial_port *port) ...@@ -776,7 +776,6 @@ static void ti_close(struct usb_serial_port *port)
struct ti_port *tport; struct ti_port *tport;
int port_number; int port_number;
int status; int status;
int do_unlock;
unsigned long flags; unsigned long flags;
tdev = usb_get_serial_data(port->serial); tdev = usb_get_serial_data(port->serial);
...@@ -800,16 +799,13 @@ static void ti_close(struct usb_serial_port *port) ...@@ -800,16 +799,13 @@ static void ti_close(struct usb_serial_port *port)
"%s - cannot send close port command, %d\n" "%s - cannot send close port command, %d\n"
, __func__, status); , __func__, status);
/* if mutex_lock is interrupted, continue anyway */ mutex_lock(&tdev->td_open_close_lock);
do_unlock = !mutex_lock_interruptible(&tdev->td_open_close_lock); --tdev->td_open_port_count;
--tport->tp_tdev->td_open_port_count; if (tdev->td_open_port_count == 0) {
if (tport->tp_tdev->td_open_port_count <= 0) {
/* last port is closed, shut down interrupt urb */ /* last port is closed, shut down interrupt urb */
usb_kill_urb(port->serial->port[0]->interrupt_in_urb); usb_kill_urb(port->serial->port[0]->interrupt_in_urb);
tport->tp_tdev->td_open_port_count = 0;
} }
if (do_unlock) mutex_unlock(&tdev->td_open_close_lock);
mutex_unlock(&tdev->td_open_close_lock);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment