Commit ec9a7db7 authored by Paul M Stillwell Jr's avatar Paul M Stillwell Jr Committed by Jeff Kirsher

i40e/i40evf: Clean up code

1. Remove some break statements that will never get touched.
2. Remove an extra space.
3. Remove a comment for a parameter that doesn't exist
4. Move the assignment of a variable up to get rid of an else case.

Change-ID: I308a4b5ec070b1f0601f13b041ba4375aaad4b06
Signed-off-by: default avatarPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Tested-by: default avatarJim Young <jamesx.m.young@intel.com>
Tested-by: default avatarSibai Li <sibai.li@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 9ce34f02
...@@ -863,7 +863,7 @@ i40e_status i40e_asq_send_command(struct i40e_hw *hw, ...@@ -863,7 +863,7 @@ i40e_status i40e_asq_send_command(struct i40e_hw *hw,
/* ugh! delay while spin_lock */ /* ugh! delay while spin_lock */
udelay(delay_len); udelay(delay_len);
total_delay += delay_len; total_delay += delay_len;
} while (total_delay < hw->aq.asq_cmd_timeout); } while (total_delay < hw->aq.asq_cmd_timeout);
} }
/* if ready, copy the desc back to temp */ /* if ready, copy the desc back to temp */
......
...@@ -554,7 +554,6 @@ i40e_status i40e_init_shared_code(struct i40e_hw *hw) ...@@ -554,7 +554,6 @@ i40e_status i40e_init_shared_code(struct i40e_hw *hw)
break; break;
default: default:
return I40E_ERR_DEVICE_NOT_SUPPORTED; return I40E_ERR_DEVICE_NOT_SUPPORTED;
break;
} }
hw->phy.get_link_info = true; hw->phy.get_link_info = true;
......
...@@ -6773,13 +6773,12 @@ static int i40e_sw_init(struct i40e_pf *pf) ...@@ -6773,13 +6773,12 @@ static int i40e_sw_init(struct i40e_pf *pf)
* maximum might end up larger than the available queues * maximum might end up larger than the available queues
*/ */
pf->rss_size_max = 0x1 << pf->hw.func_caps.rss_table_entry_width; pf->rss_size_max = 0x1 << pf->hw.func_caps.rss_table_entry_width;
pf->rss_size = 1;
pf->rss_size_max = min_t(int, pf->rss_size_max, pf->rss_size_max = min_t(int, pf->rss_size_max,
pf->hw.func_caps.num_tx_qp); pf->hw.func_caps.num_tx_qp);
if (pf->hw.func_caps.rss) { if (pf->hw.func_caps.rss) {
pf->flags |= I40E_FLAG_RSS_ENABLED; pf->flags |= I40E_FLAG_RSS_ENABLED;
pf->rss_size = min_t(int, pf->rss_size_max, num_online_cpus()); pf->rss_size = min_t(int, pf->rss_size_max, num_online_cpus());
} else {
pf->rss_size = 1;
} }
/* MFP mode enabled */ /* MFP mode enabled */
......
...@@ -303,7 +303,6 @@ static int i40e_add_del_fdir_tcpv4(struct i40e_vsi *vsi, ...@@ -303,7 +303,6 @@ static int i40e_add_del_fdir_tcpv4(struct i40e_vsi *vsi,
* a specific flow spec * a specific flow spec
* @vsi: pointer to the targeted VSI * @vsi: pointer to the targeted VSI
* @fd_data: the flow director data required for the FDir descriptor * @fd_data: the flow director data required for the FDir descriptor
* @raw_packet: the pre-allocated packet buffer for FDir
* @add: true adds a filter, false removes it * @add: true adds a filter, false removes it
* *
* Always returns -EOPNOTSUPP * Always returns -EOPNOTSUPP
......
...@@ -817,7 +817,7 @@ i40e_status i40evf_asq_send_command(struct i40e_hw *hw, ...@@ -817,7 +817,7 @@ i40e_status i40evf_asq_send_command(struct i40e_hw *hw,
/* ugh! delay while spin_lock */ /* ugh! delay while spin_lock */
udelay(delay_len); udelay(delay_len);
total_delay += delay_len; total_delay += delay_len;
} while (total_delay < hw->aq.asq_cmd_timeout); } while (total_delay < hw->aq.asq_cmd_timeout);
} }
/* if ready, copy the desc back to temp */ /* if ready, copy the desc back to temp */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment