Commit f2fb029b authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

media: atomisp: improve IRQ handling debug messages

When an IRQ is not handled, it is nice to know what's the
reason.
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 495eef11
...@@ -566,7 +566,7 @@ irqreturn_t atomisp_isr(int irq, void *dev) ...@@ -566,7 +566,7 @@ irqreturn_t atomisp_isr(int irq, void *dev)
if (irq_infos & IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF) { if (irq_infos & IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF) {
dev_dbg_ratelimited(isp->dev, dev_dbg_ratelimited(isp->dev,
"irq:0x%x (IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF)\n", "irq:0x%x (SOF)\n",
irq_infos); irq_infos);
irq_infos &= ~IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF; irq_infos &= ~IA_CSS_IRQ_INFO_CSS_RECEIVER_SOF;
} }
...@@ -591,14 +591,14 @@ irqreturn_t atomisp_isr(int irq, void *dev) ...@@ -591,14 +591,14 @@ irqreturn_t atomisp_isr(int irq, void *dev)
/* EOF Event does not have the css_pipe returned */ /* EOF Event does not have the css_pipe returned */
asd = __get_asd_from_port(isp, eof_event.event.port); asd = __get_asd_from_port(isp, eof_event.event.port);
if (!asd) { if (!asd) {
dev_err(isp->dev, "%s:no subdev.event:%d", dev_err(isp->dev, "%s: ISYS event, but no subdev.event:%d",
__func__, eof_event.event.type); __func__, eof_event.event.type);
continue; continue;
} }
atomisp_eof_event(asd, eof_event.event.exp_id); atomisp_eof_event(asd, eof_event.event.exp_id);
dev_dbg_ratelimited(isp->dev, dev_dbg_ratelimited(isp->dev,
"%s EOF exp_id %d, asd %d\n", "%s ISYS event: EOF exp_id %d, asd %d\n",
__func__, eof_event.event.exp_id, __func__, eof_event.event.exp_id,
asd->index); asd->index);
} }
...@@ -610,7 +610,7 @@ irqreturn_t atomisp_isr(int irq, void *dev) ...@@ -610,7 +610,7 @@ irqreturn_t atomisp_isr(int irq, void *dev)
spin_unlock_irqrestore(&isp->lock, flags); spin_unlock_irqrestore(&isp->lock, flags);
dev_dbg_ratelimited(isp->dev, "irq:0x%x\n", irq_infos); dev_dbg_ratelimited(isp->dev, "irq:0x%x (unhandled)\n", irq_infos);
return IRQ_WAKE_THREAD; return IRQ_WAKE_THREAD;
...@@ -618,7 +618,8 @@ irqreturn_t atomisp_isr(int irq, void *dev) ...@@ -618,7 +618,8 @@ irqreturn_t atomisp_isr(int irq, void *dev)
spin_unlock_irqrestore(&isp->lock, flags); spin_unlock_irqrestore(&isp->lock, flags);
if (irq_infos) if (irq_infos)
dev_dbg_ratelimited(isp->dev, "irq:0x%x\n", irq_infos); dev_dbg_ratelimited(isp->dev, "irq:0x%x (ignored, as not streaming anymore)\n",
irq_infos);
return IRQ_HANDLED; return IRQ_HANDLED;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment