Commit f3ff8189 authored by Jubin John's avatar Jubin John Committed by Doug Ledford

staging/rdma/hfi1: Split multiple assignments

Split multiple assignments into individual assignments to fix
checkpatch check:
CHECK: multiple assignments should be avoided
Reviewed-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
Reviewed-by: default avatarMike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: default avatarJubin John <jubin.john@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 3f34d958
...@@ -12459,8 +12459,10 @@ static int request_msix_irqs(struct hfi1_devdata *dd) ...@@ -12459,8 +12459,10 @@ static int request_msix_irqs(struct hfi1_devdata *dd)
/* calculate the ranges we are going to use */ /* calculate the ranges we are going to use */
first_general = 0; first_general = 0;
first_sdma = last_general = first_general + 1; last_general = first_general + 1;
first_rx = last_sdma = first_sdma + dd->num_sdma; first_sdma = last_general;
last_sdma = first_sdma + dd->num_sdma;
first_rx = last_sdma;
last_rx = first_rx + dd->n_krcv_queues; last_rx = first_rx + dd->n_krcv_queues;
/* /*
......
...@@ -896,8 +896,8 @@ static int port_states_transition_allowed(struct hfi1_pportdata *ppd, ...@@ -896,8 +896,8 @@ static int port_states_transition_allowed(struct hfi1_pportdata *ppd,
u32 logical_old = driver_logical_state(ppd); u32 logical_old = driver_logical_state(ppd);
int ret, logical_allowed, physical_allowed; int ret, logical_allowed, physical_allowed;
logical_allowed = ret = ret = logical_transition_allowed(logical_old, logical_new);
logical_transition_allowed(logical_old, logical_new); logical_allowed = ret;
if (ret == HFI_TRANSITION_DISALLOWED || if (ret == HFI_TRANSITION_DISALLOWED ||
ret == HFI_TRANSITION_UNDEFINED) { ret == HFI_TRANSITION_UNDEFINED) {
...@@ -907,8 +907,8 @@ static int port_states_transition_allowed(struct hfi1_pportdata *ppd, ...@@ -907,8 +907,8 @@ static int port_states_transition_allowed(struct hfi1_pportdata *ppd,
return ret; return ret;
} }
physical_allowed = ret = ret = physical_transition_allowed(physical_old, physical_new);
physical_transition_allowed(physical_old, physical_new); physical_allowed = ret;
if (ret == HFI_TRANSITION_DISALLOWED || if (ret == HFI_TRANSITION_DISALLOWED ||
ret == HFI_TRANSITION_UNDEFINED) { ret == HFI_TRANSITION_UNDEFINED) {
......
...@@ -565,7 +565,8 @@ static inline int sdma_txinit_ahg( ...@@ -565,7 +565,8 @@ static inline int sdma_txinit_ahg(
tx->complete = cb; tx->complete = cb;
tx->coalesce_buf = NULL; tx->coalesce_buf = NULL;
tx->wait = NULL; tx->wait = NULL;
tx->tlen = tx->packet_len = tlen; tx->packet_len = tlen;
tx->tlen = tx->packet_len;
tx->descs[0].qw[0] = SDMA_DESC0_FIRST_DESC_FLAG; tx->descs[0].qw[0] = SDMA_DESC0_FIRST_DESC_FLAG;
tx->descs[0].qw[1] = 0; tx->descs[0].qw[1] = 0;
if (flags & SDMA_TXREQ_F_AHG_COPY) if (flags & SDMA_TXREQ_F_AHG_COPY)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment