Commit f414c16c authored by Michal Miroslaw's avatar Michal Miroslaw Committed by David S. Miller

[NETFILTER]: nfnetlink_log: micro-optimization for inst==NULL in nfulnl_recv_config()

Simple micro-optimization: don't call instance_put() on known NULL pointers.
Signed-off-by: default avatarMichal Miroslaw <mirq-linux@rere.qmqm.pl>
Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 55b5a91e
...@@ -810,13 +810,13 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb, ...@@ -810,13 +810,13 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb,
NETLINK_CB(skb).pid); NETLINK_CB(skb).pid);
if (!inst) { if (!inst) {
ret = -EINVAL; ret = -EINVAL;
goto out_put; goto out;
} }
break; break;
case NFULNL_CFG_CMD_UNBIND: case NFULNL_CFG_CMD_UNBIND:
if (!inst) { if (!inst) {
ret = -ENODEV; ret = -ENODEV;
goto out_put; goto out;
} }
if (inst->peer_pid != NETLINK_CB(skb).pid) { if (inst->peer_pid != NETLINK_CB(skb).pid) {
...@@ -849,7 +849,7 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb, ...@@ -849,7 +849,7 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb,
"group=%u pid=%u =>ENOENT\n", "group=%u pid=%u =>ENOENT\n",
group_num, NETLINK_CB(skb).pid); group_num, NETLINK_CB(skb).pid);
ret = -ENOENT; ret = -ENOENT;
goto out_put; goto out;
} }
if (inst->peer_pid != NETLINK_CB(skb).pid) { if (inst->peer_pid != NETLINK_CB(skb).pid) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment