Commit f49a951f authored by Tomi Valkeinen's avatar Tomi Valkeinen

OMAP: DSS2: Make partial update width even

There are some strange problems with DSI and updates with odd widths. One
particular problem is that HS TX timeout triggers easily with updates with
odd widths.

This patch makes the updates widths even, circumventing the problem. There
should be no ill side effects with increasing the update area slightly to
make the width even.
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@nokia.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@nokia.com>
parent 279fcd48
...@@ -940,6 +940,22 @@ static int configure_dispc(void) ...@@ -940,6 +940,22 @@ static int configure_dispc(void)
return r; return r;
} }
/* Make the coordinates even. There are some strange problems with OMAP and
* partial DSI update when the update widths are odd. */
static void make_even(u16 *x, u16 *w)
{
u16 x1, x2;
x1 = *x;
x2 = *x + *w;
x1 &= ~1;
x2 = ALIGN(x2, 2);
*x = x1;
*w = x2 - x1;
}
/* Configure dispc for partial update. Return possibly modified update /* Configure dispc for partial update. Return possibly modified update
* area */ * area */
void dss_setup_partial_planes(struct omap_dss_device *dssdev, void dss_setup_partial_planes(struct omap_dss_device *dssdev,
...@@ -968,6 +984,8 @@ void dss_setup_partial_planes(struct omap_dss_device *dssdev, ...@@ -968,6 +984,8 @@ void dss_setup_partial_planes(struct omap_dss_device *dssdev,
return; return;
} }
make_even(&x, &w);
spin_lock_irqsave(&dss_cache.lock, flags); spin_lock_irqsave(&dss_cache.lock, flags);
/* We need to show the whole overlay if it is scaled. So look for /* We need to show the whole overlay if it is scaled. So look for
...@@ -1029,6 +1047,8 @@ void dss_setup_partial_planes(struct omap_dss_device *dssdev, ...@@ -1029,6 +1047,8 @@ void dss_setup_partial_planes(struct omap_dss_device *dssdev,
w = x2 - x1; w = x2 - x1;
h = y2 - y1; h = y2 - y1;
make_even(&x, &w);
DSSDBG("changing upd area due to ovl(%d) scaling %d,%d %dx%d\n", DSSDBG("changing upd area due to ovl(%d) scaling %d,%d %dx%d\n",
i, x, y, w, h); i, x, y, w, h);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment