Commit f4bb1f89 authored by Souptick Joarder's avatar Souptick Joarder Committed by Miguel Ojeda

auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero()

While using mmap, the incorrect values of length and vm_pgoff are
ignored and this driver goes ahead with mapping fbdev.buffer
to user vma.

Convert vm_insert_pages() to use vm_map_pages_zero(). We could later
"fix" these drivers to behave according to the normal vm_pgoff
offsetting simply by removing the _zero suffix on the function name
and if that causes regressions, it gives us an easy way to revert.
Signed-off-by: default avatarSouptick Joarder <jrdr.linux@gmail.com>
Acked-by: default avatarRobin van der Gracht <robin@protonic.nl>
Signed-off-by: default avatarMiguel Ojeda <miguel.ojeda.sandonis@gmail.com>
parent 461e274b
...@@ -223,9 +223,9 @@ static const struct backlight_ops ht16k33_bl_ops = { ...@@ -223,9 +223,9 @@ static const struct backlight_ops ht16k33_bl_ops = {
static int ht16k33_mmap(struct fb_info *info, struct vm_area_struct *vma) static int ht16k33_mmap(struct fb_info *info, struct vm_area_struct *vma)
{ {
struct ht16k33_priv *priv = info->par; struct ht16k33_priv *priv = info->par;
struct page *pages = virt_to_page(priv->fbdev.buffer);
return vm_insert_page(vma, vma->vm_start, return vm_map_pages_zero(vma, &pages, 1);
virt_to_page(priv->fbdev.buffer));
} }
static struct fb_ops ht16k33_fb_ops = { static struct fb_ops ht16k33_fb_ops = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment