Commit f54d801d authored by Coly Li's avatar Coly Li Committed by Jens Axboe

bcache: destroy dc->writeback_write_wq if failed to create dc->writeback_thread

Commit 9baf3097 ("bcache: fix for gc and write-back race") added a
new work queue dc->writeback_write_wq, but forgot to destroy it in the
error condition when creating dc->writeback_thread failed.

This patch destroys dc->writeback_write_wq if kthread_create() returns
error pointer to dc->writeback_thread, then a memory leak is avoided.

Fixes: 9baf3097 ("bcache: fix for gc and write-back race")
Signed-off-by: default avatarColy Li <colyli@suse.de>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 54619998
...@@ -833,6 +833,7 @@ int bch_cached_dev_writeback_start(struct cached_dev *dc) ...@@ -833,6 +833,7 @@ int bch_cached_dev_writeback_start(struct cached_dev *dc)
"bcache_writeback"); "bcache_writeback");
if (IS_ERR(dc->writeback_thread)) { if (IS_ERR(dc->writeback_thread)) {
cached_dev_put(dc); cached_dev_put(dc);
destroy_workqueue(dc->writeback_write_wq);
return PTR_ERR(dc->writeback_thread); return PTR_ERR(dc->writeback_thread);
} }
dc->writeback_running = true; dc->writeback_running = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment