Commit f62c6d0a authored by Neil Horman's avatar Neil Horman Committed by Linus Torvalds

[PATCH] Add missing overflow check in get_blkdev_list

Patch to clean up missing overflow check in get_blkdev_list.  The printf
which adds the "Block Devices" string in /proc/devices can overflow the
presented page if get_chrdev_list eats up the entire 4k space.
Signed-off-by: default avatarNeil Horman <nhorman@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent f23ef184
...@@ -45,7 +45,7 @@ int get_blkdev_list(char *p, int used) ...@@ -45,7 +45,7 @@ int get_blkdev_list(char *p, int used)
struct blk_major_name *n; struct blk_major_name *n;
int i, len; int i, len;
len = sprintf(p, "\nBlock devices:\n"); len = snprintf(p, (PAGE_SIZE-used), "\nBlock devices:\n");
down(&block_subsys_sem); down(&block_subsys_sem);
for (i = 0; i < ARRAY_SIZE(major_names); i++) { for (i = 0; i < ARRAY_SIZE(major_names); i++) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment