Commit f6e3685e authored by Vincent Hanquez's avatar Vincent Hanquez Committed by Linus Torvalds

[PATCH] arch/i386/kernel/signal.c: fix err test twice

Hi, the following patch:
	- correct the err variable tested twice when _NSIG_WORDS == 1
	  (unlikely to happen, but ..)
	- remove some |= in favor of = because we don't need to 'pack' err
Signed-off-by: default avatarVincent Hanquez <tab@snarc.org>
Acked-by: default avatarIngo Molnar <mingo@elte.hu>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 5d3175c0
...@@ -365,20 +365,20 @@ static void setup_frame(int sig, struct k_sigaction *ka, ...@@ -365,20 +365,20 @@ static void setup_frame(int sig, struct k_sigaction *ka,
? current_thread_info()->exec_domain->signal_invmap[sig] ? current_thread_info()->exec_domain->signal_invmap[sig]
: sig; : sig;
err |= __put_user(usig, &frame->sig); err = __put_user(usig, &frame->sig);
if (err) if (err)
goto give_sigsegv; goto give_sigsegv;
err |= setup_sigcontext(&frame->sc, &frame->fpstate, regs, set->sig[0]); err = setup_sigcontext(&frame->sc, &frame->fpstate, regs, set->sig[0]);
if (err) if (err)
goto give_sigsegv; goto give_sigsegv;
if (_NSIG_WORDS > 1) { if (_NSIG_WORDS > 1) {
err |= __copy_to_user(&frame->extramask, &set->sig[1], err = __copy_to_user(&frame->extramask, &set->sig[1],
sizeof(frame->extramask)); sizeof(frame->extramask));
if (err)
goto give_sigsegv;
} }
if (err)
goto give_sigsegv;
restorer = &__kernel_sigreturn; restorer = &__kernel_sigreturn;
if (ka->sa.sa_flags & SA_RESTORER) if (ka->sa.sa_flags & SA_RESTORER)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment