Commit f74a127f authored by Linus Torvalds's avatar Linus Torvalds

Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

Pull irq fixes from Thomas Gleixner:
 "Two small changes:

   - a fix for a interrupt regression caused by the vector management
     changes in 4.15 affecting museum pieces which rely on interrupt
     probing for legacy (e.g. parallel port) devices.

     One of the startup calls in the autoprobe code was not changed to
     the new activate_and_startup() function resulting in a warning and
     as a consequence failing to discover the device interrupt.

   - a trivial update to the copyright/license header of the STM32 irq
     chip driver"

* 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  genirq: Make legacy autoprobing work again
  irqchip/stm32: Fix copyright
parents 64b28683 1beaeacd
// SPDX-License-Identifier: GPL-2.0
/* /*
* Copyright (C) Maxime Coquelin 2015 * Copyright (C) Maxime Coquelin 2015
* Copyright (C) STMicroelectronics 2017
* Author: Maxime Coquelin <mcoquelin.stm32@gmail.com> * Author: Maxime Coquelin <mcoquelin.stm32@gmail.com>
* License terms: GNU General Public License (GPL), version 2
*/ */
#include <linux/bitops.h> #include <linux/bitops.h>
......
...@@ -71,7 +71,7 @@ unsigned long probe_irq_on(void) ...@@ -71,7 +71,7 @@ unsigned long probe_irq_on(void)
raw_spin_lock_irq(&desc->lock); raw_spin_lock_irq(&desc->lock);
if (!desc->action && irq_settings_can_probe(desc)) { if (!desc->action && irq_settings_can_probe(desc)) {
desc->istate |= IRQS_AUTODETECT | IRQS_WAITING; desc->istate |= IRQS_AUTODETECT | IRQS_WAITING;
if (irq_startup(desc, IRQ_NORESEND, IRQ_START_FORCE)) if (irq_activate_and_startup(desc, IRQ_NORESEND))
desc->istate |= IRQS_PENDING; desc->istate |= IRQS_PENDING;
} }
raw_spin_unlock_irq(&desc->lock); raw_spin_unlock_irq(&desc->lock);
......
...@@ -294,11 +294,11 @@ int irq_activate(struct irq_desc *desc) ...@@ -294,11 +294,11 @@ int irq_activate(struct irq_desc *desc)
return 0; return 0;
} }
void irq_activate_and_startup(struct irq_desc *desc, bool resend) int irq_activate_and_startup(struct irq_desc *desc, bool resend)
{ {
if (WARN_ON(irq_activate(desc))) if (WARN_ON(irq_activate(desc)))
return; return 0;
irq_startup(desc, resend, IRQ_START_FORCE); return irq_startup(desc, resend, IRQ_START_FORCE);
} }
static void __irq_disable(struct irq_desc *desc, bool mask); static void __irq_disable(struct irq_desc *desc, bool mask);
......
...@@ -76,7 +76,7 @@ extern void __enable_irq(struct irq_desc *desc); ...@@ -76,7 +76,7 @@ extern void __enable_irq(struct irq_desc *desc);
#define IRQ_START_COND false #define IRQ_START_COND false
extern int irq_activate(struct irq_desc *desc); extern int irq_activate(struct irq_desc *desc);
extern void irq_activate_and_startup(struct irq_desc *desc, bool resend); extern int irq_activate_and_startup(struct irq_desc *desc, bool resend);
extern int irq_startup(struct irq_desc *desc, bool resend, bool force); extern int irq_startup(struct irq_desc *desc, bool resend, bool force);
extern void irq_shutdown(struct irq_desc *desc); extern void irq_shutdown(struct irq_desc *desc);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment