Commit f88c5b98 authored by Sriram's avatar Sriram Committed by David S. Miller

smsc911x: Fix Console Hang when bringing the interface down.

In the NAPI poll function, check for netif_running() is unnecassary.
In addition to associated runtime overhead, it also results in
continuous softirq loop when the interface is brought down under heavy
traffic(tested with Traffic Generator).Once the interface is disabled,
the poll function always returns zero(with the check for netif_running)
and napi_complete() would never get called resulting in softirq loop.
Signed-off-by: default avatarSriramakrishnan <srk@ti.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2c554e10
...@@ -986,7 +986,7 @@ static int smsc911x_poll(struct napi_struct *napi, int budget) ...@@ -986,7 +986,7 @@ static int smsc911x_poll(struct napi_struct *napi, int budget)
struct net_device *dev = pdata->dev; struct net_device *dev = pdata->dev;
int npackets = 0; int npackets = 0;
while (likely(netif_running(dev)) && (npackets < budget)) { while (npackets < budget) {
unsigned int pktlength; unsigned int pktlength;
unsigned int pktwords; unsigned int pktwords;
struct sk_buff *skb; struct sk_buff *skb;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment