Commit f9442ac4 authored by Sinan Kaya's avatar Sinan Kaya Committed by David S. Miller

qlcnic: Eliminate duplicate barriers on weakly-ordered archs

Code includes wmb() followed by writel(). writel() already has a
barrier on some architectures like arm64.

This ends up CPU observing two barriers back to back before executing
the register write.

Since code already has an explicit barrier call, changing writel() to
writel_relaxed().
Signed-off-by: default avatarSinan Kaya <okaya@codeaurora.org>
Acked-by: default avatarManish Chopra <manish.chopra@cavium.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3c95c567
...@@ -478,7 +478,7 @@ irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *adapter) ...@@ -478,7 +478,7 @@ irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *adapter)
wmb(); wmb();
/* clear the interrupt trigger control register */ /* clear the interrupt trigger control register */
writel(0, adapter->isr_int_vec); writel_relaxed(0, adapter->isr_int_vec);
intr_val = readl(adapter->isr_int_vec); intr_val = readl(adapter->isr_int_vec);
do { do {
intr_val = readl(adapter->tgt_status_reg); intr_val = readl(adapter->tgt_status_reg);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment