Commit f95c74e3 authored by Jan Engelhardt's avatar Jan Engelhardt

netfilter: xtables: shorten up return clause

The return value of nf_ct_l3proto_get can directly be returned even in
the case of success.
Signed-off-by: default avatarJan Engelhardt <jengelh@medozas.de>
parent 4a5a5c73
...@@ -403,13 +403,10 @@ static int clusterip_tg_check(const struct xt_tgchk_param *par) ...@@ -403,13 +403,10 @@ static int clusterip_tg_check(const struct xt_tgchk_param *par)
cipinfo->config = config; cipinfo->config = config;
ret = nf_ct_l3proto_try_module_get(par->family); ret = nf_ct_l3proto_try_module_get(par->family);
if (ret < 0) { if (ret < 0)
pr_info("cannot load conntrack support for proto=%u\n", pr_info("cannot load conntrack support for proto=%u\n",
par->family); par->family);
return ret; return ret;
}
return 0;
} }
/* drop reference count of cluster config when rule is deleted */ /* drop reference count of cluster config when rule is deleted */
......
...@@ -107,12 +107,10 @@ static int connsecmark_tg_check(const struct xt_tgchk_param *par) ...@@ -107,12 +107,10 @@ static int connsecmark_tg_check(const struct xt_tgchk_param *par)
} }
ret = nf_ct_l3proto_try_module_get(par->family); ret = nf_ct_l3proto_try_module_get(par->family);
if (ret < 0) { if (ret < 0)
pr_info("cannot load conntrack support for proto=%u\n", pr_info("cannot load conntrack support for proto=%u\n",
par->family); par->family);
return ret; return ret;
}
return 0;
} }
static void connsecmark_tg_destroy(const struct xt_tgdtor_param *par) static void connsecmark_tg_destroy(const struct xt_tgdtor_param *par)
......
...@@ -109,13 +109,10 @@ static int connbytes_mt_check(const struct xt_mtchk_param *par) ...@@ -109,13 +109,10 @@ static int connbytes_mt_check(const struct xt_mtchk_param *par)
return -EINVAL; return -EINVAL;
ret = nf_ct_l3proto_try_module_get(par->family); ret = nf_ct_l3proto_try_module_get(par->family);
if (ret < 0) { if (ret < 0)
pr_info("cannot load conntrack support for proto=%u\n", pr_info("cannot load conntrack support for proto=%u\n",
par->family); par->family);
return ret; return ret;
}
return 0;
} }
static void connbytes_mt_destroy(const struct xt_mtdtor_param *par) static void connbytes_mt_destroy(const struct xt_mtdtor_param *par)
......
...@@ -79,12 +79,10 @@ static int connmark_tg_check(const struct xt_tgchk_param *par) ...@@ -79,12 +79,10 @@ static int connmark_tg_check(const struct xt_tgchk_param *par)
int ret; int ret;
ret = nf_ct_l3proto_try_module_get(par->family); ret = nf_ct_l3proto_try_module_get(par->family);
if (ret < 0) { if (ret < 0)
pr_info("cannot load conntrack support for proto=%u\n", pr_info("cannot load conntrack support for proto=%u\n",
par->family); par->family);
return ret; return ret;
}
return 0;
} }
static void connmark_tg_destroy(const struct xt_tgdtor_param *par) static void connmark_tg_destroy(const struct xt_tgdtor_param *par)
...@@ -111,12 +109,10 @@ static int connmark_mt_check(const struct xt_mtchk_param *par) ...@@ -111,12 +109,10 @@ static int connmark_mt_check(const struct xt_mtchk_param *par)
int ret; int ret;
ret = nf_ct_l3proto_try_module_get(par->family); ret = nf_ct_l3proto_try_module_get(par->family);
if (ret < 0) { if (ret < 0)
pr_info("cannot load conntrack support for proto=%u\n", pr_info("cannot load conntrack support for proto=%u\n",
par->family); par->family);
return ret; return ret;
}
return 0;
} }
static void connmark_mt_destroy(const struct xt_mtdtor_param *par) static void connmark_mt_destroy(const struct xt_mtdtor_param *par)
......
...@@ -211,12 +211,10 @@ static int conntrack_mt_check(const struct xt_mtchk_param *par) ...@@ -211,12 +211,10 @@ static int conntrack_mt_check(const struct xt_mtchk_param *par)
int ret; int ret;
ret = nf_ct_l3proto_try_module_get(par->family); ret = nf_ct_l3proto_try_module_get(par->family);
if (ret < 0) { if (ret < 0)
pr_info("cannot load conntrack support for proto=%u\n", pr_info("cannot load conntrack support for proto=%u\n",
par->family); par->family);
return ret; return ret;
}
return 0;
} }
static void conntrack_mt_destroy(const struct xt_mtdtor_param *par) static void conntrack_mt_destroy(const struct xt_mtdtor_param *par)
......
...@@ -42,12 +42,10 @@ static int state_mt_check(const struct xt_mtchk_param *par) ...@@ -42,12 +42,10 @@ static int state_mt_check(const struct xt_mtchk_param *par)
int ret; int ret;
ret = nf_ct_l3proto_try_module_get(par->family); ret = nf_ct_l3proto_try_module_get(par->family);
if (ret < 0) { if (ret < 0)
pr_info("cannot load conntrack support for proto=%u\n", pr_info("cannot load conntrack support for proto=%u\n",
par->family); par->family);
return ret; return ret;
}
return 0;
} }
static void state_mt_destroy(const struct xt_mtdtor_param *par) static void state_mt_destroy(const struct xt_mtdtor_param *par)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment