Commit fb27bc03 authored by Linus Torvalds's avatar Linus Torvalds

Merge tag 'usb-5.7-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb

Pull USB fixes from Greg KH:
 "Here are a number of USB fixes for 5.7-rc6

  The "largest" in here is a bunch of raw-gadget fixes and api changes
  as the driver just showed up in -rc1 and work has been done to fix up
  some uapi issues found with the original submission, before it shows
  up in a -final release.

  Other than that, a bunch of other small USB gadget fixes, xhci fixes,
  some quirks, andother tiny fixes for reported issues.

  All of these have been in linux-next with no reported issues"

* tag 'usb-5.7-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb: (26 commits)
  USB: gadget: fix illegal array access in binding with UDC
  usb: core: hub: limit HUB_QUIRK_DISABLE_AUTOSUSPEND to USB5534B
  USB: usbfs: fix mmap dma mismatch
  usb: host: xhci-plat: keep runtime active when removing host
  usb: xhci: Fix NULL pointer dereference when enqueuing trbs from urb sg list
  usb: cdns3: gadget: make a bunch of functions static
  usb: mtu3: constify struct debugfs_reg32
  usb: gadget: udc: atmel: Make some symbols static
  usb: raw-gadget: fix null-ptr-deref when reenabling endpoints
  usb: raw-gadget: documentation updates
  usb: raw-gadget: support stalling/halting/wedging endpoints
  usb: raw-gadget: fix gadget endpoint selection
  usb: raw-gadget: improve uapi headers comments
  usb: typec: mux: intel: Fix DP_HPD_LVL bit field
  usb: raw-gadget: fix return value of ep read ioctls
  usb: dwc3: select USB_ROLE_SWITCH
  usb: gadget: legacy: fix error return code in gncm_bind()
  usb: gadget: legacy: fix error return code in cdc_bind()
  usb: gadget: legacy: fix redundant initialization warnings
  usb: gadget: tegra-xudc: Fix idle suspend/resume
  ...
parents b48397cb 15753588
...@@ -27,9 +27,8 @@ differences are: ...@@ -27,9 +27,8 @@ differences are:
3. Raw Gadget provides a way to select a UDC device/driver to bind to, 3. Raw Gadget provides a way to select a UDC device/driver to bind to,
while GadgetFS currently binds to the first available UDC. while GadgetFS currently binds to the first available UDC.
4. Raw Gadget uses predictable endpoint names (handles) across different 4. Raw Gadget explicitly exposes information about endpoints addresses and
UDCs (as long as UDCs have enough endpoints of each required transfer capabilities allowing a user to write UDC-agnostic gadgets.
type).
5. Raw Gadget has ioctl-based interface instead of a filesystem-based one. 5. Raw Gadget has ioctl-based interface instead of a filesystem-based one.
...@@ -50,12 +49,36 @@ The typical usage of Raw Gadget looks like: ...@@ -50,12 +49,36 @@ The typical usage of Raw Gadget looks like:
Raw Gadget and react to those depending on what kind of USB device Raw Gadget and react to those depending on what kind of USB device
needs to be emulated. needs to be emulated.
Note, that some UDC drivers have fixed addresses assigned to endpoints, and
therefore arbitrary endpoint addresses can't be used in the descriptors.
Nevertheles, Raw Gadget provides a UDC-agnostic way to write USB gadgets.
Once a USB_RAW_EVENT_CONNECT event is received via USB_RAW_IOCTL_EVENT_FETCH,
the USB_RAW_IOCTL_EPS_INFO ioctl can be used to find out information about
endpoints that the UDC driver has. Based on that information, the user must
chose UDC endpoints that will be used for the gadget being emulated, and
properly assign addresses in endpoint descriptors.
You can find usage examples (along with a test suite) here:
https://github.com/xairy/raw-gadget
Internal details
~~~~~~~~~~~~~~~~
Currently every endpoint read/write ioctl submits a USB request and waits until
its completion. This is the desired mode for coverage-guided fuzzing (as we'd
like all USB request processing happen during the lifetime of a syscall),
and must be kept in the implementation. (This might be slow for real world
applications, thus the O_NONBLOCK improvement suggestion below.)
Potential future improvements Potential future improvements
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- Implement ioctl's for setting/clearing halt status on endpoints. - Report more events (suspend, resume, etc.) through USB_RAW_IOCTL_EVENT_FETCH.
- Reporting more events (suspend, resume, etc.) through
USB_RAW_IOCTL_EVENT_FETCH.
- Support O_NONBLOCK I/O. - Support O_NONBLOCK I/O.
- Support USB 3 features (accept SS endpoint companion descriptor when
enabling endpoints; allow providing stream_id for bulk transfers).
- Support ISO transfer features (expose frame_number for completed requests).
...@@ -82,7 +82,7 @@ static int cdns3_ep_run_stream_transfer(struct cdns3_endpoint *priv_ep, ...@@ -82,7 +82,7 @@ static int cdns3_ep_run_stream_transfer(struct cdns3_endpoint *priv_ep,
* @ptr: address of device controller register to be read and changed * @ptr: address of device controller register to be read and changed
* @mask: bits requested to clar * @mask: bits requested to clar
*/ */
void cdns3_clear_register_bit(void __iomem *ptr, u32 mask) static void cdns3_clear_register_bit(void __iomem *ptr, u32 mask)
{ {
mask = readl(ptr) & ~mask; mask = readl(ptr) & ~mask;
writel(mask, ptr); writel(mask, ptr);
...@@ -137,7 +137,7 @@ struct usb_request *cdns3_next_request(struct list_head *list) ...@@ -137,7 +137,7 @@ struct usb_request *cdns3_next_request(struct list_head *list)
* *
* Returns buffer or NULL if no buffers in list * Returns buffer or NULL if no buffers in list
*/ */
struct cdns3_aligned_buf *cdns3_next_align_buf(struct list_head *list) static struct cdns3_aligned_buf *cdns3_next_align_buf(struct list_head *list)
{ {
return list_first_entry_or_null(list, struct cdns3_aligned_buf, list); return list_first_entry_or_null(list, struct cdns3_aligned_buf, list);
} }
...@@ -148,7 +148,7 @@ struct cdns3_aligned_buf *cdns3_next_align_buf(struct list_head *list) ...@@ -148,7 +148,7 @@ struct cdns3_aligned_buf *cdns3_next_align_buf(struct list_head *list)
* *
* Returns request or NULL if no requests in list * Returns request or NULL if no requests in list
*/ */
struct cdns3_request *cdns3_next_priv_request(struct list_head *list) static struct cdns3_request *cdns3_next_priv_request(struct list_head *list)
{ {
return list_first_entry_or_null(list, struct cdns3_request, list); return list_first_entry_or_null(list, struct cdns3_request, list);
} }
...@@ -190,7 +190,7 @@ dma_addr_t cdns3_trb_virt_to_dma(struct cdns3_endpoint *priv_ep, ...@@ -190,7 +190,7 @@ dma_addr_t cdns3_trb_virt_to_dma(struct cdns3_endpoint *priv_ep,
return priv_ep->trb_pool_dma + offset; return priv_ep->trb_pool_dma + offset;
} }
int cdns3_ring_size(struct cdns3_endpoint *priv_ep) static int cdns3_ring_size(struct cdns3_endpoint *priv_ep)
{ {
switch (priv_ep->type) { switch (priv_ep->type) {
case USB_ENDPOINT_XFER_ISOC: case USB_ENDPOINT_XFER_ISOC:
...@@ -345,7 +345,7 @@ static void cdns3_ep_inc_deq(struct cdns3_endpoint *priv_ep) ...@@ -345,7 +345,7 @@ static void cdns3_ep_inc_deq(struct cdns3_endpoint *priv_ep)
cdns3_ep_inc_trb(&priv_ep->dequeue, &priv_ep->ccs, priv_ep->num_trbs); cdns3_ep_inc_trb(&priv_ep->dequeue, &priv_ep->ccs, priv_ep->num_trbs);
} }
void cdns3_move_deq_to_next_trb(struct cdns3_request *priv_req) static void cdns3_move_deq_to_next_trb(struct cdns3_request *priv_req)
{ {
struct cdns3_endpoint *priv_ep = priv_req->priv_ep; struct cdns3_endpoint *priv_ep = priv_req->priv_ep;
int current_trb = priv_req->start_trb; int current_trb = priv_req->start_trb;
...@@ -511,7 +511,7 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep, ...@@ -511,7 +511,7 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
} }
} }
struct usb_request *cdns3_wa2_gadget_giveback(struct cdns3_device *priv_dev, static struct usb_request *cdns3_wa2_gadget_giveback(struct cdns3_device *priv_dev,
struct cdns3_endpoint *priv_ep, struct cdns3_endpoint *priv_ep,
struct cdns3_request *priv_req) struct cdns3_request *priv_req)
{ {
...@@ -551,7 +551,7 @@ struct usb_request *cdns3_wa2_gadget_giveback(struct cdns3_device *priv_dev, ...@@ -551,7 +551,7 @@ struct usb_request *cdns3_wa2_gadget_giveback(struct cdns3_device *priv_dev,
return &priv_req->request; return &priv_req->request;
} }
int cdns3_wa2_gadget_ep_queue(struct cdns3_device *priv_dev, static int cdns3_wa2_gadget_ep_queue(struct cdns3_device *priv_dev,
struct cdns3_endpoint *priv_ep, struct cdns3_endpoint *priv_ep,
struct cdns3_request *priv_req) struct cdns3_request *priv_req)
{ {
...@@ -836,7 +836,7 @@ void cdns3_gadget_giveback(struct cdns3_endpoint *priv_ep, ...@@ -836,7 +836,7 @@ void cdns3_gadget_giveback(struct cdns3_endpoint *priv_ep,
cdns3_gadget_ep_free_request(&priv_ep->endpoint, request); cdns3_gadget_ep_free_request(&priv_ep->endpoint, request);
} }
void cdns3_wa1_restore_cycle_bit(struct cdns3_endpoint *priv_ep) static void cdns3_wa1_restore_cycle_bit(struct cdns3_endpoint *priv_ep)
{ {
/* Work around for stale data address in TRB*/ /* Work around for stale data address in TRB*/
if (priv_ep->wa1_set) { if (priv_ep->wa1_set) {
...@@ -1904,7 +1904,7 @@ static int cdns3_ep_onchip_buffer_reserve(struct cdns3_device *priv_dev, ...@@ -1904,7 +1904,7 @@ static int cdns3_ep_onchip_buffer_reserve(struct cdns3_device *priv_dev,
return 0; return 0;
} }
void cdns3_stream_ep_reconfig(struct cdns3_device *priv_dev, static void cdns3_stream_ep_reconfig(struct cdns3_device *priv_dev,
struct cdns3_endpoint *priv_ep) struct cdns3_endpoint *priv_ep)
{ {
if (!priv_ep->use_streams || priv_dev->gadget.speed < USB_SPEED_SUPER) if (!priv_ep->use_streams || priv_dev->gadget.speed < USB_SPEED_SUPER)
...@@ -1925,7 +1925,7 @@ void cdns3_stream_ep_reconfig(struct cdns3_device *priv_dev, ...@@ -1925,7 +1925,7 @@ void cdns3_stream_ep_reconfig(struct cdns3_device *priv_dev,
EP_CFG_TDL_CHK | EP_CFG_SID_CHK); EP_CFG_TDL_CHK | EP_CFG_SID_CHK);
} }
void cdns3_configure_dmult(struct cdns3_device *priv_dev, static void cdns3_configure_dmult(struct cdns3_device *priv_dev,
struct cdns3_endpoint *priv_ep) struct cdns3_endpoint *priv_ep)
{ {
struct cdns3_usb_regs __iomem *regs = priv_dev->regs; struct cdns3_usb_regs __iomem *regs = priv_dev->regs;
...@@ -2548,7 +2548,7 @@ int cdns3_gadget_ep_dequeue(struct usb_ep *ep, ...@@ -2548,7 +2548,7 @@ int cdns3_gadget_ep_dequeue(struct usb_ep *ep,
link_trb = priv_req->trb; link_trb = priv_req->trb;
/* Update ring only if removed request is on pending_req_list list */ /* Update ring only if removed request is on pending_req_list list */
if (req_on_hw_ring) { if (req_on_hw_ring && link_trb) {
link_trb->buffer = TRB_BUFFER(priv_ep->trb_pool_dma + link_trb->buffer = TRB_BUFFER(priv_ep->trb_pool_dma +
((priv_req->end_trb + 1) * TRB_SIZE)); ((priv_req->end_trb + 1) * TRB_SIZE));
link_trb->control = (link_trb->control & TRB_CYCLE) | link_trb->control = (link_trb->control & TRB_CYCLE) |
......
...@@ -251,9 +251,19 @@ static int usbdev_mmap(struct file *file, struct vm_area_struct *vma) ...@@ -251,9 +251,19 @@ static int usbdev_mmap(struct file *file, struct vm_area_struct *vma)
usbm->vma_use_count = 1; usbm->vma_use_count = 1;
INIT_LIST_HEAD(&usbm->memlist); INIT_LIST_HEAD(&usbm->memlist);
if (dma_mmap_coherent(hcd->self.sysdev, vma, mem, dma_handle, size)) { if (hcd->localmem_pool || !hcd_uses_dma(hcd)) {
dec_usb_memory_use_count(usbm, &usbm->vma_use_count); if (remap_pfn_range(vma, vma->vm_start,
return -EAGAIN; virt_to_phys(usbm->mem) >> PAGE_SHIFT,
size, vma->vm_page_prot) < 0) {
dec_usb_memory_use_count(usbm, &usbm->vma_use_count);
return -EAGAIN;
}
} else {
if (dma_mmap_coherent(hcd->self.sysdev, vma, mem, dma_handle,
size)) {
dec_usb_memory_use_count(usbm, &usbm->vma_use_count);
return -EAGAIN;
}
} }
vma->vm_flags |= VM_IO; vma->vm_flags |= VM_IO;
......
...@@ -39,6 +39,7 @@ ...@@ -39,6 +39,7 @@
#define USB_VENDOR_GENESYS_LOGIC 0x05e3 #define USB_VENDOR_GENESYS_LOGIC 0x05e3
#define USB_VENDOR_SMSC 0x0424 #define USB_VENDOR_SMSC 0x0424
#define USB_PRODUCT_USB5534B 0x5534
#define HUB_QUIRK_CHECK_PORT_AUTOSUSPEND 0x01 #define HUB_QUIRK_CHECK_PORT_AUTOSUSPEND 0x01
#define HUB_QUIRK_DISABLE_AUTOSUSPEND 0x02 #define HUB_QUIRK_DISABLE_AUTOSUSPEND 0x02
...@@ -5621,8 +5622,11 @@ static void hub_event(struct work_struct *work) ...@@ -5621,8 +5622,11 @@ static void hub_event(struct work_struct *work)
} }
static const struct usb_device_id hub_id_table[] = { static const struct usb_device_id hub_id_table[] = {
{ .match_flags = USB_DEVICE_ID_MATCH_VENDOR | USB_DEVICE_ID_MATCH_INT_CLASS, { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
| USB_DEVICE_ID_MATCH_PRODUCT
| USB_DEVICE_ID_MATCH_INT_CLASS,
.idVendor = USB_VENDOR_SMSC, .idVendor = USB_VENDOR_SMSC,
.idProduct = USB_PRODUCT_USB5534B,
.bInterfaceClass = USB_CLASS_HUB, .bInterfaceClass = USB_CLASS_HUB,
.driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND}, .driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
{ .match_flags = USB_DEVICE_ID_MATCH_VENDOR { .match_flags = USB_DEVICE_ID_MATCH_VENDOR
......
...@@ -4,6 +4,7 @@ config USB_DWC3 ...@@ -4,6 +4,7 @@ config USB_DWC3
tristate "DesignWare USB3 DRD Core Support" tristate "DesignWare USB3 DRD Core Support"
depends on (USB || USB_GADGET) && HAS_DMA depends on (USB || USB_GADGET) && HAS_DMA
select USB_XHCI_PLATFORM if USB_XHCI_HCD select USB_XHCI_PLATFORM if USB_XHCI_HCD
select USB_ROLE_SWITCH if USB_DWC3_DUAL_ROLE
help help
Say Y or M here if your system has a Dual Role SuperSpeed Say Y or M here if your system has a Dual Role SuperSpeed
USB controller based on the DesignWare USB3 IP Core. USB controller based on the DesignWare USB3 IP Core.
......
...@@ -114,6 +114,7 @@ static const struct property_entry dwc3_pci_intel_properties[] = { ...@@ -114,6 +114,7 @@ static const struct property_entry dwc3_pci_intel_properties[] = {
static const struct property_entry dwc3_pci_mrfld_properties[] = { static const struct property_entry dwc3_pci_mrfld_properties[] = {
PROPERTY_ENTRY_STRING("dr_mode", "otg"), PROPERTY_ENTRY_STRING("dr_mode", "otg"),
PROPERTY_ENTRY_STRING("linux,extcon-name", "mrfld_bcove_pwrsrc"),
PROPERTY_ENTRY_BOOL("linux,sysdev_is_parent"), PROPERTY_ENTRY_BOOL("linux,sysdev_is_parent"),
{} {}
}; };
......
...@@ -2483,9 +2483,6 @@ static int dwc3_gadget_ep_reclaim_trb_sg(struct dwc3_ep *dep, ...@@ -2483,9 +2483,6 @@ static int dwc3_gadget_ep_reclaim_trb_sg(struct dwc3_ep *dep,
for_each_sg(sg, s, pending, i) { for_each_sg(sg, s, pending, i) {
trb = &dep->trb_pool[dep->trb_dequeue]; trb = &dep->trb_pool[dep->trb_dequeue];
if (trb->ctrl & DWC3_TRB_CTRL_HWO)
break;
req->sg = sg_next(s); req->sg = sg_next(s);
req->num_pending_sgs--; req->num_pending_sgs--;
......
...@@ -260,6 +260,9 @@ static ssize_t gadget_dev_desc_UDC_store(struct config_item *item, ...@@ -260,6 +260,9 @@ static ssize_t gadget_dev_desc_UDC_store(struct config_item *item,
char *name; char *name;
int ret; int ret;
if (strlen(page) < len)
return -EOVERFLOW;
name = kstrdup(page, GFP_KERNEL); name = kstrdup(page, GFP_KERNEL);
if (!name) if (!name)
return -ENOMEM; return -ENOMEM;
......
...@@ -300,8 +300,10 @@ static int audio_bind(struct usb_composite_dev *cdev) ...@@ -300,8 +300,10 @@ static int audio_bind(struct usb_composite_dev *cdev)
struct usb_descriptor_header *usb_desc; struct usb_descriptor_header *usb_desc;
usb_desc = usb_otg_descriptor_alloc(cdev->gadget); usb_desc = usb_otg_descriptor_alloc(cdev->gadget);
if (!usb_desc) if (!usb_desc) {
status = -ENOMEM;
goto fail; goto fail;
}
usb_otg_descriptor_init(cdev->gadget, usb_desc); usb_otg_descriptor_init(cdev->gadget, usb_desc);
otg_desc[0] = usb_desc; otg_desc[0] = usb_desc;
otg_desc[1] = NULL; otg_desc[1] = NULL;
......
...@@ -179,8 +179,10 @@ static int cdc_bind(struct usb_composite_dev *cdev) ...@@ -179,8 +179,10 @@ static int cdc_bind(struct usb_composite_dev *cdev)
struct usb_descriptor_header *usb_desc; struct usb_descriptor_header *usb_desc;
usb_desc = usb_otg_descriptor_alloc(gadget); usb_desc = usb_otg_descriptor_alloc(gadget);
if (!usb_desc) if (!usb_desc) {
status = -ENOMEM;
goto fail1; goto fail1;
}
usb_otg_descriptor_init(gadget, usb_desc); usb_otg_descriptor_init(gadget, usb_desc);
otg_desc[0] = usb_desc; otg_desc[0] = usb_desc;
otg_desc[1] = NULL; otg_desc[1] = NULL;
......
...@@ -1361,7 +1361,6 @@ gadgetfs_setup (struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl) ...@@ -1361,7 +1361,6 @@ gadgetfs_setup (struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl)
req->buf = dev->rbuf; req->buf = dev->rbuf;
req->context = NULL; req->context = NULL;
value = -EOPNOTSUPP;
switch (ctrl->bRequest) { switch (ctrl->bRequest) {
case USB_REQ_GET_DESCRIPTOR: case USB_REQ_GET_DESCRIPTOR:
...@@ -1784,7 +1783,7 @@ static ssize_t ...@@ -1784,7 +1783,7 @@ static ssize_t
dev_config (struct file *fd, const char __user *buf, size_t len, loff_t *ptr) dev_config (struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
{ {
struct dev_data *dev = fd->private_data; struct dev_data *dev = fd->private_data;
ssize_t value = len, length = len; ssize_t value, length = len;
unsigned total; unsigned total;
u32 tag; u32 tag;
char *kbuf; char *kbuf;
......
...@@ -156,8 +156,10 @@ static int gncm_bind(struct usb_composite_dev *cdev) ...@@ -156,8 +156,10 @@ static int gncm_bind(struct usb_composite_dev *cdev)
struct usb_descriptor_header *usb_desc; struct usb_descriptor_header *usb_desc;
usb_desc = usb_otg_descriptor_alloc(gadget); usb_desc = usb_otg_descriptor_alloc(gadget);
if (!usb_desc) if (!usb_desc) {
status = -ENOMEM;
goto fail; goto fail;
}
usb_otg_descriptor_init(gadget, usb_desc); usb_otg_descriptor_init(gadget, usb_desc);
otg_desc[0] = usb_desc; otg_desc[0] = usb_desc;
otg_desc[1] = NULL; otg_desc[1] = NULL;
......
This diff is collapsed.
...@@ -185,7 +185,7 @@ static int regs_dbg_release(struct inode *inode, struct file *file) ...@@ -185,7 +185,7 @@ static int regs_dbg_release(struct inode *inode, struct file *file)
return 0; return 0;
} }
const struct file_operations queue_dbg_fops = { static const struct file_operations queue_dbg_fops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.open = queue_dbg_open, .open = queue_dbg_open,
.llseek = no_llseek, .llseek = no_llseek,
...@@ -193,7 +193,7 @@ const struct file_operations queue_dbg_fops = { ...@@ -193,7 +193,7 @@ const struct file_operations queue_dbg_fops = {
.release = queue_dbg_release, .release = queue_dbg_release,
}; };
const struct file_operations regs_dbg_fops = { static const struct file_operations regs_dbg_fops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.open = regs_dbg_open, .open = regs_dbg_open,
.llseek = generic_file_llseek, .llseek = generic_file_llseek,
......
...@@ -2647,6 +2647,8 @@ net2272_plat_probe(struct platform_device *pdev) ...@@ -2647,6 +2647,8 @@ net2272_plat_probe(struct platform_device *pdev)
err_req: err_req:
release_mem_region(base, len); release_mem_region(base, len);
err: err:
kfree(dev);
return ret; return ret;
} }
......
...@@ -3840,11 +3840,11 @@ static int __maybe_unused tegra_xudc_suspend(struct device *dev) ...@@ -3840,11 +3840,11 @@ static int __maybe_unused tegra_xudc_suspend(struct device *dev)
flush_work(&xudc->usb_role_sw_work); flush_work(&xudc->usb_role_sw_work);
/* Forcibly disconnect before powergating. */ if (!pm_runtime_status_suspended(dev)) {
tegra_xudc_device_mode_off(xudc); /* Forcibly disconnect before powergating. */
tegra_xudc_device_mode_off(xudc);
if (!pm_runtime_status_suspended(dev))
tegra_xudc_powergate(xudc); tegra_xudc_powergate(xudc);
}
pm_runtime_disable(dev); pm_runtime_disable(dev);
......
...@@ -362,6 +362,7 @@ static int xhci_plat_remove(struct platform_device *dev) ...@@ -362,6 +362,7 @@ static int xhci_plat_remove(struct platform_device *dev)
struct clk *reg_clk = xhci->reg_clk; struct clk *reg_clk = xhci->reg_clk;
struct usb_hcd *shared_hcd = xhci->shared_hcd; struct usb_hcd *shared_hcd = xhci->shared_hcd;
pm_runtime_get_sync(&dev->dev);
xhci->xhc_state |= XHCI_STATE_REMOVING; xhci->xhc_state |= XHCI_STATE_REMOVING;
usb_remove_hcd(shared_hcd); usb_remove_hcd(shared_hcd);
...@@ -375,8 +376,9 @@ static int xhci_plat_remove(struct platform_device *dev) ...@@ -375,8 +376,9 @@ static int xhci_plat_remove(struct platform_device *dev)
clk_disable_unprepare(reg_clk); clk_disable_unprepare(reg_clk);
usb_put_hcd(hcd); usb_put_hcd(hcd);
pm_runtime_set_suspended(&dev->dev);
pm_runtime_disable(&dev->dev); pm_runtime_disable(&dev->dev);
pm_runtime_put_noidle(&dev->dev);
pm_runtime_set_suspended(&dev->dev);
return 0; return 0;
} }
......
...@@ -3433,8 +3433,8 @@ int xhci_queue_bulk_tx(struct xhci_hcd *xhci, gfp_t mem_flags, ...@@ -3433,8 +3433,8 @@ int xhci_queue_bulk_tx(struct xhci_hcd *xhci, gfp_t mem_flags,
/* New sg entry */ /* New sg entry */
--num_sgs; --num_sgs;
sent_len -= block_len; sent_len -= block_len;
if (num_sgs != 0) { sg = sg_next(sg);
sg = sg_next(sg); if (num_sgs != 0 && sg) {
block_len = sg_dma_len(sg); block_len = sg_dma_len(sg);
addr = (u64) sg_dma_address(sg); addr = (u64) sg_dma_address(sg);
addr += sent_len; addr += sent_len;
......
...@@ -276,7 +276,7 @@ static const struct file_operations mtu3_ep_fops = { ...@@ -276,7 +276,7 @@ static const struct file_operations mtu3_ep_fops = {
.release = single_release, .release = single_release,
}; };
static struct debugfs_reg32 mtu3_prb_regs[] = { static const struct debugfs_reg32 mtu3_prb_regs[] = {
dump_prb_reg("enable", U3D_SSUSB_PRB_CTRL0), dump_prb_reg("enable", U3D_SSUSB_PRB_CTRL0),
dump_prb_reg("byte-sell", U3D_SSUSB_PRB_CTRL1), dump_prb_reg("byte-sell", U3D_SSUSB_PRB_CTRL1),
dump_prb_reg("byte-selh", U3D_SSUSB_PRB_CTRL2), dump_prb_reg("byte-selh", U3D_SSUSB_PRB_CTRL2),
...@@ -349,7 +349,7 @@ static const struct file_operations mtu3_probe_fops = { ...@@ -349,7 +349,7 @@ static const struct file_operations mtu3_probe_fops = {
static void mtu3_debugfs_create_prb_files(struct mtu3 *mtu) static void mtu3_debugfs_create_prb_files(struct mtu3 *mtu)
{ {
struct ssusb_mtk *ssusb = mtu->ssusb; struct ssusb_mtk *ssusb = mtu->ssusb;
struct debugfs_reg32 *regs; const struct debugfs_reg32 *regs;
struct dentry *dir_prb; struct dentry *dir_prb;
int i; int i;
......
...@@ -377,7 +377,7 @@ static int twl6030_usb_probe(struct platform_device *pdev) ...@@ -377,7 +377,7 @@ static int twl6030_usb_probe(struct platform_device *pdev)
if (status < 0) { if (status < 0) {
dev_err(&pdev->dev, "can't get IRQ %d, err %d\n", dev_err(&pdev->dev, "can't get IRQ %d, err %d\n",
twl->irq1, status); twl->irq1, status);
return status; goto err_put_regulator;
} }
status = request_threaded_irq(twl->irq2, NULL, twl6030_usb_irq, status = request_threaded_irq(twl->irq2, NULL, twl6030_usb_irq,
...@@ -386,8 +386,7 @@ static int twl6030_usb_probe(struct platform_device *pdev) ...@@ -386,8 +386,7 @@ static int twl6030_usb_probe(struct platform_device *pdev)
if (status < 0) { if (status < 0) {
dev_err(&pdev->dev, "can't get IRQ %d, err %d\n", dev_err(&pdev->dev, "can't get IRQ %d, err %d\n",
twl->irq2, status); twl->irq2, status);
free_irq(twl->irq1, twl); goto err_free_irq1;
return status;
} }
twl->asleep = 0; twl->asleep = 0;
...@@ -396,6 +395,13 @@ static int twl6030_usb_probe(struct platform_device *pdev) ...@@ -396,6 +395,13 @@ static int twl6030_usb_probe(struct platform_device *pdev)
dev_info(&pdev->dev, "Initialized TWL6030 USB module\n"); dev_info(&pdev->dev, "Initialized TWL6030 USB module\n");
return 0; return 0;
err_free_irq1:
free_irq(twl->irq1, twl);
err_put_regulator:
regulator_put(twl->usb3v3);
return status;
} }
static int twl6030_usb_remove(struct platform_device *pdev) static int twl6030_usb_remove(struct platform_device *pdev)
......
...@@ -63,6 +63,7 @@ enum { ...@@ -63,6 +63,7 @@ enum {
#define PMC_USB_ALTMODE_DP_MODE_SHIFT 8 #define PMC_USB_ALTMODE_DP_MODE_SHIFT 8
/* TBT specific Mode Data bits */ /* TBT specific Mode Data bits */
#define PMC_USB_ALTMODE_HPD_HIGH BIT(14)
#define PMC_USB_ALTMODE_TBT_TYPE BIT(17) #define PMC_USB_ALTMODE_TBT_TYPE BIT(17)
#define PMC_USB_ALTMODE_CABLE_TYPE BIT(18) #define PMC_USB_ALTMODE_CABLE_TYPE BIT(18)
#define PMC_USB_ALTMODE_ACTIVE_LINK BIT(20) #define PMC_USB_ALTMODE_ACTIVE_LINK BIT(20)
...@@ -74,8 +75,8 @@ enum { ...@@ -74,8 +75,8 @@ enum {
#define PMC_USB_ALTMODE_TBT_GEN(_g_) (((_g_) & GENMASK(1, 0)) << 28) #define PMC_USB_ALTMODE_TBT_GEN(_g_) (((_g_) & GENMASK(1, 0)) << 28)
/* Display HPD Request bits */ /* Display HPD Request bits */
#define PMC_USB_DP_HPD_LVL BIT(4)
#define PMC_USB_DP_HPD_IRQ BIT(5) #define PMC_USB_DP_HPD_IRQ BIT(5)
#define PMC_USB_DP_HPD_LVL BIT(6)
struct pmc_usb; struct pmc_usb;
...@@ -158,8 +159,7 @@ pmc_usb_mux_dp(struct pmc_usb_port *port, struct typec_mux_state *state) ...@@ -158,8 +159,7 @@ pmc_usb_mux_dp(struct pmc_usb_port *port, struct typec_mux_state *state)
PMC_USB_ALTMODE_DP_MODE_SHIFT; PMC_USB_ALTMODE_DP_MODE_SHIFT;
if (data->status & DP_STATUS_HPD_STATE) if (data->status & DP_STATUS_HPD_STATE)
req.mode_data |= PMC_USB_DP_HPD_LVL << req.mode_data |= PMC_USB_ALTMODE_HPD_HIGH;
PMC_USB_ALTMODE_DP_MODE_SHIFT;
return pmc_usb_command(port, (void *)&req, sizeof(req)); return pmc_usb_command(port, (void *)&req, sizeof(req));
} }
......
...@@ -93,6 +93,64 @@ struct usb_raw_ep_io { ...@@ -93,6 +93,64 @@ struct usb_raw_ep_io {
__u8 data[0]; __u8 data[0];
}; };
/* Maximum number of non-control endpoints in struct usb_raw_eps_info. */
#define USB_RAW_EPS_NUM_MAX 30
/* Maximum length of UDC endpoint name in struct usb_raw_ep_info. */
#define USB_RAW_EP_NAME_MAX 16
/* Used as addr in struct usb_raw_ep_info if endpoint accepts any address. */
#define USB_RAW_EP_ADDR_ANY 0xff
/*
* struct usb_raw_ep_caps - exposes endpoint capabilities from struct usb_ep
* (technically from its member struct usb_ep_caps).
*/
struct usb_raw_ep_caps {
__u32 type_control : 1;
__u32 type_iso : 1;
__u32 type_bulk : 1;
__u32 type_int : 1;
__u32 dir_in : 1;
__u32 dir_out : 1;
};
/*
* struct usb_raw_ep_limits - exposes endpoint limits from struct usb_ep.
* @maxpacket_limit: Maximum packet size value supported by this endpoint.
* @max_streams: maximum number of streams supported by this endpoint
* (actual number is 2^n).
* @reserved: Empty, reserved for potential future extensions.
*/
struct usb_raw_ep_limits {
__u16 maxpacket_limit;
__u16 max_streams;
__u32 reserved;
};
/*
* struct usb_raw_ep_info - stores information about a gadget endpoint.
* @name: Name of the endpoint as it is defined in the UDC driver.
* @addr: Address of the endpoint that must be specified in the endpoint
* descriptor passed to USB_RAW_IOCTL_EP_ENABLE ioctl.
* @caps: Endpoint capabilities.
* @limits: Endpoint limits.
*/
struct usb_raw_ep_info {
__u8 name[USB_RAW_EP_NAME_MAX];
__u32 addr;
struct usb_raw_ep_caps caps;
struct usb_raw_ep_limits limits;
};
/*
* struct usb_raw_eps_info - argument for USB_RAW_IOCTL_EPS_INFO ioctl.
* eps: Structures that store information about non-control endpoints.
*/
struct usb_raw_eps_info {
struct usb_raw_ep_info eps[USB_RAW_EPS_NUM_MAX];
};
/* /*
* Initializes a Raw Gadget instance. * Initializes a Raw Gadget instance.
* Accepts a pointer to the usb_raw_init struct as an argument. * Accepts a pointer to the usb_raw_init struct as an argument.
...@@ -115,37 +173,38 @@ struct usb_raw_ep_io { ...@@ -115,37 +173,38 @@ struct usb_raw_ep_io {
#define USB_RAW_IOCTL_EVENT_FETCH _IOR('U', 2, struct usb_raw_event) #define USB_RAW_IOCTL_EVENT_FETCH _IOR('U', 2, struct usb_raw_event)
/* /*
* Queues an IN (OUT for READ) urb as a response to the last control request * Queues an IN (OUT for READ) request as a response to the last setup request
* received on endpoint 0, provided that was an IN (OUT for READ) request and * received on endpoint 0 (provided that was an IN (OUT for READ) request), and
* waits until the urb is completed. Copies received data to user for READ. * waits until the request is completed. Copies received data to user for READ.
* Accepts a pointer to the usb_raw_ep_io struct as an argument. * Accepts a pointer to the usb_raw_ep_io struct as an argument.
* Returns length of trasferred data on success or negative error code on * Returns length of transferred data on success or negative error code on
* failure. * failure.
*/ */
#define USB_RAW_IOCTL_EP0_WRITE _IOW('U', 3, struct usb_raw_ep_io) #define USB_RAW_IOCTL_EP0_WRITE _IOW('U', 3, struct usb_raw_ep_io)
#define USB_RAW_IOCTL_EP0_READ _IOWR('U', 4, struct usb_raw_ep_io) #define USB_RAW_IOCTL_EP0_READ _IOWR('U', 4, struct usb_raw_ep_io)
/* /*
* Finds an endpoint that supports the transfer type specified in the * Finds an endpoint that satisfies the parameters specified in the provided
* descriptor and enables it. * descriptors (address, transfer type, etc.) and enables it.
* Accepts a pointer to the usb_endpoint_descriptor struct as an argument. * Accepts a pointer to the usb_raw_ep_descs struct as an argument.
* Returns enabled endpoint handle on success or negative error code on failure. * Returns enabled endpoint handle on success or negative error code on failure.
*/ */
#define USB_RAW_IOCTL_EP_ENABLE _IOW('U', 5, struct usb_endpoint_descriptor) #define USB_RAW_IOCTL_EP_ENABLE _IOW('U', 5, struct usb_endpoint_descriptor)
/* Disables specified endpoint. /*
* Disables specified endpoint.
* Accepts endpoint handle as an argument. * Accepts endpoint handle as an argument.
* Returns 0 on success or negative error code on failure. * Returns 0 on success or negative error code on failure.
*/ */
#define USB_RAW_IOCTL_EP_DISABLE _IOW('U', 6, __u32) #define USB_RAW_IOCTL_EP_DISABLE _IOW('U', 6, __u32)
/* /*
* Queues an IN (OUT for READ) urb as a response to the last control request * Queues an IN (OUT for READ) request as a response to the last setup request
* received on endpoint usb_raw_ep_io.ep, provided that was an IN (OUT for READ) * received on endpoint usb_raw_ep_io.ep (provided that was an IN (OUT for READ)
* request and waits until the urb is completed. Copies received data to user * request), and waits until the request is completed. Copies received data to
* for READ. * user for READ.
* Accepts a pointer to the usb_raw_ep_io struct as an argument. * Accepts a pointer to the usb_raw_ep_io struct as an argument.
* Returns length of trasferred data on success or negative error code on * Returns length of transferred data on success or negative error code on
* failure. * failure.
*/ */
#define USB_RAW_IOCTL_EP_WRITE _IOW('U', 7, struct usb_raw_ep_io) #define USB_RAW_IOCTL_EP_WRITE _IOW('U', 7, struct usb_raw_ep_io)
...@@ -164,4 +223,27 @@ struct usb_raw_ep_io { ...@@ -164,4 +223,27 @@ struct usb_raw_ep_io {
*/ */
#define USB_RAW_IOCTL_VBUS_DRAW _IOW('U', 10, __u32) #define USB_RAW_IOCTL_VBUS_DRAW _IOW('U', 10, __u32)
/*
* Fills in the usb_raw_eps_info structure with information about non-control
* endpoints available for the currently connected UDC.
* Returns the number of available endpoints on success or negative error code
* on failure.
*/
#define USB_RAW_IOCTL_EPS_INFO _IOR('U', 11, struct usb_raw_eps_info)
/*
* Stalls a pending control request on endpoint 0.
* Returns 0 on success or negative error code on failure.
*/
#define USB_RAW_IOCTL_EP0_STALL _IO('U', 12)
/*
* Sets or clears halt or wedge status of the endpoint.
* Accepts endpoint handle as an argument.
* Returns 0 on success or negative error code on failure.
*/
#define USB_RAW_IOCTL_EP_SET_HALT _IOW('U', 13, __u32)
#define USB_RAW_IOCTL_EP_CLEAR_HALT _IOW('U', 14, __u32)
#define USB_RAW_IOCTL_EP_SET_WEDGE _IOW('U', 15, __u32)
#endif /* _UAPI__LINUX_USB_RAW_GADGET_H */ #endif /* _UAPI__LINUX_USB_RAW_GADGET_H */
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment