Commit fb7df5e4 authored by Mat Martineau's avatar Mat Martineau Committed by David S. Miller

tcp: md5: Handle RCU dereference of md5sig_info

Dereference tp->md5sig_info in tcp_v4_destroy_sock() the same way it is
done in the adjacent call to tcp_clear_md5_list().

Resolves this sparse warning:

net/ipv4/tcp_ipv4.c:1914:17: warning: incorrect type in argument 1 (different address spaces)
net/ipv4/tcp_ipv4.c:1914:17:    expected struct callback_head *head
net/ipv4/tcp_ipv4.c:1914:17:    got struct callback_head [noderef] <asn:4>*<noident>
Signed-off-by: default avatarMat Martineau <mathew.j.martineau@linux.intel.com>
Acked-by: default avatarChristoph Paasch <cpaasch@apple.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 595476cb
...@@ -1911,7 +1911,7 @@ void tcp_v4_destroy_sock(struct sock *sk) ...@@ -1911,7 +1911,7 @@ void tcp_v4_destroy_sock(struct sock *sk)
/* Clean up the MD5 key list, if any */ /* Clean up the MD5 key list, if any */
if (tp->md5sig_info) { if (tp->md5sig_info) {
tcp_clear_md5_list(sk); tcp_clear_md5_list(sk);
kfree_rcu(tp->md5sig_info, rcu); kfree_rcu(rcu_dereference_protected(tp->md5sig_info, 1), rcu);
tp->md5sig_info = NULL; tp->md5sig_info = NULL;
} }
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment