Commit fbed24bc authored by Josef Bacik's avatar Josef Bacik Committed by David S. Miller

inet: fix improper empty comparison

When doing my reuseport rework I screwed up and changed a

if (hlist_empty(&tb->owners))

to

if (!hlist_empty(&tb->owners))

This is obviously bad as all of the reuseport/reuse logic was reversed,
which caused weird problems like allowing an ipv4 bind conflict if we
opened an ipv4 only socket on a port followed by an ipv6 only socket on
the same port.

Fixes: b9470c27 ("inet: kill smallest_size and smallest_port")
Reported-by: default avatarCole Robinson <crobinso@redhat.com>
Signed-off-by: default avatarJosef Bacik <jbacik@fb.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7a56673b
...@@ -321,7 +321,7 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum) ...@@ -321,7 +321,7 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum)
goto fail_unlock; goto fail_unlock;
} }
success: success:
if (!hlist_empty(&tb->owners)) { if (hlist_empty(&tb->owners)) {
tb->fastreuse = reuse; tb->fastreuse = reuse;
if (sk->sk_reuseport) { if (sk->sk_reuseport) {
tb->fastreuseport = FASTREUSEPORT_ANY; tb->fastreuseport = FASTREUSEPORT_ANY;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment