Commit fbf4987a authored by Cristian Birsan's avatar Cristian Birsan Committed by Felipe Balbi

usb: gadget: udc: atmel: Minor code cleanup

Minor code cleanup based on feedback received on mailinglist.
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: default avatarCristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 3b68e7ca
...@@ -321,7 +321,6 @@ static inline void usba_cleanup_debugfs(struct usba_udc *udc) ...@@ -321,7 +321,6 @@ static inline void usba_cleanup_debugfs(struct usba_udc *udc)
static ushort fifo_mode; static ushort fifo_mode;
/* "modprobe ... fifo_mode=1" etc */
module_param(fifo_mode, ushort, 0x0); module_param(fifo_mode, ushort, 0x0);
MODULE_PARM_DESC(fifo_mode, "Endpoint configuration mode"); MODULE_PARM_DESC(fifo_mode, "Endpoint configuration mode");
...@@ -371,7 +370,7 @@ static struct usba_fifo_cfg mode_4_cfg[] = { ...@@ -371,7 +370,7 @@ static struct usba_fifo_cfg mode_4_cfg[] = {
}; };
/* Add additional configurations here */ /* Add additional configurations here */
int usba_config_fifo_table(struct usba_udc *udc) static int usba_config_fifo_table(struct usba_udc *udc)
{ {
int n; int n;
...@@ -1076,11 +1075,9 @@ static int atmel_usba_start(struct usb_gadget *gadget, ...@@ -1076,11 +1075,9 @@ static int atmel_usba_start(struct usb_gadget *gadget,
struct usb_gadget_driver *driver); struct usb_gadget_driver *driver);
static int atmel_usba_stop(struct usb_gadget *gadget); static int atmel_usba_stop(struct usb_gadget *gadget);
static struct usb_ep *atmel_usba_match_ep( static struct usb_ep *atmel_usba_match_ep(struct usb_gadget *gadget,
struct usb_gadget *gadget, struct usb_endpoint_descriptor *desc,
struct usb_endpoint_descriptor *desc, struct usb_ss_ep_comp_descriptor *ep_comp)
struct usb_ss_ep_comp_descriptor *ep_comp
)
{ {
struct usb_ep *_ep; struct usb_ep *_ep;
struct usba_ep *ep; struct usba_ep *ep;
...@@ -1100,7 +1097,6 @@ static struct usb_ep *atmel_usba_match_ep( ...@@ -1100,7 +1097,6 @@ static struct usb_ep *atmel_usba_match_ep(
ep = to_usba_ep(_ep); ep = to_usba_ep(_ep);
switch (usb_endpoint_type(desc)) { switch (usb_endpoint_type(desc)) {
case USB_ENDPOINT_XFER_CONTROL: case USB_ENDPOINT_XFER_CONTROL:
break; break;
...@@ -1141,7 +1137,7 @@ static struct usb_ep *atmel_usba_match_ep( ...@@ -1141,7 +1137,7 @@ static struct usb_ep *atmel_usba_match_ep(
ep->udc->configured_ep++; ep->udc->configured_ep++;
} }
return _ep; return _ep;
} }
static const struct usb_gadget_ops usba_udc_ops = { static const struct usb_gadget_ops usba_udc_ops = {
...@@ -2089,8 +2085,9 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, ...@@ -2089,8 +2085,9 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
while ((pp = of_get_next_child(np, pp))) while ((pp = of_get_next_child(np, pp)))
udc->num_ep++; udc->num_ep++;
udc->configured_ep = 1; udc->configured_ep = 1;
} else } else {
udc->num_ep = usba_config_fifo_table(udc); udc->num_ep = usba_config_fifo_table(udc);
}
eps = devm_kzalloc(&pdev->dev, sizeof(struct usba_ep) * udc->num_ep, eps = devm_kzalloc(&pdev->dev, sizeof(struct usba_ep) * udc->num_ep,
GFP_KERNEL); GFP_KERNEL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment