Commit fc5b220b authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen

scsi: target: cxgbit: Fix cxgbit_fw4_ack()

Use the pointer 'p' after having tested that pointer instead of before.

Fixes: 5cadafb2 ("target/cxgbit: Fix endianness annotations")
Cc: Varun Prakash <varun@chelsio.com>
Cc: Nicholas Bellinger <nab@linux-iscsi.org>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20191023202150.22173-1-bvanassche@acm.orgReported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 8d8b83f5
...@@ -1829,7 +1829,7 @@ static void cxgbit_fw4_ack(struct cxgbit_sock *csk, struct sk_buff *skb) ...@@ -1829,7 +1829,7 @@ static void cxgbit_fw4_ack(struct cxgbit_sock *csk, struct sk_buff *skb)
while (credits) { while (credits) {
struct sk_buff *p = cxgbit_sock_peek_wr(csk); struct sk_buff *p = cxgbit_sock_peek_wr(csk);
const u32 csum = (__force u32)p->csum; u32 csum;
if (unlikely(!p)) { if (unlikely(!p)) {
pr_err("csk 0x%p,%u, cr %u,%u+%u, empty.\n", pr_err("csk 0x%p,%u, cr %u,%u+%u, empty.\n",
...@@ -1838,6 +1838,7 @@ static void cxgbit_fw4_ack(struct cxgbit_sock *csk, struct sk_buff *skb) ...@@ -1838,6 +1838,7 @@ static void cxgbit_fw4_ack(struct cxgbit_sock *csk, struct sk_buff *skb)
break; break;
} }
csum = (__force u32)p->csum;
if (unlikely(credits < csum)) { if (unlikely(credits < csum)) {
pr_warn("csk 0x%p,%u, cr %u,%u+%u, < %u.\n", pr_warn("csk 0x%p,%u, cr %u,%u+%u, < %u.\n",
csk, csk->tid, csk, csk->tid,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment