Commit ff29530e authored by Alex Williamson's avatar Alex Williamson Committed by Jesse Barnes

PCI: sysfs: Update ROM to include default owner write access

The PCI sysfs ROM interface requires an enabling write to access the ROM
image, but the default file mode is 0400.  The original proposed patch
adding sysfs ROM support was a true read-only interface, with the
enabling bit coming in as a feature request.  I suspect it was simply an
oversight that the file mode didn't get updated to match the API.
Acked-by: default avatarChris Wright <chrisw@redhat.com>
Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
parent 64a5fed6
...@@ -1149,7 +1149,7 @@ int __must_check pci_create_sysfs_dev_files (struct pci_dev *pdev) ...@@ -1149,7 +1149,7 @@ int __must_check pci_create_sysfs_dev_files (struct pci_dev *pdev)
sysfs_bin_attr_init(attr); sysfs_bin_attr_init(attr);
attr->size = rom_size; attr->size = rom_size;
attr->attr.name = "rom"; attr->attr.name = "rom";
attr->attr.mode = S_IRUSR; attr->attr.mode = S_IRUSR | S_IWUSR;
attr->read = pci_read_rom; attr->read = pci_read_rom;
attr->write = pci_write_rom; attr->write = pci_write_rom;
retval = sysfs_create_bin_file(&pdev->dev.kobj, attr); retval = sysfs_create_bin_file(&pdev->dev.kobj, attr);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment