Commit ff603e01 authored by Gregory CLEMENT's avatar Gregory CLEMENT Committed by Greg Kroah-Hartman

ARM: dts: armada-38x: Fix irq type for pca955

commit 8d451417 upstream.

As written in the datasheet the PCA955 can only handle low level irq and
not edge irq.

Without this fix the interrupt is not usable for pca955: the gpio-pca953x
driver already set the irq type as low level which is incompatible with
edge type, then the kernel prevents using the interrupt:

"irq: type mismatch, failed to map hwirq-18 for
/soc/internal-regs/gpio@18100!"

Fixes: 928413bd ("ARM: mvebu: Add Armada 388 General Purpose
Development Board support")
Signed-off-by: default avatarGregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 12353a00
...@@ -75,7 +75,7 @@ expander0: pca9555@20 { ...@@ -75,7 +75,7 @@ expander0: pca9555@20 {
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&pca0_pins>; pinctrl-0 = <&pca0_pins>;
interrupt-parent = <&gpio0>; interrupt-parent = <&gpio0>;
interrupts = <18 IRQ_TYPE_EDGE_FALLING>; interrupts = <18 IRQ_TYPE_LEVEL_LOW>;
gpio-controller; gpio-controller;
#gpio-cells = <2>; #gpio-cells = <2>;
interrupt-controller; interrupt-controller;
...@@ -87,7 +87,7 @@ expander1: pca9555@21 { ...@@ -87,7 +87,7 @@ expander1: pca9555@21 {
compatible = "nxp,pca9555"; compatible = "nxp,pca9555";
pinctrl-names = "default"; pinctrl-names = "default";
interrupt-parent = <&gpio0>; interrupt-parent = <&gpio0>;
interrupts = <18 IRQ_TYPE_EDGE_FALLING>; interrupts = <18 IRQ_TYPE_LEVEL_LOW>;
gpio-controller; gpio-controller;
#gpio-cells = <2>; #gpio-cells = <2>;
interrupt-controller; interrupt-controller;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment