- 08 Mar, 2012 19 commits
-
-
Stanislaw Gruszka authored
That change will save us some CPU cycles at run time. Having port-based I/O seems to be not possible for PCIe devices. Signed-off-by:
Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by:
Johannes Berg <johannes.berg@intel.com> Signed-off-by:
Wey-Yi Guy <wey-yi.w.guy@intel.com> Signed-off-by:
John W. Linville <linville@tuxdriver.com>
-
Stanislaw Gruszka authored
wmb(), rmb() are not needed when writel(), readl() are used as accessors for MMIO. We use them indirectly via iowrite32(), ioread32(). What is needed mmiowb(), for synchronizing writes coming from different CPUs on PCIe bridge (see in patch comments). This fortunately is not needed on x86, where mmiowb() is just defined as compiler barrier. As iwlwifi devices are most likely not used on anything other than x86, this is not so important fix. Signed-off-by:
-
Stanislaw Gruszka authored
Before we write to the device registers always check if iwl_grap_nic_access() was successful. On the way change return type of grab_nic_access() to bool, and add likely()/unlikely() statement. Signed-off-by:
-
Stanislaw Gruszka authored
Print dump stack when the device is not responding. This should give some more clue about the reason of failure. Also change the message we print, since "MAC in deep sleep" is kinda confusing. On the way add unlikely(), as fail to gain NIC access is hmm ... unlikely. Signed-off-by:
-
Johannes Berg authored
In "iwlwifi: consolidate the start_device flow" the code flow changed and the firmware is now loaded by the transport layer, but the change unfortunately lost error checking -- restore. Signed-off-by:
-
Johannes Berg authored
The sensitivity parameters are never modified, so they should be const. Also remove the unused max_nrg_cck value to save some space. Signed-off-by:
-
Johannes Berg authored
There's no need to carry around the function pointer when a boolean indicating that the EEPROM stores enhanced TX power information is sufficient. Signed-off-by:
-
Johannes Berg authored
Hardware parameters will be shared, so move the definitions into the shared header file. Signed-off-by:
-
Johannes Berg authored
There's no need to have operations for these as they simply depend on whether the device has built-in bluetooth, so just duplicate the information already there (whether bt_params is present or not). Signed-off-by:
-
Johannes Berg authored
At least as long as it is called from the reclaim flow (iwlagn_check_ratid_empty) it must be atomic. Signed-off-by:
-
Johannes Berg authored
The PASSIVE_NO_RX workaround currently crosses through the op_mode and transport layers, which is a bit odd. This also isn't necessary, if the transport simply reports when queues are full (or no longer full) the op_mode can keep track of this state, and report to mac80211 only what *it* thinks is appropriate. What is appropriate can then be based on whether queues should be stopped to wait for RX or not. This significantly simplifies the transport API, it no longer needs to expose anything to stop a queue, nor to wake "any" queue, this can all be handled in the upper layer completely. Also simplify the handling to not be dependent on the context, that makes little sense as the queues are shared and both contexts have to be on the same channel anyway. Signed-off-by:
-
Johannes Berg authored
There's not much point in passing priv and hw pointers since they can be derived from each other, and the function doesn't use the hw pointer anyway. Remove it. Signed-off-by:
-
Johannes Berg authored
The dump functions never access the incoming attributes, so don't pass them. Signed-off-by:
-
Johannes Berg authored
The function never uses the priv argument as it only fills in the passed data, so remove the argument. Signed-off-by:
-
Johannes Berg authored
There's only one user, so the function can be moved into the correct file. It also loses an argument along the way. Signed-off-by:
-
Johannes Berg authored
The function never uses its conf argument, so remove it. Signed-off-by:
-
Johannes Berg authored
The function has two arguments it never uses, remove them. Signed-off-by:
-
Luciano Coelho authored
-
Arik Nemtsov authored
Track freed FW blocks during Tx. If no blocks were freed during a predefined timeout, initiate a HW recovery. This helps in situations when the FW watchdog fails. Don't trigger recovery during activities that can temporarily stop Tx. This includes: - scanning - buffering packets for sleeping stations (AP role) - ROC on any role Signed-off-by:
Arik Nemtsov <arik@wizery.com> Signed-off-by:
Eliad Peller <eliad@wizery.com> Signed-off-by:
Luciano Coelho <coelho@ti.com>
-
- 07 Mar, 2012 21 commits
-
-
Attila Fazekas authored
Add AD-HOC support to the rtl8187 based on the rtl8180 source Signed-off-by:
Attila Fazekas <turul64@gmail.com> Acked-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Rafał Miłecki authored
Signed-off-by:
Rafał Miłecki <zajec5@gmail.com> Signed-off-by:
-
Thomas Pedersen authored
smatch was complaining: CHECK net/mac80211/mesh_pathtbl.c net/mac80211/mesh_pathtbl.c:562 mesh_path_add() error: double lock 'bottom_half:' net/mac80211/mesh_pathtbl.c:580 mesh_path_add() error: double unlock 'bottom_half:' net/mac80211/mesh_pathtbl.c:589 mesh_path_add() error: double unlock 'bottom_half:' net/mac80211/mesh_pathtbl.c:691 mpp_path_add() error: double lock 'bottom_half:' net/mac80211/mesh_pathtbl.c:707 mpp_path_add() error: double unlock 'bottom_half:' net/mac80211/mesh_pathtbl.c:716 mpp_path_add() error: double unlock 'bottom_half:' net/mac80211/mesh_pathtbl.c:814 mesh_path_flush_by_nexthop() error: double lock 'bottom_half:' net/mac80211/mesh_pathtbl.c:819 mesh_path_flush_by_nexthop() error: double unlock 'bottom_half:' net/mac80211/mesh_pathtbl.c:887 mesh_path_del() error: double lock 'bottom_half:' net/mac80211/mesh_pathtbl.c:901 mesh_path_del() error: double unlock 'bottom_half:' So don't lock / unlock with _bh() while bottom halves are already disabled. Reported-by:
Johannes Berg <johannes@sipsolutions.net> Signed-off-by:
Thomas Pedersen <thomas@cozybit.com> Signed-off-by:
-
Johannes Berg authored
This function is only used in iwl-scan.c, so if we move it up a little in the file it can be made static. Signed-off-by:
-
Johannes Berg authored
Do some cleanups here: * remove an unused prototype * remove some unused constants * clean up includes Signed-off-by:
-
Johannes Berg authored
It's only needed in a few places. Signed-off-by:
-
Johannes Berg authored
No need to have a special config variable for the PA type, we can just use the additional NIC config function to config the hardware correctly. Signed-off-by:
-
Johannes Berg authored
Finally nothing needs to access priv from shared any more, so remove it. Signed-off-by:
-
Johannes Berg authored
The nic_config sets uCode dependent register bits, so it must be virtual in the op_mode. Signed-off-by:
-
Johannes Berg authored
The base packet structure will (hopefully) be the same for all transports, but what is in it differs. Remove the union of all the possible contents and move the packet itself into the transport header file. This requires changing all users of the union to just use pkt->data. Signed-off-by:
-
Johannes Berg authored
Even if the variable might also be used by other transports, there's no need for anything outside of the transport itself to access it, so move it into the private area. Signed-off-by:
-
Johannes Berg authored
All variables related to uCode loading (the waitqueue and done indication) should be in the PCI-E transport's private data as this is transport specific. Move them there. Signed-off-by:
-
Johannes Berg authored
The transport doesn't really need to know as we can enforce it in the command wrapper. Move the ucode_owner variable into priv and do all enforcing there. Signed-off-by:
-
Johannes Berg authored
This will be sharable, but needs to live in the op_mode as it is dependent on command processing. Make a library out of the notification wait code. Since I wrote all of the code originally and only Intel employees changed it, we can also relicense it to dual BSD/GPL. Signed-off-by:
-
Johannes Berg authored
In "iwlwifi: consolidate the start_device flow" Emmanuel added the return if the fw isn't there but forgot to take into account that the struct for notification wait needs to be added only after the check -- fix that. Signed-off-by:
-
Johannes Berg authored
The HW configuration settings base_params, ht_params and bt_params all should be const, make it so. Signed-off-by:
-
Johannes Berg authored
The hardware config ht_params shouldn't be modified, so copy the use_rts_for_aggregation parameter into hw_params and use/modify it there. Signed-off-by:
-
Johannes Berg authored
This is the version that can be modified, the config params should be read-only. Signed-off-by:
-
Johannes Berg authored
The base_params shouldn't be writable, so keep a copy of this in priv that can be modified. Signed-off-by:
-
Johannes Berg authored
This can be used directly from the config now. Signed-off-by:
-
Johannes Berg authored
This is a hardware parameter, so it shouldn't be configurable by the user. Users can disable aggregation (which is the only thing affected) with 11n_disable. Signed-off-by:
-
