1. 22 Mar, 2018 30 commits
  2. 21 Mar, 2018 10 commits
    • Mauro Carvalho Chehab's avatar
      media: v4l2-common: fix a compilation breakage · 238f694e
      Mauro Carvalho Chehab authored
      Clearly, changeset 95ce9c28 ("media: v4l: common: Add a
      function to obtain best size from a list") was never tested, as it
      broke compilation with:
      
      drivers/media/platform/vivid/vivid-vid-cap.c: In function ‘vivid_try_fmt_vid_cap’:
      drivers/media/platform/vivid/vivid-vid-cap.c:565:34: error: macro "v4l2_find_nearest_size" requer 6 argumentos, mas apenas 5 foram fornecidos
                   mp->width, mp->height);
                                        ^
      drivers/media/platform/vivid/vivid-vid-cap.c:564:4: error: ‘v4l2_find_nearest_size’ undeclared (first use in this function); did you mean ‘__v4l2_find_nearest_size’?
          v4l2_find_nearest_size(webcam_sizes, width, height,
          ^~~~~~~~~~~~~~~~~~~~~~
          __v4l2_find_nearest_size
      drivers/media/platform/vivid/vivid-vid-cap.c:564:4: note: each undeclared identifier is reported only once for each function it appears in
      drivers/media/i2c/ov5670.c: In function ‘ov5670_set_pad_format’:
      drivers/media/i2c/ov5670.c:2233:48: error: macro "v4l2_find_nearest_size" requer 6 argumentos, mas apenas 5 foram fornecidos
                 fmt->format.width, fmt->format.height);
                                                      ^
      drivers/media/i2c/ov5670.c:2232:9: error: ‘v4l2_find_nearest_size’ undeclared (first use in this function); did you mean ‘__v4l2_find_nearest_size’?
        mode = v4l2_find_nearest_size(supported_modes, width, height,
               ^~~~~~~~~~~~~~~~~~~~~~
               __v4l2_find_nearest_size
      drivers/media/i2c/ov13858.c: In function ‘ov13858_set_pad_format’:
      drivers/media/i2c/ov13858.c:1379:48: error: macro "v4l2_find_nearest_size" requer 6 argumentos, mas apenas 5 foram fornecidos
                 fmt->format.width, fmt->format.height);
                                                      ^
      drivers/media/i2c/ov13858.c:1378:9: error: ‘v4l2_find_nearest_size’ undeclared (first use in this function); did you mean ‘__v4l2_find_nearest_size’?
        mode = v4l2_find_nearest_size(supported_modes, width, height,
               ^~~~~~~~~~~~~~~~~~~~~~
               __v4l2_find_nearest_size
      drivers/media/i2c/ov13858.c:1378:9: note: each undeclared identifier is reported only once for each function it appears in
      
      Basically, v4l2_find_nearest_size() callers pass 5 arguments,
      while its definition require 6 args.
      
      Unfortunately, my build process was also broken, as it was reporting me that
      the compilation went fine:
      
      	$ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y C=1 W=1 CHECK='compile_checks' M=drivers/staging/media
      	$ make ARCH=i386  CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y C=1 W=1 CHECK='compile_checks' M=drivers/media
      
      	*** ERRORS ***
      
      	*** WARNINGS ***
      	compilation succeeded
      
      That was due to a change here to use of linux-log-diff script that
      provides a diffstat between the errors output. Somehow, the logic
      was missing some fatal errors.
      
      Fixes: 95ce9c28 ("media: v4l: common: Add a function to obtain best size from a list")
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      238f694e
    • Arushi Singhal's avatar
      media: staging: media: Replace "cant" with "can't" · 35c6ef89
      Arushi Singhal authored
      Replace "cant" with "can't".
      "cant" is not same as "Can not" or "Can't".
      Signed-off-by: default avatarArushi Singhal <arushisinghal19971997@gmail.com>
      Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      35c6ef89
    • Hans Verkuil's avatar
      media: atomisp_fops.c: disable atomisp_compat_ioctl32 · 57e6b6f2
      Hans Verkuil authored
      The atomisp_compat_ioctl32() code has problems. This patch disables the
      compat_ioctl32 support until those issues have been fixed.
      
      Contact Sakari or me for more details.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Cc: <stable@vger.kernel.org>      # for v4.12 and up
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      57e6b6f2
    • Corentin Labbe's avatar
      media: staging: media: atomisp: Remove inclusion of non-existing directories · 06ed2a6d
      Corentin Labbe authored
      This patch fix the following build warnings:
        CC [M]  drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.o
      cc1: warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/bayer_ls/bayer_ls_1.0/: No such file or directory [-Wmissing-include-dirs]
      cc1: warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/io_ls/plane_io_ls/: No such file or directory [-Wmissing-include-dirs]
      cc1: warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/io_ls/yuv420_io_ls/: No such file or directory [-Wmissing-include-dirs]
      cc1: warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/ipu2_io_ls/plane_io_ls/: No such file or directory [-Wmissing-include-dirs]
      cc1: warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/ipu2_io_ls/yuv420_io_ls/: No such file or directory [-Wmissing-include-dirs]
      cc1: warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/s3a_stat_ls/: No such file or directory [-Wmissing-include-dirs]
      cc1: warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/scale/: No such file or directory [-Wmissing-include-dirs]
      cc1: warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/scale/scale_1.0/: No such file or directory [-Wmissing-include-dirs]
      cc1: warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/yuv_ls: No such file or directory [-Wmissing-include-dirs]
      cc1: warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/yuv_ls/yuv_ls_1.0/: No such file or directory [-Wmissing-include-dirs]
      by removing the inclusion of such directories
      Signed-off-by: default avatarCorentin Labbe <clabbe@baylibre.com>
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      06ed2a6d
    • Jeremy Sowden's avatar
      media: atomisp: convert default struct values to use compound-literals with designated initializers · 6dc9a256
      Jeremy Sowden authored
      The CSS API uses a lot of nested anonymous structs defined in object
      macros to assign default values to its data-structures.  These have been
      changed to use compound-literals and designated initializers to make
      them more comprehensible and less fragile.
      
      The compound-literals can also be used in assignment, which means we can
      get rid of some temporary variables whose only purpose is to be
      initialized by one of these anonymous structs and then serve as the
      rvalue in an assignment expression.
      
      A lot of the members of the default struct values used by the CSS API
      were explicitly initialized to zero values.  Designated initializers
      have allowed these members, and in some case whole default struct
      values, to be removed.
      Signed-off-by: default avatarJeremy Sowden <jeremy@azazel.net>
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      6dc9a256
    • Corentin Labbe's avatar
      media: staging: media: atomisp2: remove unused headers · d82a4a14
      Corentin Labbe authored
      All thoses headers are not used by any source files.
      Lets just remove them.
      Signed-off-by: default avatarCorentin Labbe <clabbe@baylibre.com>
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      d82a4a14
    • Corentin Labbe's avatar
      media: staging: media: remove remains of VIDEO_ATOMISP_OV8858 · 01b61059
      Corentin Labbe authored
      OV8858 files are left unusable since commit 3a81c766 ("media: staging: atomisp: Remove IMX sensor support")
      They are uncompilable since they depends on dw9718.c and vcm.c which was removed.
      
      Remove the OV8858 kconfig and files.
      Signed-off-by: default avatarCorentin Labbe <clabbe@baylibre.com>
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      01b61059
    • Colin Ian King's avatar
      media: staging: atomisp: remove redundant assignments to various variables · b0e84815
      Colin Ian King authored
      There are various assignments that are being made to variables that are
      not read and the variables are being updated later on, hence the redundant
      assignments can be removed.
      
      Cleans up clang warnings:
      drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c:1950:8:
      warning: Value stored to 'pdata' during its initialization is never read
      drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c:1853:29:
      warning: Value stored to 'asd' during its initialization is never read
      drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c:4505:29:
      warning: Value stored to 'asd' during its initialization is never read
      drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c:1139:30:
      warning: Value stored to 'asd' during its initialization is never read
      drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c:6961:27:
      warning: Value stored to 'tmp_in_info' during its initialization is
      never read
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      b0e84815
    • Arnd Bergmann's avatar
      media: staging: media: atomisp: remove pointless string copy · a9b539a6
      Arnd Bergmann authored
      gcc-8 points out that a string is copied to itself here:
      
      In file included from drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_include/platform_support.h:25,
                       from drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_include/memory_access/memory_access.h:48,
                       from drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/debug/src/ia_css_debug.c:16:
      In function 'strncpy',
          inlined from 'ia_css_debug_pipe_graph_dump_stage' at drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_include/string_support.h:158:2:
      include/linux/string.h:253:9: error: '__builtin_strncpy' source argument is the same as destination [-Werror=restrict]
        return __builtin_strncpy(p, q, size);
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      
      This removes the bogus code, leaving the behavior otherwise
      unchanged.
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      a9b539a6
    • Alona Solntseva's avatar
      f87c6898