1. 04 Aug, 2005 2 commits
    • David Howells's avatar
      [PATCH] Keys: Fix key management syscall interface bugs · 1260f801
      David Howells authored
      This fixes five bugs in the key management syscall interface:
      
       (1) add_key() returns 0 rather than EINVAL if the key type is "".
      
           Checking the key type isn't "" should be left to lookup_user_key().
      
       (2) request_key() returns ENOKEY rather than EPERM if the key type begins
           with a ".".
      
           lookup_user_key() can't do this because internal key types begin with a
           ".".
      
       (3) Key revocation always returns 0, even if it fails.
      
       (4) Key read can return EAGAIN rather than EACCES under some circumstances.
      
           A key is permitted to by read by a process if it doesn't grant read
           access, but it does grant search access and it is in the process's
           keyrings. That search returns EAGAIN if it fails, and this needs
           translating to EACCES.
      
       (5) request_key() never adds the new key to the destination keyring if one is
           supplied.
      
           The wrong macro was being used to test for an error condition: PTR_ERR()
           will always return true, whether or not there's an error; this should've
           been IS_ERR().
      Signed-Off-By: default avatarDavid Howells <dhowells@redhat.com>
      Signed-Off-By: default avatarLinus Torvalds <torvalds@osdl.org>
      1260f801
    • Benjamin Herrenschmidt's avatar
      [PATCH] Remove suspend() calls from shutdown path · c36f19e0
      Benjamin Herrenschmidt authored
      This removes the calls to device_suspend() from the shutdown path that
      were added sometime during 2.6.13-rc*.  They aren't working properly on
      a number of configs (I got reports from both ppc powerbook users and x86
      users) causing the system to not shutdown anymore.
      
      I think it isn't the right approach at the moment anyway.  We have
      already a shutdown() callback for the drivers that actually care about
      shutdown and the suspend() code isn't yet in a good enough shape to be
      so much generalized.  Also, the semantics of suspend and shutdown are
      slightly different on a number of setups and the way this was patched in
      provides little way for drivers to cleanly differenciate.  It should
      have been at least a different message.
      
      For 2.6.13, I think we should revert to 2.6.12 behaviour and have a
      working suspend back.
      Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      c36f19e0
  2. 03 Aug, 2005 20 commits
  3. 02 Aug, 2005 18 commits