- 20 Mar, 2015 18 commits
-
-
Vatika Harlalka authored
Add new variable idx to shorten line length of other statements and increase readability. Signed-off-by:
Vatika Harlalka <vatikaharlalka@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Vatika Harlalka authored
The variable block_no is introduced so as to shorten line length in the long assignment statement and increase readability. Signed-off-by:
-
Vaishali Thakkar authored
Macro module_spk_synth can be used for speakup drivers whose init and exit paths does only module registrations. So, here remove some boilerplate code by using module_spk_synth. Signed-off-by:
Vaishali Thakkar <vthakkar1994@gmail.com> Signed-off-by:
-
Vaishali Thakkar authored
For simple modules that contain a single spk_synth without any additional setup code then ends up being a block of duplicated boilerplate. This patch adds a new macro, module_spk_synth(), which replaces the module_init()/module_exit() registrations with template functions. Signed-off-by:
-
Sven Dziadek authored
This fixes the coding style issue "line over 80 characters" found by checkpatch.pl Signed-off-by:
Sven Dziadek <sven.dziadek@gmx.de> Signed-off-by:
-
Mateusz Kulikowski authored
CURRENT_RATE macro is used only once in driver. This patch removes it and adds rtllib_current_rate() static function in file using that macro Signed-off-by:
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by:
-
Mateusz Kulikowski authored
Remove eqMacAddr macro and replace it with ether_addr_equal_unaligned() Signed-off-by:
-
Mateusz Kulikowski authored
This macro is already defined in kernel.h - there is no need to redefine it. Signed-off-by:
-
Mateusz Kulikowski authored
Several (unused) macros were removed from driver. Signed-off-by:
-
Mateusz Kulikowski authored
Remove commented-out unions and enum. Signed-off-by:
-
Mateusz Kulikowski authored
rtllib_endianfree.h was not used (only included) Signed-off-by:
-
Mateusz Kulikowski authored
Use netdev_*, dev_* or pr_* instead of printk where possible. KERN_DEBUG messages are left intact as pr_dbg has different behaviour. Signed-off-by:
-
Mateusz Kulikowski authored
Some messages were reported with netdev_* macros and internal driver-specific macro. Signed-off-by:
-
Mateusz Kulikowski authored
Fix checkpatch.pl errors 'Macros with complex values should be enclosed in parentheses'. Signed-off-by:
-
Mateusz Kulikowski authored
Fix checkpatch.pl warning 'space prohibited before semicolon'. Signed-off-by:
-
Mateusz Kulikowski authored
Fix checkpatch.pl warnings: - 'WARNING: quoted string split across lines' - 'WARNING: break quoted strings at a space character' Signed-off-by:
-
Hatice ERTÜRK authored
Fix checkpatch.pl issues with "unnecessary whitespace before a quoted newline" in r819xU_phy.c Signed-off-by:
Hatice ERTURK <haticeerturk27@gmail.com> Signed-off-by:
-
Ioana Ciornei authored
Replace memcpy() with ether_addr_copy() since addresses are __aligned(2). The 2 structures are aligned to u16 as showed below: typedef struct hfa384x_authenticateStation_data { u8 address[ETH_ALEN]; /* 0 6 */ u16 status; /* 6 2 */ u16 algorithm; /* 8 2 */ } __packed hfa384x_authenticateStation_data_t; Total size: 10 typedef struct hfa384x_AuthRequest { u8 sta_addr[ETH_ALEN]; /* 0 6 */ u16 algorithm; /* 6 2 */ } __packed hfa384x_AuthReq_t; Total size: 8 Signed-off-by:Ioana Ciornei <ciorneiioana@gmail.com> Signed-off-by:
-
- 19 Mar, 2015 2 commits
-
-
Redha Gouicem authored
This patch removes useless returns and elses. Signed-off-by:
Redha Gouicem <redha.gouicem@gmail.com> Signed-off-by:
-
Redha Gouicem authored
This patch fixes lines longer than the 80 char limit. Signed-off-by:
-
- 18 Mar, 2015 20 commits
-
-
Gauthier Voron authored
This patch remove unnecessary bracket. Signed-off-by:
Gauthier Voron <gauthier.voron@lip6.fr> Signed-off-by:
Hakan Metin <hakan.metin@lip6.fr> Signed-off-by:
-
Gauthier Voron authored
This patch fix too large line. Signed-off-by:
-
Jonathan Sid-Otmane authored
This fixes the charatcer limit in niobuf.c Signed-off-by:
Jonathan Sid-Otmane <Jonathan.SidOtmane@gmail.com> Signed-off-by:
-
Jonathan Sid-Otmane authored
This fixes the space issues in the file vvp_dev.c Signed-off-by:
-
Roberto Medina authored
Coding style fixes due to exported symbols and comment style. Signed-off-by:
Roberto Medina <robertoxmed@gmail.com> Signed-off-by:
-
Laure Millet authored
This patch fixes lines over 80 characters Signed-off-by:
Laure Millet <laure.millet@lip6.fr> Signed-off-by:
Maxime Lorrillere <maxime.lorrillere@lip6.fr> Signed-off-by:
-
Laure Millet authored
This patch fixes a quoted string split across lines. Signed-off-by:
-
Laure Millet authored
This patch fixes a trailing whitespace in namei.c Signed-off-by:
-
Laure Millet authored
This patch fixes a coding style error in a pointer declaration. Signed-off-by:
-
Laure Millet authored
This fixes a missing blank line after declarations. Signed-off-by:
-
Quentin Lambert authored
The refactoring intrduced in c84a083b ("Staging: dgnc: Use goto for spinlock release before return") inverts the order in which the lock is released and ld is tested for nullity. This patch restores the execution flow. Fixes: c84a083b ("Staging: dgnc: Use goto for spinlock release before return") Signed-off-by:
Quentin Lambert <lambert.quentin@gmail.com> Signed-off-by:
-
Haneen Mohammed authored
dev_* is prefered over pr_* when appropriate device stuct is present. This patch replace pr_err and pr_warn with its dev_ counterpart. Signed-off-by:
Haneen Mohammed <hamohammed.sa@gmail.com> Signed-off-by:
-
Haneen Mohammed authored
This patch replace pr_err/pr_info with dev_err/dev_infi, when appropriate device structure is found. Issues found using the following Coccinelle script. pr_err/dev_err was substituted with pr_info/dev_info in the later case. @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL pr_err@p(...); ...+> } @rr@ identifier r.s, s2, fld; @@ struct s { ... struct s2 *fld; ... }; @rrr@ identifier rr.s2, fld2; @@ struct s2 { ... struct device fld2; ... }; @@ identifier r.i, r.s, rr.fld, rrr.fld2; position r.p; @@ -pr_err@p +dev_err ( + &i->fld->fld2, ...) Signed-off-by: -
Haneen Mohammed authored
This patch replace pr_err/pr_info with dev_err/dev_info, when appropriate device structure is found. Issue found and resolved using the following Coccinelle script. pr_err/dev_err was substituted with pr_info/dev_info in the later case. @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL pr_err@p(...); ...+> } @rr@ identifier r.s, s2, fld; @@ struct s { ... struct s2 *fld; ... }; @rrr@ identifier rr.s2, fld2; @@ struct s2 { ... struct device fld2; ... }; @@ identifier r.i, r.s, rr.fld, rrr.fld2; position r.p; @@ -pr_err@p +dev_err ( + &i->fld->fld2, ...) Signed-off-by: -
Vaishali Thakkar authored
After the commit 28af7ea8 ("Staging: rtl8188eu: Eliminate use of _init_timer"), macros (RTW_TIMER_HDL_ARGS, RTW_TIMER_HDL_NAME, RTW_DECLARE_TIMER_HDL) are no longer needed. So, remove them. Signed-off-by:
-
Haneen Mohammed authored
This patch replace pr_err with dev_err, when appropriate device structure is found. Issue found using the following Coccinelle script: @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL pr_err@p(...); ...+> } @rr@ identifier r.s, fld; @@ struct s { ... struct device *fld; ... }; @@ identifier r.i, rr.fld; position r.p; @@ -pr_err@p +dev_err ( + i->fld, ...) Signed-off-by: -
Haneen Mohammed authored
This patch replace pr_err with dev_err, when appropriate device structre is found. Issue found using the following Coccinelle script: @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL pr_err@p(...); ...+> } @rr@ identifier r.s, fld; @@ struct s { ... struct device *fld; ... }; @@ identifier r.i, rr.fld; position r.p; @@ -pr_err@p +dev_err ( + i->fld, ...) Signed-off-by: -
Haneen Mohammed authored
This patch replace pr_err with dev_err, when appropriate device structre is found. Issue found using the following Coccinelle script: @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL pr_err@p(...); ...+> } @rr@ identifier r.s, fld; @@ struct s { ... struct device *fld; ... }; @@ identifier r.i, rr.fld; position r.p; @@ -pr_err@p +dev_err ( + i->fld, ...) Signed-off-by: -
Haneen Mohammed authored
This patch replace pr_err with dev_err, when appropriate device structure is found. Issue found using the following Coccinelle script: @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL pr_err@p(...); ...+> } @rr@ identifier r.s, fld; @@ struct s { ... struct device *fld; ... }; @@ identifier r.i, rr.fld; position r.p; @@ -pr_err@p +dev_err ( + i->fld, ...) Signed-off-by: -
Vaishali Thakkar authored
Macro module_i2c_driver is used for drivers whose init and exit paths does only register and unregister to i2c API. So, here remove some boilerplate code by using module_i2c_driver. Signed-off-by:
-
