1. 08 Feb, 2003 1 commit
    • Alan Stern's avatar
      [PATCH] USB: Patches for the ECONNRESET error (2.5) · 141f8a23
      Alan Stern authored
      Matt Dharm asked me to send these bug-fix patches directly to you.  They
      correct the error-code handling in usb-storage.  The change for 2.5 is
      pretty minor; it only affects debugging output.  But the change for 2.4 is
      more pervasive, and according to Tom Collins it is the key to making a usb
      hard disk work on his MIPS-based system.
      141f8a23
  2. 05 Feb, 2003 1 commit
  3. 04 Feb, 2003 11 commits
  4. 05 Feb, 2003 3 commits
  5. 04 Feb, 2003 24 commits
    • Matthew Dharm's avatar
      [PATCH] USB usb-storage: implement device-offline code · 903d3907
      Matthew Dharm authored
      This code implements the setting of devices offline during the removal
      phase.
      903d3907
    • Matthew Dharm's avatar
      [PATCH] USB usb-storage: host a host refcount a little bit longer · 435c8eb5
      Matthew Dharm authored
      This patch makes us hold the host reference count a little bit longer in
      the /proc interface code.  We were releasing it too early before.
      435c8eb5
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: earlier rejection of outgoing speedtouch packets · a16a8158
      Duncan Sands authored
        speedtouch: reject outgoing packets earlier when the firmware is not loaded.
      a16a8158
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: allocate speedtouch send urbs in the USB probe routine · 905e6029
      Duncan Sands authored
        speedtouch: allocate send urbs in udsl_usb_probe rather than in udsl_usb_data_init.
        Since this diminishes udsl_usb_data_init down to almost nothing, roll it into the one
        place it was used.  Get rid of the semaphore Oliver put it - it is no longer needed.
      
      
       speedtouch.c |   86 ++++++++++++++++++++++++++---------------------------------
       1 files changed, 38 insertions(+), 48 deletions(-)
      905e6029
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: tweak speedtouch status logic · e51f25e6
      Duncan Sands authored
        speedtouch: change data_started to firmware_loaded, which is what it actually
        means, plus some minor related changes.
      e51f25e6
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: re-cosmetic speedtouch changes · 61f32857
      Duncan Sands authored
        speedtouch: a pile of cosmetic changes to make me feel happier (no code changes).
      61f32857
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: re-wait for speedtouch completion handlers after usb_unlink_urb · 2119afc6
      Duncan Sands authored
        speedtouch: wait for receive urb completion handlers to finish after calling
        usb_unlink_urb.
      2119afc6
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: re-recycle failed speedtouch receive urbs · 606febd3
      Duncan Sands authored
        speedtouch: more robust handling of receive urb failure: retry failed urbs whenever
        a new connection is opened.  This should work well with pppd's persist option.
      606febd3
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: re-recycle speedtouch receive buffers · 5180c534
      Duncan Sands authored
      Rediffed version of the original patch - no sk_buff on the stack this time.
      
        speedtouch: recycle the receive urb's buffer.  Currently, every time a receive urb
          completes, its old buffer is thrown away and replaced with a new one.  This patch
          performs the minor changes needed to reuse the old buffer.
      5180c534
    • Duncan Sands's avatar
      [PATCH] USB speedtouch: let the tasklet do all processing of speedtouch receive urbs · b0e4361a
      Duncan Sands authored
        speedtouch: move all processing of receive urbs to udsl_atm_processqueue.  This has
        several advantages, as will be seen in the next few patches.  The most important is
        that it makes it easy to reuse of the urb's buffer (right now a new buffer is
        allocated every time the urb completes).  By the way, this patch is much smaller than
        it looks: most of the bulk is due to indentation changes.
      b0e4361a
    • Henning Meier-Geinitz's avatar
      [PATCH] USB scanner.c: Adjust syslog output · e7100fba
      Henning Meier-Geinitz authored
      This patch prints the vendor + product ids of the scanner after it has
      been successfully detected.
      
      Also the annoying error message about "Scanner device is already open"
      was downgraded to a dbg. Scanning for devices while one scanner device
      was open produced several 100 error messages in syslog.
      e7100fba
    • Henning Meier-Geinitz's avatar
      [PATCH] USB scanner.h, scanner.c: maintainer change · 80b5d998
      Henning Meier-Geinitz authored
      This patch changes the maintainer from Brian Beattie to Henning
      Meier-Geinitz and adds a link to the documentation and website.
      80b5d998
    • Matthew Dharm's avatar
    • Matthew Dharm's avatar
      [PATCH] usb-storage: convert spaces to tabs · d0a6840a
      Matthew Dharm authored
      This is a minor cleanup to convert 8 spaces into tabs.  There is no
      functional change here.
      d0a6840a
    • Matthew Dharm's avatar
      [PATCH] usb-storage: remove US_FL_DEV_ATTACHED · 196ef4e6
      Matthew Dharm authored
      This patch removes the US_FL_DEV_ATTACHED flag, which is now rendered
      obsolete by the new hotplug system.
      
      It also adds a comment or two about areas of code that need to be
      re-examined.
      196ef4e6
    • Matthew Dharm's avatar
      [PATCH] usb-storage: comments, cleanup · dc18a916
      Matthew Dharm authored
      This patch does the following:
      (o) Add comments showing what needs to be done to complete the hot-unplug
          system.
      (o) Add a BUG_ON() for (what is now) a critical failure case.
      (o) Make certain that a debug print happens even if a usb_get_intfdata()
          crashes.
      (o) Add an un-necessary up() to balance a down, for the auto-code-checkers.
      dc18a916
    • Matthew Dharm's avatar
      [PATCH] usb-storage: fix oops · 5d81afb2
      Matthew Dharm authored
      It should fix the OOPS on attach.
      
      This fixes a silly error where I fail to initialize a pointer early enough
      for the scanning code.  If this isn't a perfect example of why
      scsi_register() and scsi_add_host() aren't two separate functions, I don't
      know what is.  :)
      
      Oh, and I added a couple of comments, too.
      
        -  Fix an OOPS by moving the setting of the hostdata[] pointer to _before_
           the device scan starts.
      5d81afb2
    • Matthew Dharm's avatar
      [PATCH] usb-storage: fix typo · 55d2f9bb
      Matthew Dharm authored
      This patch goes on top of the last one.  It fixes a typo in the test for
      scsi_register() failure.
      
        -- reversed the logic of failure test for scsi_register()
      55d2f9bb
    • Matthew Dharm's avatar
      [PATCH] usb-storage: move to SCSI hotplugging · 82469dfd
      Matthew Dharm authored
      The attached patch is my first implementation of SCSI hotplugging.
      
      It's only been tested that it compiles, as I can't get the current
      linux-2.5 tree from linuxusb to boot.  It dies _very_ early.  Greg, I'm not
      sure if you'll want to apply this.  Linus seemed to want this very much,
      and it is 2.5.x... I say go for it, but I can understand if you have
      reservations.
      
      I would definately like to see this tested by anyone who can get a kernel
      to boot.
      
      This patch is quite large.  Lots of things had to be changed.  Among them:
      
      (o) The proc interface now uses the host number to look up the SCSI host
          structure, and then finds the usb-storage structure from that.
      (o) The SCSI interface has been changed.  The code flow is now much
          clearer, as more work is done from the USB probe/detach functions than
          from auxillary functions.
      (o) Names have been changed for newer conventions
      (o) GUIDs have been removed
      (o) The linked-list of devices has been removed, and it's associated
          semaphore
      (o) All code dealing with re-attaching a device to it's old association has
          been removed
      (o) Some spaces changed to tabs
      (o) usb-storage now takes one directory under /proc/scsi instead of
          one per virtual-HBA
      (o) All control threads now have the same name.  This could be changed back
          to the old behavior, if enough people want it.
      
      Known problems:
      (o) Testing, testing, testing
      (o) More dead code needs to be cut
      (o) It's a unclear how a LLD is supposed to cut off the flow of
          commands, so that the unregister() call always succeeds.  SCSI folks
          need to work on this.
      (o) Probing needs to be broken down into smaller functions, probably.
      82469dfd
    • Greg Kroah-Hartman's avatar
      [PATCH] USB: fix to get usb-storage code to work again. · 6a4f58ed
      Greg Kroah-Hartman authored
      Thanks to Matt Dharm and David Brownell for tracking this bug down.
      6a4f58ed
    • Greg Kroah-Hartman's avatar
    • Andrew Morton's avatar
      [PATCH] fix i_sem contention in sys_unlink() · 46b11ba9
      Andrew Morton authored
      Truncates can take a very long time.  Especially if there is a lot of
      writeout happening, because truncate must wait on in-progress I/O.
      
      And sys_unlink() is performing that truncate while holding the parent
      directory's i_sem.  This basically shuts down new accesses to the entire
      directory until the synchronous I/O completes.
      
      In the testing I've been doing, that directory is /tmp, and this hurts.
      
      So change sys_unlink() to perform the actual truncate outside i_sem.
      
      When there is a continuous streaming write to the same disk, this patch
      reduces the time for `make -j4 bzImage' from 370 seconds to 220.
      46b11ba9
    • Andrew Morton's avatar
      [PATCH] Fix latencies during writeback · b345e6d2
      Andrew Morton authored
      When a throttled writer is performing writeback, and it encounters an inode
      which is already under writeback it is forced to wait on the inode.  So that
      process sleeps until whoever is writing it out finishes the writeout.
      
      Which is OK - we want to throttle that process, and another process is
      currently pumping data at the disk anyway.
      
      But in one situations the delays are excessive.  If one process is performing
      a huge linear write, other processes end up waiting for a very long time
      indeed.  It appears that this is because the writing process just keeps on
      hogging the CPU, returning to userspace, generating more dirty data, writing
      it out, sleeping in get_request_wait, etc.  All other throttled dirtiers get
      starved.
      
      So just remove the wait altogether if it is just a memory-cleansing writeout.
       The calling process will then throttle in balance_dirty_pages()'s call to
      blk_congestion_wait().
      b345e6d2
    • Andrew Morton's avatar
      [PATCH] Remove unneeded code in fs/fs-writeback.c · b21e69ae
      Andrew Morton authored
      We do not need to pass the `wait' argument down to __sync_single_inode().
      That information is now present at wbc->sync_mode.
      b21e69ae