- 18 Dec, 2012 40 commits
-
-
Jingoo Han authored
GPIOF_DIR_OUT and GPIOF_DIR_IN are defined as below: GPIOF_DIR_OUT (0 << 0) GPIOF_DIR_IN (1 << 0) So, when !pdata->reset_inverted is 1, the gpio pin can be set as input, instead of output. To prevent this problem, GPIOF_INIT flag should be used when using devm_gpio_request_one(). Signed-off-by:
Jingoo Han <jg1.han@samsung.com> Cc: Marek Vasut <marex@denx.de> Cc: Richard Purdie <rpurdie@rpsys.net> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
Jingoo Han authored
Previously, when ops functions cannot be called, lcd_show_contrast() and lcd_store_contrast() returned 0, instead of ENXIO. Thus, in this case, a local variable 'rc' for return value should be initialized as ENXIO, after kstrtoul() is called. Signed-off-by:
-
Jingoo Han authored
Remove an unnecessary line continuation in pm860x_backlight_probe(). Also, a checkpatch warning is fixed as below: WARNING: Avoid unnecessary line continuations [akpm@linux-foundation.org: remove newline] Signed-off-by:
-
Peter Ujfalusi authored
TWL_MODULE_PWM is defined as: #define TWL_MODULE_PWM TWL4030_MODULE_PWM0 Use the common module ID define here which will facilitate the upcoming twl-core cleanup. Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Acked-by:
-
Thierry Reding authored
This function finds the struct backlight_device for a given device tree node. A dummy function is provided so that it safely compiles out if OF support is disabled. [akpm@linux-foundation.org: Don't use IS_ENABLED(CONFIG_OF)] Signed-off-by:
Thierry Reding <thierry.reding@avionic-design.de> Acked-by:
Grant Likely <grant.likely@secretlab.ca> Cc: Thierry Reding <thierry.reding@avionic-design.de> Reviewed-by:
-
Axel Lin authored
We don't need the sysfs file to be world writable or group writable. This file is write-only, change it to S_IWUSR (0200). Signed-off-by:
Axel Lin <axel.lin@ingics.com> Acked-by:
"G.Shark Jeong" <gshark.jeong@gmail.com> Signed-off-by:
-
Jingoo Han authored
devm_kfree() allocates memory that is released when a driver detaches. Thus, there is no reason to explicitly call devm_kfree in probe or remove functions. Signed-off-by:
-
Jingoo Han authored
devm_kfree() allocates memory that is released when a driver detaches. Thus, there is no reason to explicitly call devm_kfree() in probe or remove functions. Signed-off-by:
-
Jingoo Han authored
Remove unnecessary cast of void pointer for platform data in probe function. Signed-off-by:
-
Jingoo Han authored
Add 'const' to static array that was missing it in its definition. Also, 'const' is added to ili9320_write_regs(), because it is called by vgg2432a4 driver. Signed-off-by:
-
Jingoo Han authored
Add 'const' to static array that was missing it in its definition. Signed-off-by:
-
Jingoo Han authored
Add 'const' to static array that was missing it in its definition. Signed-off-by:
Marek Vasut <marex@denx.de> Cc: Richard Purdie <rpurdie@rpsys.net> Signed-off-by:
-
Jingoo Han authored
Add 'const' to static array that was missing it in its definition. Signed-off-by:
-
Kim, Milo authored
The mutex for accessing lp855x registers is used in case of the user-space interaction. When the brightness is changed via sysfs, the mutex is required. But the backlight class device already provides it. Thus, the lp855x mutex is unnecessary. Signed-off-by:
Milo(Woogyom) Kim <milo.kim@ti.com> Cc: Thierry Reding <thierry.reding@avionic-design.de> Cc: Richard Purdie <rpurdie@rpsys.net> Cc: Bryan Wu <bryan.wu@canonical.com> Signed-off-by:
-
Kim, Milo authored
The LP855x family devices support the PWM input for the backlight control. Period of the PWM is configurable in the platform side. Platform specific functions are unnecessary anymore because generic PWM functions are used inside the driver. (PWM input mode) To set the brightness, new lp855x_pwm_ctrl() is used. If a PWM device is not allocated, devm_pwm_get() is called. The PWM consumer name is from the chip name such as 'lp8550' and 'lp8556'. To get the brightness value, no additional handling is required. Just the value of 'props.brightness' is returned. If the PWM driver is not ready while initializing the LP855x driver, it's OK. The PWM device can be retrieved later, when the brightness value is changed. Documentation is updated with an example. [akpm@linux-foundation.org: coding-style simplification, per Thierry] Signed-off-by:
-
Jingoo Han authored
By using devm_gpio_request_one it is possible to set the direction and initial value in one shot. Thus, using devm_gpio_request_one can make the code simpler. Signed-off-by:
-
Jingoo Han authored
By using devm_gpio_request_one it is possible to set the direction and initial value in one shot. Thus, using devm_gpio_request_one can make the code simpler. Signed-off-by:
-
Jingoo Han authored
This patch fixes the checkpatch warning as below: WARNING: please, no space before tabs Signed-off-by:
-
Jingoo Han authored
This patch fixes the checkpatch error and warning as below: ERROR: spaces required around that '?' (ctx:VxW) ERROR: space required after that ',' (ctx:VxV) Also, unnecessary lines are removed. Signed-off-by:
-
Jingoo Han authored
This patch fixes the checkpatch warning as below: WARNING: please, no space before tabs Signed-off-by:
-
Jingoo Han authored
This patch fixes the checkpatch error as below: ERROR: spaces prohibited around that ':' (ctx:WxW) Signed-off-by:
-
Jingoo Han authored
This patch fixes the checkpatch warning as below: WARNING: please, no spaces at the start of a line Also, long comments are fixed for the preferred style. Signed-off-by:
-
Jingoo Han authored
This patch fixes the checkpatch warning as below: ERROR: inline keyword should sit between storage class and type Signed-off-by:
-
Jingoo Han authored
This patch fixes the checkpatch warning as below: WARNING: static const char * array should probably be static const char * const Signed-off-by:
-
Jingoo Han authored
This patch fixes the checkpatch warning as below: WARNING: please, no space before tabs Also, unnecessary line is removed. Signed-off-by:
-
Jingoo Han authored
This patch fixes the checkpatch error and warning as below: ERROR: return is not a function, parentheses are not required Also, long comments are fixed for the preferred style. Signed-off-by:
-
Jingoo Han authored
This patch fixes the checkpatch error and warning as below: WARNING: please, no space before tabs WARNING: please, no spaces at the start of a line WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable WARNING: braces {} are not necessary for single statement blocks ERROR: code indent should use tabs where possible Signed-off-by: -
Jingoo Han authored
This patch fixes the checkpatch error and warning as below: WARNING: please, no space before tabs WARNING: please, no spaces at the start of a line ERROR: do not initialise statics to 0 or NULL ERROR: code indent should use tabs where possible Signed-off-by:
-
Jingoo Han authored
This patch fixes the checkpatch warning as below: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: -
Jingoo Han authored
This patch fixes the checkpatch warning as below: WARNING: please, no space before tabs WARNING: quoted string split across lines Signed-off-by:
-
Jingoo Han authored
This patch fixes the checkpatch error and warning as below: WARNING: please, no space before tabs WARNING: quoted string split across lines ERROR: space required before the open parenthesis '(' Signed-off-by: -
Jingoo Han authored
This patch fixes the checkpatch warning as below: WARNING: quoted string split across lines Signed-off-by:
-
Jingoo Han authored
This patch fixes the checkpatch warning as below: WARNING: quoted string split across lines Signed-off-by:
-
Jingoo Han authored
dev_get_drvdata() can be used instead of platform_get_drvdata() to make the code smaller. Signed-off-by:
-
Stefan Richter authored
Signed-off-by:
Stefan Richter <stefanr@s5r6.in-berlin.de> Signed-off-by:
-
Corentin Chary authored
Signed-off-by:
Corentin Chary <corentin.chary@gmail.com> Cc: Matthew Garrett <mjg59@srcf.ucam.org> Signed-off-by:
-
Cesar Eduardo Barros authored
Moved to fs/ext3/ext3.h by commit 4613ad18 ("ext3: move headers to fs/ext3/"). Signed-off-by:
Cesar Eduardo Barros <cesarb@cesarb.net> Cc: Jan Kara <jack@suse.cz> Signed-off-by:
-
Joe Perches authored
Mark it so. Signed-off-by:
Joe Perches <joe@perches.com> Cc: Harry Wei <harryxiyou@gmail.com> Signed-off-by:
-
Jason Gunthorpe authored
Documentation/printk-formats.txt says to use %zd for a ssize_t argument and some drivers do. Unfortunately this prints a positive number for negative values eg: tpm_tis 70030000.tpm_tis: tpm_transmit: tpm_send: error 4294967234 Add a case to va_args a ssize_t type if the interpretation should be signed. Tested on PPC32. Signed-off-by:
Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Signed-off-by:
-
Andrew Cooks authored
The boot_delay parameter affects all printk(), even if the log level prevents visible output from the call. It results in delays greater than the user intended without purpose. This patch changes the behaviour of boot_delay to only delay output. Signed-off-by:
Andrew Cooks <acooks@gmail.com> Acked-by:
Randy Dunlap <rdunlap@infradead.org> Cc: Joe Perches <joe@perches.com> Signed-off-by:
-
