- 19 Oct, 2010 1 commit
-
-
Sven Eckelmann authored
David Miller <davem@davemloft.net> recommended in 20100924.134334.28812338.davem@davemloft.net that we must make the hash abstraction helper more efficient and may remove it completely. Signed-off-by:
Sven Eckelmann <sven.eckelmann@gmx.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
- 15 Oct, 2010 38 commits
-
-
Dan Carpenter authored
Vinod wanted the copy_to_user() calls in this format: if (copy_to_user()) retval = -EFAULT; instead of this: retval = copy_to_user(); if (retval) retval = -EFAULt; I've done that for the whole intel_sst_app_interface.c file. In the process I noticed a couple more places that returned -EBUSY or -EAGAIN instead of -EFAULT. Signed-off-by:
Dan Carpenter <error27@gmail.com> Signed-off-by:
-
Dan Carpenter authored
This should be >= instead of > or we go passed the end of the array. Also the arrays are declared with size MAX_NUM_STREAMS. This is the only place that uses MAX_NUM_STREAMS_MFLD. It seems like asking for trouble to use two variables for the same information. I've changed everything to use MAX_NUM_STREAMS. This bug isn't really harmful. In the worst case, if you enabled debugging then you would see a message. Signed-off-by:
-
Dan Carpenter authored
copy_to_user() returns the number of bytes remaining to be copied but we want to return an error code. And that error code is -EFAULT not -EIO. Signed-off-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
Haiyang Zhang authored
Convert camel cased functions in channel_mgmt.c to lower case Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by:
Hank Janssen <hjanssen@microsoft.com> Signed-off-by:
-
Haiyang Zhang authored
Convert camel cased local variable names in channel_mgmt.c to lower case Signed-off-by:
-
Haiyang Zhang authored
Convert camel cased parameter in channel_interface.h to lower case Signed-off-by:
-
Haiyang Zhang authored
Convert camel cased function names in channel_interface.c to lower cases Signed-off-by:
-
Haiyang Zhang authored
Convert camel cased local variables in channel_interface.c to lower cases Signed-off-by:
-
Julia Lawall authored
In the first hunk, 0 is returned on memory allocation failure, even though other failures return -ENOMEM or other similar values. In the second hunk, there was error handling code that returned without freeing psz_path_name. A simplified version of the semantic match that finds the first problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression ret; expression x,e1,e2,e3; @@ ret = 0 ... when != ret = e1 *x = \(kmalloc\|kcalloc\|kzalloc\)(...) ... when != ret = e2 if (x == NULL) { ... when != ret = e3 return ret; } // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
-
Marek Belisko authored
Signed-off-by:
Marek Belisko <marek.belisko@gmail.com> Signed-off-by:
-
Marek Belisko authored
Signed-off-by:
-
Marek Belisko authored
Signed-off-by:
-
Marek Belisko authored
Signed-off-by:
-
Marek Belisko authored
Signed-off-by:
-
Marek Belisko authored
Signed-off-by:
-
Marek Belisko authored
Signed-off-by:
-
Marek Belisko authored
Signed-off-by:
-
Marek Belisko authored
Signed-off-by:
-
Marek Belisko authored
Signed-off-by:
-
Dan Carpenter authored
&sst_drv_ctx->streams[str_id].lock and &stream->lock are the same. The mutex_lock() uses &stream->lock so this makes things consistent and it's nicer to read as well. Signed-off-by:
Vinod Koul <vinod.koul@intel.com> Signed-off-by:
-
Dan Carpenter authored
Using pdpram_blk here would cause an oops. We intended to use &freercvpool. Signed-off-by:
-
Dan Carpenter authored
This is a typo. It's supposed to be IS_ERR() here instead of PTR_ERR(). Signed-off-by:
Jarod Wilson <jarod@redhat.com> Signed-off-by:
-
Dan Carpenter authored
The code here is supposed checking if we exited the loop without hitting a break. The problem is that in the error handling "i" is out of bounds and it corrupts memory when we do an info->app_info[i].nRxMsgMiss++. >From the comments, it looks like someone noticed this corruption and updated the code, but didn't totally fix the problem. The correct fix is just to remove nRxMsgMiss++ from the error path. I believe this bug can be triggered remotely. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. * Replace a function-like macro with an inline function. * Remove an incorrect use of the volatile qualifier. The previously-volatile variable is now always protected by a spinlock. Signed-off-by:
Christopher Brannon <chris@the-brannons.com> Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. * Make the file_operations structure const. * Use strict_strtoul instead of simple_strtoul. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. * Remove an unused function-like macro. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. * Eliminate the unused synth_readable macro. * Convert function-like macros to inline functions. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. * Replace function-like macros with inline functions. * Simplify some boolean expressions. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. * Replace function-like macros with inline macros. * Eliminate a use of the ternary operator, for readability. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. * Eliminate an unused function-like macro. Signed-off-by:
-
Christopher Brannon authored
* Clean this file based on reports from checkpatch.pl. * Eliminate the unused synth_readable macro. * Convert function-like macros to inline functions. Signed-off-by:
-
- 14 Oct, 2010 1 commit
-
-
Pavan Savoy authored
Based on comments from Jiri Slaby, drop the register storage specifier, remove the unused code, cleanup the const to non-const type casting. Also make the line discipline ops structure static, since its a singleton, unmodified structure which need not be in heap. Reported-by:
Jiri Slaby <jirislaby@gmail.com> Signed-off-by:
Pavan Savoy <pavan_savoy@ti.com> Signed-off-by:
-
