- 20 May, 2011 40 commits
-
-
Jonathan Nieder authored
The BKL conversion of this driver seems to have gone wrong. Loading the cx88-blackbird driver deadlocks. The cause: mpeg_ops::open in the cx2388x blackbird driver acquires the device lock and calls the sub-driver's request_acquire, which tries to acquire the lock again. Fix it by clarifying the semantics of request_acquire, request_release, advise_acquire, and advise_release: now all will rely on the caller to acquire the device lock. Based on work by Ben Hutchings <ben@decadent.org.uk>. Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=31962Reported-by:
Andi Huber <hobrom@gmx.at> Tested-by:
Marlon de Boer <marlon@hyves.nl> Cc: stable@kernel.org Signed-off-by:
Jonathan Nieder <jrnieder@gmail.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab@redhat.com>
-
Jonathan Nieder authored
The BKL conversion of this driver seems to have gone wrong. Various uses of the sub-device and driver lists appear to be subject to race conditions. In particular, some functions access drvlist without a relevant lock held, which will race against removal of drivers. Let's start with that --- clean up by consistently protecting dev->drvlist with dev->core->lock, noting driver functions that require the device lock to be held or not to be held. After this patch, there are still some races --- e.g., cx8802_blackbird_remove can run between the time the blackbird driver is acquired and the time it is used in mpeg_release, and there's a similar race in cx88_dvb_bus_ctrl. Later patches will address the remaining known races and the deadlock noticed by Andi. This patch just makes the semantics clearer in preparation for those later changes. Based on work by Ben Hutchings <ben@decadent.org.uk>. Tested-by:
-
HIRANO Takahito authored
Signed-off-by:
HIRANO Takahito <hiranotaka@zng.info> Signed-off-by:
-
Ondrej Zary authored
Enabling force_testpattern module parameter in usbvision causes kernel panic. Things like that does not belong to the kernel anyway so the fix is easy. Signed-off-by:
Ondrej Zary <linux@rainbow-software.org> Signed-off-by:
-
Ondrej Zary authored
Add Nogatech USB MicroCam PAL (NV3001P) and NTSC (NV3000N) support to usbvision driver. PAL version is tested, NTSC untested. Data captured using usbsnoop, init_values are listed in the INF file along with image dimensions, offsets and frame rates. Signed-off-by:
-
Malcolm Priestley authored
Improve PID filtering and program register 20 correctly. Make sure stream_on message is sent if streaming is off, otherwise PIDs are not registered. Move mutex outside lme2510_enable_pid. Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
-
Malcolm Priestley authored
usb_buffer not inside mutex lock, waiting caller can alter buffer. Static added to lme2510_exit and lme2510_exit_int. Signed-off-by:
-
Malcolm Priestley authored
Gate could close after first I2C message. On stv0288 it does. Keep 2nd and 3rd message I2C gate control alive. Remove unnecessary gate closing in this module. Signed-off-by:
-
Jesper Juhl authored
In drivers/media/dvb/siano/smsusb.c we have this code: ... kfree(dev); sms_info("device %p destroyed", dev); ... at least one static analysis tool (Coverity Prevent) complains about this as a use-after-free bug. While it's true that we do use the pointer variable after freeing it, the only use is to print the value of the pointer, so there's not actually any problem here. But still, silencing the complaint is trivial by just moving the kfree() call below the sms_info(), so why not just do it?. It doesn't change the workings of the code in any way, but it makes the tool shut up. The patch below also removes a rather pointless blank line. Signed-off-by:Jesper Juhl <jj@chaosbits.net> Signed-off-by:
-
Mauro Carvalho Chehab authored
On some situations, it is desired to use eeprom data to detect the board type. This patch adds a logic for it and fixes 2 detection issues: 1) 10Moons UT-821 uses a generic Trident ID. Other boards also share the same ID. So, better to use an alternative way for it; 2) Sometimes, HVR-900H is loaded with the default Trident ID. This seems to be some hardware bug or race condition. The new logic will only be enabled if the device is detected as having a generic ID. Signed-off-by: -
Malcolm Priestley authored
Signed-off-by:
-
Malcolm Priestley authored
Return device errors to demuxer from on/off streamming and pid filtering. Please test this patch with all dvb-usb devices. Signed-off-by:
-
Alexey Khoroshilov authored
There are a couple of places where mutex_unlock() is called even if mutex_lock_interruptible() failed. The patch fixes the issue. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:
Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by:
-
Márcio Alves authored
[mchehab@redhat.com: avoided board renumberation, removed an unused #define and re-used the existing mb86a20s dvb attach code] Signed-off-by:
Márcio A Alves <froooozen@gmail.com> Signed-off-by:
-
Marko Ristola authored
Avoid unnecessary DVB TS 188 sized packet copying from DMA buffer into stack. Backtrack one 188 sized packet just after some garbage bytes when possible. This obsoletes patch https://patchwork.kernel.org/patch/118147/Signed-off-by:
Marko Ristola <marko.ristola@kolumbus.fi> Acked-by:
Andreas Oberritter <obi@linuxtv.org> Signed-off-by:
-
Jesper Juhl authored
We leak the memory allocated to 'fw' (the firmware) when the variable goes out of scope. Fix the leak by calling release_firmware(fw) before 'fw' goes out of scope. Signed-off-by:
-
Jesper Juhl authored
If the second memory allocation in dib9000_attach() fails, we'll leak the memory allocated by the first. Signed-off-by:
-
Steven Toth authored
Add support for mmap method streaming of raw YUV video on cx18-based hardware, in addition to the existing support for read() streaming of raw YUV and MPEG-2 encoded video. [simon.farnsworth@onelan.co.uk: I forward-ported this from Steven's original work, done under contract to ONELAN. The original code is at http://www.kernellabs.com/hg/~stoth/cx18-videobuf] Signed-off-by:
Steven Toth <stoth@kernellabs.com> Signed-off-by:
Simon Farnsworth <simon.farnsworth@onelan.co.uk> Signed-off-by:
-
Stefan Ringel authored
add CARDLIST Signed-off-by:
Stefan Ringel <stefan.ringel@arcor.de> Signed-off-by:
-
Sensoray Linux Development authored
Adding jpeg enable module parameter. Signed-off-by:
Dean Anderson <linux-dev@sensoray.com> Signed-off-by:
-
Sensoray Linux Development authored
adding MJPEG format Signed-off-by:
-
Thiago Farina authored
Signed-off-by:
Thiago Farina <tfransosi@gmail.com> Signed-off-by:
-
Malcolm Priestley authored
A greatly simplified version of the PID Filter now added back to the Driver. The driver allows for the PID filter to be turned off. applied after patch 683781. Signed-off-by:
-
Malcolm Priestley authored
Register 42 bits 2,3,6 and 7 should be set to 0. This gives difficult locking on some channels and may be compensated for by other methods. This affects any driver using the stv0288 frontend on the default or earda inittab. Signed-off-by:
-
Malcolm Priestley authored
stv0288 Register 42 bits 6 & 7 should be set to 0. This is causing intermittent lock, the dvb-usb-lmedm04 driver uses register 50 (auto fine mode) to correct for this, this register is now returned to its default setting. Signed-off-by:
-
Pete Eberlein authored
An usb_submit_urb should be atomic in a completion handler. This fixes "BUG: scheduling while atomic" messages. Signed-off-by:
Pete Eberlein <pete@sensoray.com> Signed-off-by:
-
Oliver Endriss authored
Add support for TT S-1500 with BSBE1-D01A tuner. Signed-off-by:
Oliver Endriss <o.endriss@gmx.de> Signed-off-by:
-
Hans Petter Selasky authored
Signed-off-by: -
Jean-Francois Moine authored
Signed-off-by:
Jean-François Moine <moinejf@free.fr> Signed-off-by:
-
Mariusz Kozlowski authored
Seems like 'adap->fe' test for NULL was meant to be before we dereference that pointer. Signed-off-by:
Mariusz Kozlowski <mk@lab.zgora.pl> Acked-by:
Patrick Boettcher <patrick.boettcher@dibcom.fr> Signed-off-by:
-
Dan Carpenter authored
The generic_standards_cnt define is only used in one place and it's more readable to just call ARRAY_SIZE(generic_standards) directly. Signed-off-by:
Dan Carpenter <error27@gmail.com> Signed-off-by:
-
Dan Carpenter authored
This function returns NULL on failure so lets do that if kzalloc() fails. There is a separate problem that the caller for this function doesn't check for errors... Signed-off-by:
Mike Isely <isely@pobox.com> Signed-off-by:
-
Timothy Lee authored
This card has a TD18271 silicon tuner, and uses TDA8290 and LGS8G75 to demodulate analog and digital broadcast respectively. GPIO configurations were derived using DScaler regspy. Signed-off-by: -
Jean Delvare authored
The ability to force the encoder or decoder chip was broken by commit 0ab6e1c3 in February 2009. As nobody complained for over 2 years, I take it that these parameters were no longer used so we can simply drop them. Signed-off-by:
Jean Delvare <khali@linux-fr.org> Cc: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by:
-
Florian Mickler authored
usb_control_msg initiates (and waits for completion of) a dma transfer using the supplied buffer. That buffer thus has to be seperately allocated on the heap. In lib/dma_debug.c the function check_for_stack even warns about it: WARNING: at lib/dma-debug.c:866 check_for_stack Tested-by:
Florian Mickler <florian@mickler.org> Signed-off-by:
-
Florian Mickler authored
usb_control_msg initiates (and waits for completion of) a dma transfer using the supplied buffer. That buffer thus has to be seperately allocated on the heap. In lib/dma_debug.c the function check_for_stack even warns about it: WARNING: at lib/dma-debug.c:866 check_for_stack Signed-off-by:
Antti Palosaari <crope@iki.fi> Reviewed-by:
-
Florian Mickler authored
usb_control_msg initiates (and waits for completion of) a dma transfer using the supplied buffer. That buffer thus has to be seperately allocated on the heap. In lib/dma_debug.c the function check_for_stack even warns about it: WARNING: at lib/dma-debug.c:866 check_for_stack Signed-off-by:
-
Florian Mickler authored
usb_control_msg initiates (and waits for completion of) a dma transfer using the supplied buffer. That buffer thus has to be seperately allocated on the heap. In lib/dma_debug.c the function check_for_stack even warns about it: WARNING: at lib/dma-debug.c:866 check_for_stack Signed-off-by:
-
Florian Mickler authored
Note: This change is tested to compile only as I don't have the hardware. Signed-off-by:
-
Florian Mickler authored
If we need a bigger buffer, we reallocte a new buffer and free the old one. Note: This change is tested to compile only as I don't have the hardware. Signed-off-by:
-
