- 27 Oct, 2019 5 commits
-
-
Cristiane Naves authored
Fix Blank lines aren't necessary before a close brace '}'. Issue found by checkpatch. Signed-off-by:
Cristiane Naves <cristianenavescardoso09@gmail.com> Link: https://lore.kernel.org/r/8c74dcd9afaa528a80804081f582792045bb7a7a.1572121059.git.cristianenavescardoso09@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Cristiane Naves authored
Use devm_platform_ioremap_resource helper which wraps platform_get_resource() and devm_ioremap_resource() together. Issue found by coccicheck. Signed-off-by:
-
Cristiane Naves authored
Bool tests don't need comparisons. Issue found by coccicheck. Signed-off-by:
-
Cristiane Naves authored
Remove unneeded variable used to store return value. Issue found by coccicheck. Signed-off-by:
-
Cristiane Naves authored
Fix lines ending with a '('. Issue found by checkpatch. Signed-off-by:
-
- 26 Oct, 2019 32 commits
-
-
Samuil Ivanov authored
This is a task from the TODO list of qlge driver: - some "while" loops could be rewritten with simple "for" The change is in functions ql_wait_reg_rdy and ql_wait_cfg in qlge_main.c. The while loops are basically count based (they decrement on each iteration), and it makes more sense to be a for loop construction instead. Signed-off-by:
Samuil Ivanov <samuil.ivanovbg@gmail.com> Link: https://lore.kernel.org/r/20191023205855.GA1841@samuil-ThinkCentre-M92PSigned-off-by:
-
Michael Hennerich authored
The SEPS525 is a 160 RGB x 128 Dots, 262K Colors PM-OLED Display Driver and Controller. The controller can be found on the NHD-1.69-160128UGC3 (Newhaven Display International, Inc.). Datasheets: Link: https://www.newhavendisplay.com/appnotes/datasheets/OLEDs/SEPS525.pdfSigned-off-by:
Michael Hennerich <michael.hennerich@analog.com> Co-developed-by:
Beniamin Bia <beniamin.bia@analog.com> Signed-off-by:
-
Tim Collier authored
The variant field in struct hfa384x_usbctlx is not referenced anywhere in the driver, so remove it. Signed-off-by:
Tim Collier <osdevtc@gmail.com> Link: https://lore.kernel.org/r/20191025084126.9181-6-osdevtc@gmail.comSigned-off-by:
-
Tim Collier authored
Fix compilation errors (remove references to 2 undefined fields in the URB struct) when DEBUG_USB is defined for the wlan-ng driver. Signed-off-by:
-
Tim Collier authored
Realign parameter in function declaration to fix checkpatch.pl warning that parameter needed to be aligned with the opening parenthesis of the declaration. Signed-off-by:
-
Tim Collier authored
Shorten several lines reported as over 80 characters by checkpatch.pl. Signed-off-by:
-
Tim Collier authored
usb_get_intfdata returns a void pointer. It is not necessary to explicitly cast to the desired type and removing the casts is consistent with most use of usb_get_intfdata. Signed-off-by:
-
Michael Straube authored
Remove else-arm from if-else statement. Move the else code out of the if-else and skip it by adding goto exit to the if block. The exit label was directly after the else-arm, so there is no change in behaviour. Reduces indentation level and clears a line over 80 characters checkpatch warning. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20191026121135.181897-7-straube.linux@gmail.comSigned-off-by:
-
Michael Straube authored
Cleanup lines over 80 characters in rtw_sta_mgt.c by adding line breaks where appropriate. Signed-off-by:
-
Michael Straube authored
Instead of using ternary operator to set variable res, use the value of variable match (or the negation) directly to simplify the code and improve readability. Signed-off-by:
-
Michael Straube authored
Function rtw_access_ctrl returns boolean values, so change the return type to bool. Also convert the local variables that are used for the return value from u8 to bool. Signed-off-by:
-
Michael Straube authored
Rename array bcast_addr to be more consistent in variable naming. In other places in this file buffers for broadcast addresses are named bc_addr as well. bcast_addr -> bc_addr Signed-off-by:
-
Michael Straube authored
Convert array bcast_addr from unsigned char to u8. Clears a line over 80 characters checkpatch warning. Signed-off-by:
-
Michael Straube authored
Cleanup comments in rtw_sta_mgt.c to use kernel block comment style and not exceed 80 characters line length. Signed-off-by:
-
Jules Irenge authored
: Fix warnings of alignment should match open parenthesis. Issue detected by checkpatch tool. Signed-off-by:
Jules Irenge <jbi.octave@gmail.com> Link: https://lore.kernel.org/r/20191019140719.2542-6-jbi.octave@gmail.comSigned-off-by:
-
Jules Irenge authored
Correct misspelled words: retrieved and auxiliary. Issue detected by checkpatch tool. Signed-off-by:
-
Jules Irenge authored
Fix check warnings of logical continuations should be on the previous line. Issue detected by checkpatch tool. Signed-off-by:
-
Jules Irenge authored
Fix warning of lines over 80 characters. Issue detected by checkpatch tool. Signed-off-by:
-
Jules Irenge authored
Fix warnings of no space is necessary after a cast. Issue detected by checkpatch tool. Signed-off-by:
-
Jérôme Pouiller authored
Original API declares 16 tx_policies. But in fact, the 16th is used internally by the firmware. So, only 15 tx_policies are available for driver. Reported-by:
Alban Jeantheau <alban.jeantheau@silabs.com> Signed-off-by:
Jérôme Pouiller <jerome.pouiller@silabs.com> Link: https://lore.kernel.org/r/20191017093954.657-6-Jerome.Pouiller@silabs.comSigned-off-by:
-
Jérôme Pouiller authored
MAC address read from chip is unconditionally used even if a MAC address is configured in device tree. Reported-by:
Marc Dorval <marc.dorval@silabs.com> Signed-off-by:
-
Jérôme Pouiller authored
In most case, of_get_mac_address() return NULL in case of error. However, if CONFIG_OF_NET is not set, it return -ENODEV. Signed-off-by:
-
Jérôme Pouiller authored
If CONFIG_MMC=m and CONFIG_WFX=y, compilation complains with undefined references: drivers/staging/wfx/main.o: In function `wfx_core_init': /linux/drivers/staging/wfx/main.c:488: undefined reference to `sdio_register_driver' drivers/staging/wfx/main.o: In function `wfx_core_exit': /linux/drivers/staging/wfx/main.c:496: undefined reference to `sdio_unregister_driver' drivers/staging/wfx/main.o:(.debug_addr+0x1a8): undefined reference to `sdio_register_driver' drivers/staging/wfx/main.o:(.debug_addr+0x6f0): undefined reference to `sdio_unregister_driver' Indeed, symbols sdio_* are not present in kernel image. This patch disallows CONFIG_WFX=y if CONFIG_MMC=m. This solution impacts users who want to use SPI bus with configuration: CONFIG_WFX=y + CONFIG_SPI=y + CONFIG_MMC=m. However, I think this is a twisted case. So, I think it won't be missed. Reported-by:zhong jiang <zhongjiang@huawei.com> Signed-off-by:
-
Jérôme Pouiller authored
"Secure link" feature is not available in in-tree driver (because it depends on mbedtls). Thus, secure_link.h only empty functions. Module parameter "slk_key" and associated function wfx_fill_sl_key() had an unjustifiable place in main.c. This patch relocate them to secure_link.h. BTW, content of wfx_fill_sl_key() is now useless. Just keep a warning if user try to use "slk_key" attribute (unsupported by this driver). Signed-off-by:
-
Jérôme Pouiller authored
wfx_version.h says that this code is same same than driver 2.3.1 hosted on github: https://github.com/siliconlabs/wfx-linux-driver/tree/2.3.1-public However, it is inaccurate, driver in-tree contains multiple small patches ahead 2.3.1. I prefer to drop this confusing information. Signed-off-by: -
Javier F. Arias authored
Change tabs for spaces when they are incorrectly used as separators. Fix suggested by Julia Lawall. Signed-off-by:
Javier F. Arias <jarias.linux@gmail.com> Link: https://lore.kernel.org/r/7b06c103665ab7250dded8c5dadc093228eee7b4.1571284318.git.jarias.linux@gmail.comSigned-off-by:
-
Javier F. Arias authored
Fix function call format by following the coding style guidelines for argument wrapping in function calls. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Fix indentation warnings to improve the code formatting. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Remove commented code for a cleaner file. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Add spaces between operators for a better readability. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Fix lines over 80 characters by wrapping arguments in function calls, improving the format for a better code readability. Issue found by checkpatch. Signed-off-by:
-
Javier F. Arias authored
Replace the hardcoded function names with the corresponding predefined identifiers. Issue found by checkpatch. Signed-off-by:
-
- 25 Oct, 2019 3 commits
-
-
Valdis Kletnieks authored
Add a L: tag so get_maintainers.pl output includes the linux-fsdevel list Signed-off-by:
Valdis Kletnieks <Valdis.Kletnieks@vt.edu> Link: https://lore.kernel.org/r/20191023055353.695275-1-Valdis.Kletnieks@vt.eduSigned-off-by:
-
Ajay Singh authored
During concurrent mode(AP/STA + P2P), pass the mgmt frames received from firmware to appropriate interface. Iterate the complete interface list to pass frames on the interface which has registered to receive mgmt frame. Added extra time for 'remain_on_ch' timer to ensure that timeout for uncanceled remain_on_channel is not triggered & 'p2p_listen_state' is not cleared before passing the mgmt frames to p2p interface. Signed-off-by:
Ajay Singh <ajay.kathat@microchip.com> Link: https://lore.kernel.org/r/20191018124511.22751-1-ajay.kathat@microchip.comSigned-off-by:
-
Dan Carpenter authored
The "rates_len" value needs to be capped so that the memcpy() doesn't copy beyond the end of the array. Fixes: c5c77ba1 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Adham Abozaeid <adham.abozaeid@microchip.com> Link: https://lore.kernel.org/r/20191017091832.GB31278@mwandaSigned-off-by:
-
