Skip to content

L
linux
Switch branch/tag
  1. 17 Jul, 2016 1 commit
  3. 13 Jul, 2016 1 commit
  5. 12 Jul, 2016 3 commits
  7. 11 Jul, 2016 1 commit
  9. 07 Jul, 2016 1 commit
    • Takashi Sakamoto's avatar
      ALSA: control: add dimension validator for userspace elements · 860c1994
      Takashi Sakamoto authored 
      The 'dimen' field in struct snd_ctl_elem_info is used to compose all of
members in the element as multi-dimensional matrix. The field has four
members. Each member represents the width in each dimension level by
element member unit. For example, if the members consist of typical
two dimensional matrix, the dimen[0] represents the number of rows
and dimen[1] represents the number of columns (or vise-versa).

The total members in the matrix should be exactly the same as the number
of members in the element, while current implementation has no validator
of this information. In a view of userspace applications, the information
must be valid so that it cannot cause any bugs such as buffer-over-run.

This commit adds a validator of dimension information for userspace
applications which add new element sets. When they add the element sets
with wrong dimension information, they receive -EINVAL.
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      860c1994
  11. 05 Jul, 2016 1 commit
    • Arnd Bergmann's avatar
      ALSA: ppc/awacs: shut up maybe-uninitialized warning · b268c34e
      Arnd Bergmann authored 
      The awacs sound driver produces a false-positive warning in ppc64_defconfig:

sound/ppc/awacs.c: In function 'snd_pmac_awacs_init':
include/sound/control.h:219:9: warning: 'master_vol' may be used uninitialized in this function [-Wmaybe-uninitialized]

I haven't come up with a good way to rewrite the code to avoid the
warning, so here is a bad one: I initialize the variable before
the conditionall initialization so gcc no longer has to worry about
it.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      b268c34e
  13. 30 Jun, 2016 1 commit
  15. 17 Jun, 2016 4 commits
    • Arnd Bergmann's avatar
      ALSA: seq_timer: use monotonic times internally · 3915bf29
      Arnd Bergmann authored 
      The sequencer client manager reports timestamps in units of unsigned
32-bit seconds/nanoseconds, but that does not suffer from the y2038
overflow because it stores only the delta since the 'last_update'
time was recorded.

However, the use of the do_gettimeofday() function is problematic
and we have to replace it to avoid the overflow on on 32-bit
architectures.

This uses 'struct timespec64' to record 'last_update', and changes
the code to use monotonic timestamps that do not suffer from leap
seconds and settimeofday updates.

As a side-effect, the code can now use the timespec64_sub() helper
and become more readable and also avoid a multiplication to convert
from microseconds to nanoseconds.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      3915bf29
    • Amitoj Kaur Chawla's avatar
      ALSA: ctxfi: Change structure initialisation to C99 style · d1691338
      Amitoj Kaur Chawla authored 
      For readability and to allow for structure randomisation, replace the
in order struct initialisation style with explicit field style.

The Coccinelle semantic patch used to make this change is as follows:

@decl@
identifier i1,fld;
type T;
field list[n] fs;
@@

struct i1 {
 fs
 T fld;
 ...};

@@
identifier decl.i1,i2,decl.fld;
expression e;
position bad.p, bad.fix;
@@

struct i1 i2@p = { ...,
+ .fld = e
- e@fix
 ,...};
Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      d1691338
    • Amitoj Kaur Chawla's avatar
      ALSA: usb-audio: Change structure initialisation to C99 style · e5c53278
      Amitoj Kaur Chawla authored 
      To allow for structure randomisation, replace the in order struct
initialisation style with explicit field style.

The Coccinelle semantic patch used to make this change is as follows:

@decl@
identifier i1,fld;
type T;
field list[n] fs;
@@

struct i1 {
 fs
 T fld;
 ...};

@@
identifier decl.i1,i2,decl.fld;
expression e;
position bad.p, bad.fix;
@@

struct i1 i2@p = { ...,
+ .fld = e
- e@fix
 ,...};
Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      e5c53278
    • Arnd Bergmann's avatar
      sound: oss: avoid time_t usage · cfecf1af
      Arnd Bergmann authored 
      We want to remove all time_t users from the kernel because of
y2038 compatibility. This particular instance does not even
use time_t to store a seconds value, so we can simply use
'unsigned int', which seems more fitting anywhere.

The same code is used in two OSS files.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      cfecf1af
  17. 16 Jun, 2016 1 commit
  19. 15 Jun, 2016 4 commits
  21. 09 Jun, 2016 1 commit
  23. 07 Jun, 2016 2 commits
  25. 03 Jun, 2016 1 commit
  27. 02 Jun, 2016 1 commit
    • Takashi Iwai's avatar
      ALSA: hda - Turn off loopback mixing as default · fabc16fe
      Takashi Iwai authored 
      So far, we enabled the loopback mixing control as default, as this
behavior made somewhat compatible with the earlier HD-audio drivers
for Realtek & co.  However, it's getting annoying as we've got more
and more bug reports about the noise coming from the loopback route.
Since the loopback mixing is used fairly rarely and often harmful
(e.g. using PA), let's get rid of the default turn-on lines.
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      fabc16fe
  29. 01 Jun, 2016 11 commits
  31. 31 May, 2016 1 commit
  33. 30 May, 2016 2 commits
  35. 29 May, 2016 3 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7