1. 24 Apr, 2003 4 commits
    • Andrew Morton's avatar
      [PATCH] irqs: scsi · 28e9fb93
      Andrew Morton authored
      Update SCSI drivers for the new IRQ API.  Also fix warnings and compilation
      errors as encountered.
      28e9fb93
    • Dave Olien's avatar
      [PATCH] 2.5.68 scsi/gdth compile warnings and stack usage · f512f4dd
      Dave Olien authored
      James Bottomley, please apply this patch.  It was sent out on
      linux-scsi last week and drew no responses.
      
      This is a patch for the scsi/gdth driver.  It was originally
      done in 2.5.67, but the patch applies to 2.5.68.
      
      There are two components to this patch.  The first component fixes
      with compilation warnings (which did uncover real bugs).  The other component
      (by Randy Dunlap) reduces stack size usage in gdth_ioctl().
      
      The compilation warnings occur only when CONFIG_HIGHMEM=y in the kernel
      configuration file (enable either 4gig or 64gig memory support).  This
      changes the size of the dma_addr_t from u32 to u64.
      The calls to pci_alloc_consistent return a value of type dma_addr_t.
      But the code was casting a pointer to what was ony a 32-bit memory location.
      
      This seonc component of the patch reduces stack size in
      scsi/gdth.c::gdth_ioctl() by making each separate ioctl have its own
      handler function, so that several large data structs are all declared on
      the stack at the same time.
      
      patch_name:     gdth-stack_warnings.patch
      patch_version:  2003-04-14.16:31:30
      author:         Randy.Dunlap <rddunlap@osdl.org>, Dave.Olien<dmo@osdl.org)
      description:    reduce stack usage in drivers/scsi/gdth.c::gdth_ioctl()
                      from 0xb50 to 0x5c (on P4, gcc 2.96); the large (ioctl)
                      function sizes in gdth.o now are:
                              150 ioc_event
                              178 ioc_resetdrv
                              190 ioc_general
                              30c ioc_hdrlist
                              324 ioc_rescan
                      so the largest cumulative size of calling gdth_ioctl() +
                      a specific ioctl is 0x5c + 0x324 = 0x380.
      		Fix compilation warnings in calls to pci_alloc_consistent()
      		that occur only when CONFIG_HIGHMEM=y.  The compiler
      		warnings result from dma_addr_t changing in size from u32
      		to u64.
      product:        Linux
      product_versions: 2.5.67
      changelog:      make each ioctl that uses large stack space into its own
                      function;
                      mostly moving lines of code around;
                      duplicates some local data in multiple functions;
      		fix compiler warnings by adding intermediate dma_addr_t local
      		variables to hold returns from pci_alloc_consistent.
      maintainer:     Achim Leubner (achim.leubner@intel.com)
      diffstat:	=
       drivers/scsi/gdth.c      |  664 ++++++++++++++++++++++++++---------------------
       drivers/scsi/gdth_proc.c |    5
       2 files changed, 374 insertions(+), 295 deletions(-)
      
      FYI:  The killer data structs in gdth_ioctl() (on x86, P4, gcc 2.96) are:
                      sizeof gdth_cmd_str: 336 bytes
                      sizeof gdth_ioctl_general: 356 bytes
                      sizeof gdth_ioctl_event: 308 bytes
                      sizeof gdth_ioctl_lockdrv: 204 bytes
                      sizeof gdth_ioctl_rescan: 406 bytes
      
      ###
      f512f4dd
    • Patrick Mansfield's avatar
      [PATCH] scsi-misc-2.5 fix repeat_inquiry bflags setting · ceb6a7fc
      Patrick Mansfield authored
      James -
      
      The new printk for BLIST_INQUIRY_36 is getting a warning, and the
      repeat_inquiry code is not quite right, since we reset *bflags after
      getting the first INQUIRY.
      
      Get rid of the warning, change the or-ing of the bflags settings, and get
      rid of an extraneous BUG_ON.
      
      ===== drivers/scsi/scsi_scan.c 1.78 vs edited =====
      ceb6a7fc
    • Christoph Hellwig's avatar
      [PATCH] remove proc_print_scsidevice abuse from drivers · e07f4449
      Christoph Hellwig authored
      proc_print_scsidevice is used for the scsi device listing in
      /proc/scsi/scsi, but in addition two drivers (advansys and eata_pio)
      are using it to duplicate the same information in their proc_info
      method.  Remove that output and make the function static to
      scsi_proc.c.  Also remove proc_scsi from the public headers - it
      should really be private to the scsi midlayer but I don't think
      we can shange the sg procfs name anymore.
      e07f4449
  2. 22 Apr, 2003 14 commits
  3. 21 Apr, 2003 18 commits
  4. 22 Apr, 2003 2 commits
  5. 21 Apr, 2003 2 commits
    • Eli Carter's avatar
      [ARM PATCH] 1510/1: use a #define for asm jump address · e4877513
      Eli Carter authored
      Patch from Eli Carter
      
      # Mon Apr 21 11:11:41 CDT 2003 ejc@rnd-linux-c84
      # use-physoffset-define
      #
      # Use the PHYS_OFFSET #define instead of a hard-coded value.
      #
      # Diffed against linux-2.5.67-rmk1+1501-3+1506
      #
      #  arch/arm/boot/compressed/head-xscale.S |    2 +-
      #  1 files changed, 1 insertion(+), 1 deletion(-)
      #
      e4877513
    • Eli Carter's avatar
      [ARM PATCH] 1511/1: iop321 #define cleanup · b2ad716b
      Eli Carter authored
      Patch from Eli Carter
      
      # Mon Apr 21 11:20:06 CDT 2003 ejc@rnd-linux-c84
      # pci-io-mem-size-defines
      #
      # Rename the IOP321_PCI_WINDOW_SIZE #defines to use
      # IOP321_PCI_{IO,MEM}_{BASE,SIZE} instead.  This makes the #defines a bit more
      # consistent.  No functional change, though it does bring up the question of
      # whether res[].end should be BASE+SIZE-1 or BASE+SIZE.
      #
      # Diffed against linux-2.5.67-rmk1+1501-3+1506+1508-10
      #
      #  arch/arm/mach-iop3xx/iop321-pci.c    |    8 ++++----
      #  include/asm-arm/arch-iop3xx/iop321.h |   10 ++++------
      #  2 files changed, 8 insertions(+), 10 deletions(-)
      #
      b2ad716b