An error occurred fetching the project authors.
  1. 08 Aug, 2011 1 commit
  2. 21 Jul, 2011 1 commit
  3. 11 Jul, 2011 1 commit
  4. 01 Jun, 2011 1 commit
  5. 24 May, 2011 1 commit
  6. 16 May, 2011 1 commit
    • Stephen Boyd's avatar
      iwlwifi: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning · 805d7d23
      Stephen Boyd authored
      Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following
      warning:
      
      In file included from arch/x86/include/asm/uaccess.h:573,
                       from include/net/checksum.h:25,
                       from include/linux/skbuff.h:28,
                       from drivers/net/wireless/iwlwifi/iwl-agn-rs.c:28:
      In function 'copy_from_user',
          inlined from 'rs_sta_dbgfs_scale_table_write' at
          drivers/net/wireless/iwlwifi/iwl-agn-rs.c:3099:
      arch/x86/include/asm/uaccess_64.h:65:
      warning: call to 'copy_from_user_overflow' declared with
      attribute warning: copy_from_user() buffer size is not provably
      correct
      
      presumably due to buf_size being signed causing GCC to fail to
      see that buf_size can't become negative.
      Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
      Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      805d7d23
  7. 13 May, 2011 2 commits
  8. 07 Apr, 2011 2 commits
  9. 25 Mar, 2011 2 commits
    • Daniel Halperin's avatar
      iwlwifi: add RATE_MCS_RATE_MSK · 2520546a
      Daniel Halperin authored
      Throughout the code we use rate_n_flags & 0xff to extract the lower byte
      of the rate_n_flags u32 that contains the information about the rate.
      Add a #define and remove the use of the magic number.
      Signed-off-by: default avatarDaniel Halperin <dhalperi@cs.washington.edu>
      Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      2520546a
    • Daniel Halperin's avatar
      iwlwifi: limit number of attempts for highest HT rate · 374920cb
      Daniel Halperin authored
      When filling out its rate scale table, iwlwifi repeats the first HT rate
      IWL_HT_NUMBER_TRY times. The hardware scheduler will stop using
      aggregation for any frame that fails LINK_QUAL_AGG_DISABLE_START_DEF
      times. Currently, both these constants equal 3.
      
      If iwlwifi probes a faster rate than the link supports, all frames in a
      (potentially tens of frames large) batch will fail IWL_HT_NUMBER_TRY
      times. Because this happens to be as large as
      LINK_QUAL_AGG_DISABLE_START_DEF, all frames will then be sent
      individually. This leads to a short, but performance-degrading window
      where the legacy stop-and-wait MAC takes over.
      
      Bounding the initial rate by (LINK_QUAL_AGG_DISABLE_START_DEF-1)
      attempts makes the third try use a lower rate and hence more be likely
      to succeed. This somewhat mitigates the above described behavior.
      Signed-off-by: default avatarDaniel Halperin <dhalperi@cs.washington.edu>
      Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      374920cb
  10. 31 Jan, 2011 2 commits
  11. 16 Dec, 2010 1 commit
    • Sedat Dilek's avatar
      iwlwifi: Fix error: struct iwl_lq_sta has no member named dbg_fixed_rate · 7d5f01ad
      Sedat Dilek authored
      While compiling linux-next (next-20101216) I fell over this breakage:
      ...
      drivers/net/wireless/iwlwifi/iwl-agn-rs.c: In function ‘iwl_rs_rate_init’:
      drivers/net/wireless/iwlwifi/iwl-agn-rs.c:2876:8: error: ‘struct iwl_lq_sta’ has no member named ‘dbg_fixed_rate’
      
      dbg_fixed_rate is only used when CONFIG_MAC80211_DEBUGFS is set:
      
      [ drivers/net/wireless/iwlwifi/iwl-agn-rs.h ]
      ...
       #ifdef CONFIG_MAC80211_DEBUGFS
             struct dentry *rs_sta_dbgfs_scale_table_file;
             struct dentry *rs_sta_dbgfs_stats_table_file;
             struct dentry *rs_sta_dbgfs_rate_scale_data_file;
             struct dentry *rs_sta_dbgfs_tx_agg_tid_en_file;
             u32 dbg_fixed_rate;
       #endif
      
      The issue was introduced by commit a1da077b:
      "iwlwifi: clear dbg_fixed_rate during init"
      Signed-off-by: default avatarSedat Dilek <sedat.dilek@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      7d5f01ad
  12. 15 Dec, 2010 1 commit
  13. 13 Dec, 2010 1 commit
  14. 16 Nov, 2010 1 commit
  15. 15 Oct, 2010 1 commit
    • Arnd Bergmann's avatar
      llseek: automatically add .llseek fop · 6038f373
      Arnd Bergmann authored
      All file_operations should get a .llseek operation so we can make
      nonseekable_open the default for future file operations without a
      .llseek pointer.
      
      The three cases that we can automatically detect are no_llseek, seq_lseek
      and default_llseek. For cases where we can we can automatically prove that
      the file offset is always ignored, we use noop_llseek, which maintains
      the current behavior of not returning an error from a seek.
      
      New drivers should normally not use noop_llseek but instead use no_llseek
      and call nonseekable_open at open time.  Existing drivers can be converted
      to do the same when the maintainer knows for certain that no user code
      relies on calling seek on the device file.
      
      The generated code is often incorrectly indented and right now contains
      comments that clarify for each added line why a specific variant was
      chosen. In the version that gets submitted upstream, the comments will
      be gone and I will manually fix the indentation, because there does not
      seem to be a way to do that using coccinelle.
      
      Some amount of new code is currently sitting in linux-next that should get
      the same modifications, which I will do at the end of the merge window.
      
      Many thanks to Julia Lawall for helping me learn to write a semantic
      patch that does all this.
      
      ===== begin semantic patch =====
      // This adds an llseek= method to all file operations,
      // as a preparation for making no_llseek the default.
      //
      // The rules are
      // - use no_llseek explicitly if we do nonseekable_open
      // - use seq_lseek for sequential files
      // - use default_llseek if we know we access f_pos
      // - use noop_llseek if we know we don't access f_pos,
      //   but we still want to allow users to call lseek
      //
      @ open1 exists @
      identifier nested_open;
      @@
      nested_open(...)
      {
      <+...
      nonseekable_open(...)
      ...+>
      }
      
      @ open exists@
      identifier open_f;
      identifier i, f;
      identifier open1.nested_open;
      @@
      int open_f(struct inode *i, struct file *f)
      {
      <+...
      (
      nonseekable_open(...)
      |
      nested_open(...)
      )
      ...+>
      }
      
      @ read disable optional_qualifier exists @
      identifier read_f;
      identifier f, p, s, off;
      type ssize_t, size_t, loff_t;
      expression E;
      identifier func;
      @@
      ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off)
      {
      <+...
      (
         *off = E
      |
         *off += E
      |
         func(..., off, ...)
      |
         E = *off
      )
      ...+>
      }
      
      @ read_no_fpos disable optional_qualifier exists @
      identifier read_f;
      identifier f, p, s, off;
      type ssize_t, size_t, loff_t;
      @@
      ssize_t read_f(struct file *f, char *p, size_t s, loff_t *off)
      {
      ... when != off
      }
      
      @ write @
      identifier write_f;
      identifier f, p, s, off;
      type ssize_t, size_t, loff_t;
      expression E;
      identifier func;
      @@
      ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off)
      {
      <+...
      (
        *off = E
      |
        *off += E
      |
        func(..., off, ...)
      |
        E = *off
      )
      ...+>
      }
      
      @ write_no_fpos @
      identifier write_f;
      identifier f, p, s, off;
      type ssize_t, size_t, loff_t;
      @@
      ssize_t write_f(struct file *f, const char *p, size_t s, loff_t *off)
      {
      ... when != off
      }
      
      @ fops0 @
      identifier fops;
      @@
      struct file_operations fops = {
       ...
      };
      
      @ has_llseek depends on fops0 @
      identifier fops0.fops;
      identifier llseek_f;
      @@
      struct file_operations fops = {
      ...
       .llseek = llseek_f,
      ...
      };
      
      @ has_read depends on fops0 @
      identifier fops0.fops;
      identifier read_f;
      @@
      struct file_operations fops = {
      ...
       .read = read_f,
      ...
      };
      
      @ has_write depends on fops0 @
      identifier fops0.fops;
      identifier write_f;
      @@
      struct file_operations fops = {
      ...
       .write = write_f,
      ...
      };
      
      @ has_open depends on fops0 @
      identifier fops0.fops;
      identifier open_f;
      @@
      struct file_operations fops = {
      ...
       .open = open_f,
      ...
      };
      
      // use no_llseek if we call nonseekable_open
      ////////////////////////////////////////////
      @ nonseekable1 depends on !has_llseek && has_open @
      identifier fops0.fops;
      identifier nso ~= "nonseekable_open";
      @@
      struct file_operations fops = {
      ...  .open = nso, ...
      +.llseek = no_llseek, /* nonseekable */
      };
      
      @ nonseekable2 depends on !has_llseek @
      identifier fops0.fops;
      identifier open.open_f;
      @@
      struct file_operations fops = {
      ...  .open = open_f, ...
      +.llseek = no_llseek, /* open uses nonseekable */
      };
      
      // use seq_lseek for sequential files
      /////////////////////////////////////
      @ seq depends on !has_llseek @
      identifier fops0.fops;
      identifier sr ~= "seq_read";
      @@
      struct file_operations fops = {
      ...  .read = sr, ...
      +.llseek = seq_lseek, /* we have seq_read */
      };
      
      // use default_llseek if there is a readdir
      ///////////////////////////////////////////
      @ fops1 depends on !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      identifier readdir_e;
      @@
      // any other fop is used that changes pos
      struct file_operations fops = {
      ... .readdir = readdir_e, ...
      +.llseek = default_llseek, /* readdir is present */
      };
      
      // use default_llseek if at least one of read/write touches f_pos
      /////////////////////////////////////////////////////////////////
      @ fops2 depends on !fops1 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      identifier read.read_f;
      @@
      // read fops use offset
      struct file_operations fops = {
      ... .read = read_f, ...
      +.llseek = default_llseek, /* read accesses f_pos */
      };
      
      @ fops3 depends on !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      identifier write.write_f;
      @@
      // write fops use offset
      struct file_operations fops = {
      ... .write = write_f, ...
      +	.llseek = default_llseek, /* write accesses f_pos */
      };
      
      // Use noop_llseek if neither read nor write accesses f_pos
      ///////////////////////////////////////////////////////////
      
      @ fops4 depends on !fops1 && !fops2 && !fops3 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      identifier read_no_fpos.read_f;
      identifier write_no_fpos.write_f;
      @@
      // write fops use offset
      struct file_operations fops = {
      ...
       .write = write_f,
       .read = read_f,
      ...
      +.llseek = noop_llseek, /* read and write both use no f_pos */
      };
      
      @ depends on has_write && !has_read && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      identifier write_no_fpos.write_f;
      @@
      struct file_operations fops = {
      ... .write = write_f, ...
      +.llseek = noop_llseek, /* write uses no f_pos */
      };
      
      @ depends on has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      identifier read_no_fpos.read_f;
      @@
      struct file_operations fops = {
      ... .read = read_f, ...
      +.llseek = noop_llseek, /* read uses no f_pos */
      };
      
      @ depends on !has_read && !has_write && !fops1 && !fops2 && !has_llseek && !nonseekable1 && !nonseekable2 && !seq @
      identifier fops0.fops;
      @@
      struct file_operations fops = {
      ...
      +.llseek = noop_llseek, /* no read or write fn */
      };
      ===== End semantic patch =====
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Cc: Julia Lawall <julia@diku.dk>
      Cc: Christoph Hellwig <hch@infradead.org>
      6038f373
  16. 07 Oct, 2010 2 commits
  17. 06 Oct, 2010 1 commit
    • Wey-Yi Guy's avatar
      iwlagn: reduce redundant parameter definitions · 7cb1b088
      Wey-Yi Guy authored
      move paramater definitions to a device paramater structure only
      leaving the device name, which antennas are used and what firmware
      file to use in the iwl_cfg structure.  this will not completely
      remove the redundancies but greatly reduce them for devices that
      only vary by name or antennas.  the parameters that are more
      likely to change within a given device family are left in iwl_cfg.
      also separate bt param structure added to help reduce more.
      Signed-off-by: default avatarJay Sternberg <jay.e.sternberg@intel.com>
      Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      7cb1b088
  18. 27 Aug, 2010 1 commit
  19. 25 Aug, 2010 3 commits
    • Wey-Yi Guy's avatar
      iwlagn: set traffic load based on multiple factors · da5dbb97
      Wey-Yi Guy authored
      Current BT traffic load should based on the following conditions:
      
      1. BT On/Off status
      2. Channel announcement enable/disable
      3. Curren traffic load report from uCode
      
      Need to modify rate scale to down-grade from MIMO to SISO if detected
      high BT traffic load. Also need to make sure not using chain "B" with high
      BT traffic or if it is in "full concurrency" mode.
      Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      da5dbb97
    • Wey-Yi Guy's avatar
      iwlwifi: add bt full concurrency support · bee008b7
      Wey-Yi Guy authored
      Adding the bluetooth full concurrency support for WiFi/BT combo devices.
      
      Driver should configure uCode to operate in "full concurrency" mode (via
      LUT) if both conditions are met:
       - Antenna Coupling is more than 35dB
       - WiFi Channel Inhibition Request is hornored by BT Core
      
      Currently, there is no antenna coupling information provided by uCode;
      use module parameter to specified the antenna coupling in dB.
      
      When in "full concurrency" mode, driver need to download different LUT
      to uCode while sending bt configuration command; also, driver need to
      configure the device operate in 1x1 while in full concurrency mode.
      Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      bee008b7
    • Johannes Berg's avatar
      iwlagn: let bluetooth traffic load impact rate scale · 290f599c
      Johannes Berg authored
      Depending on the amount of bluetooth traffic,
      using the shared antenna (antenna B) will have
      adverse impact on both bluetooth and wireless
      traffic. Add controls to improve the situation
      by making rate scaling depend on the BT load.
      
      When there's high bluetooth traffic load, there's
      little point in trying to aggregate as BT traffic
      would disrupt the aggregated frames all the time,
      so simply don't start sessions then.
      
      When BT traffic returns to lower levels, the rate
      scaling will come here again automatically when
      wifi traffic is high enough, and then it will be
      able to successfully enable aggregation.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      290f599c
  20. 24 Aug, 2010 3 commits
  21. 04 Aug, 2010 1 commit
  22. 25 Jun, 2010 1 commit
  23. 03 Jun, 2010 1 commit
  24. 14 May, 2010 1 commit
    • Joe Perches's avatar
      drivers/net: Remove unnecessary returns from void function()s · a4b77097
      Joe Perches authored
      This patch removes from drivers/net/ all the unnecessary
      return; statements that precede the last closing brace of
      void functions.
      
      It does not remove the returns that are immediately
      preceded by a label as gcc doesn't like that.
      
      It also does not remove null void functions with return.
      
      Done via:
      $ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
        xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'
      
      with some cleanups by hand.
      
      Compile tested x86 allmodconfig only.
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a4b77097
  25. 04 May, 2010 1 commit
  26. 30 Apr, 2010 1 commit
    • Daniel Halperin's avatar
      iwlwifi: set AMPDU status variables correctly · e3a3cd87
      Daniel Halperin authored
      The TX status code is currently abusing the ampdu_ack_map field (a bitmap) to
      count the number of successfully received frames.  The comments in mac80211.h
      show there are actually three different, relevant variables, of which we are
      currently using two, both incorrectly. Fix this by making
      
      - ampdu_ack_len -> the number of ACKed frames (i.e. successes)
      - ampdu_ack_map -> the bitmap
      - ampdu_len -> the total number of frames sent (i.e., attempts)
      
      to match the header file (and verified with ath9k's usage) and updating Intel's
      RS code to match.
      Signed-off-by: default avatarDaniel Halperin <dhalperi@cs.washington.edu>
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      e3a3cd87
  27. 16 Apr, 2010 2 commits
    • Wey-Yi Guy's avatar
      iwlwifi: sanity check for turn on aggregation tid · 82ca9341
      Wey-Yi Guy authored
      Perform sanity check for turn on aggregation tid. Also remove the
      option for turn on all the aggregation tids at once since it is
      deprecated function and not being used.
      Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      82ca9341
    • Wey-Yi Guy's avatar
      iwlwifi: set correct single/dual stream mask · 3a23d695
      Wey-Yi Guy authored
      Even the initial single/dual stream values will be overridden later when
      issue link quality command; but still make sense not to use hard-code
      value during initialization. Single/Dual stream mask are used to indicate the
      best antenna for SISO/MIMO; different NIC has different tx antenna
      configuration; so the parameter need to based on the valid tx antenna.
      
      1x2 device: single tx antenna available, only SISO is valid
      configuration, but still need to set up MIMO configuration, so set it up
      with antenna A & B as default.
      2x2 device: two tx antenna available, dual_stream will use both valid
      antenna.
      
      3x3 device: three tx antenna available, skip the first antenna and
      choice the second and third antenna for dual_stream.
      Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      3a23d695
  28. 09 Apr, 2010 1 commit
    • Reinette Chatre's avatar
      iwlwifi: fix compile warnings when compiling without debug · f875f518
      Reinette Chatre authored
      Fixes:
      CC [M]  drivers/net/wireless/iwlwifi/iwl-agn-rs.o
      drivers/net/wireless/iwlwifi/iwl-agn-rs.c: In function ‘rs_get_rate’:
      drivers/net/wireless/iwlwifi/iwl-agn-rs.c:2419: warning: unused variable ‘priv’
      CC [M]  drivers/net/wireless/iwlwifi/iwl-sta.o
      drivers/net/wireless/iwlwifi/iwl-sta.c: In function ‘iwl_send_add_sta’:
      drivers/net/wireless/iwlwifi/iwl-sta.c:197: warning: unused variable ‘sta_id’
      
      drivers/net/wireless/iwlwifi/iwl-3945.c: In function ‘iwl3945_rx_reply_rx’:
      drivers/net/wireless/iwlwifi/iwl-3945.c:601: warning: unused variable ‘rx_stats_noise_diff’
      drivers/net/wireless/iwlwifi/iwl-3945.c:600: warning: unused variable ‘rx_stats_sig_avg’
      drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function ‘rs_get_rate’:
      drivers/net/wireless/iwlwifi/iwl-3945-rs.c:650: warning: unused variable ‘priv’
      Reported-by: default avatarLuis R. Rodriguez <lrodriguez@atheros.com>
      Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
      f875f518
  29. 02 Apr, 2010 2 commits