- 13 Nov, 2013 40 commits
-
-
Joe Perches authored
Avoid prescribing kernel styled shortcuts for gcc extensions of __attribute__((foo)) in the uapi include paths. Fix $realfile filename when using -f/--file to not remove first level directory as if the filename was used in a -P1 patch. Only strip the first level directory (typically a or b) for P1 patches. Signed-off-by:
Joe Perches <joe@perches.com> Cc: "Dixit, Ashutosh" <ashutosh.dixit@intel.com> Cc: Andy Whitcroft <apw@canonical.com> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
Joe Perches authored
Find a few more cases where parentheses are used around the value of a return statement. This now uses the "$balanced_parens" test and also makes the test depend on perl v5.10 and higher. This now finds return with parenthesis uses the old code did not find like: ERROR: return is not a function, parentheses are not required #211: FILE: arch/m68k/include/asm/sun3xflop.h:211: + return ((error == 0) ? 0 : -1); Signed-off-by:
David Cohen <david.a.cohen@linux.intel.com> Acked-by:
-
Josh Triplett authored
Kernel maintainers reject new instances of the GPL boilerplate paragraph directing people to write to the FSF for a copy of the GPL, since the FSF has moved in the past and may do so again. Make this an error for new code, but just a --strict CHK in --file mode; anyone interested in doing tree-wide cleanups of this form can enable this test explicitly. Signed-off-by:
Josh Triplett <josh@joshtriplett.org> Acked-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by:
-
Joe Perches authored
Peter Zijlstra prefers that comments be required near uses of memory barriers. Change the message level for memory barrier uses from a --strict test only to a normal WARN so it's always emitted. This might produce false positives around insertions of memory barriers when a comment is outside the patch context block. And checkpatch is still stupid, it only looks for existence of any comment, not at the comment content. Signed-off-by:
Peter Zijlstra <peterz@infradead.org> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: Oliver Neukum <oliver@neukum.org> Signed-off-by:
-
Joe Perches authored
People get this regularly wrong and it breaks the LTO builds, as it causes a section attribute conflict. Add --fix capability too. Based on a patch from Andi Kleen. Signed-off-by:
-
Joe Perches authored
Add a test for these #defines Additionally, moved string_find_replace sub as it screws up subsequent formatting when placed inside another sub. Signed-off-by:
-
Joe Perches authored
Checkpatch doesn't currently find CamelCase definitions of structs, unions or enums. Add that ability. Signed-off-by:
-
Joe Perches authored
seq_vprintf, seq_printf and seq_puts are logging functions and should be allowed to exceed the maximium line length. Add maximum line length exceptions for these functions. Also, suggesting seq_printf conversions to seq_puts should be tested for arguments after the format. Signed-off-by:
-
Joe Perches authored
Extend the CamelCase words found to include structure members. In https://lkml.org/lkml/2013/9/3/318 Sarah Sharp (mostly) wrote: "In general, if checkpatch.pl complains about a variable a patch introduces that's CamelCase, you should pay attention to it. Otherwise, [] ignore it." So, if checking a patch, scan the original patched file if it's available and add any preexisting CamelCase types so reuses do not generate CamelCase messages. That also means Andrew's not so cruelly spurned anymore. https://lkml.org/lkml/2013/2/22/426Signed-off-by:
Sarah Sharp <sarah.a.sharp@linux.intel.com> Suggested-by:
-
Joe Perches authored
Spaces around trigraphs are specified by CodingStyle but checkpatch is currently silent about them because there are many current instances without them. Make missing spaces around trigraphs a --strict message. Signed-off-by:
-
Oleg Nesterov authored
Change debugfs_remove_recursive() to use list_next_entry(child), no changes in generated code. Signed-off-by:
Oleg Nesterov <oleg@redhat.com> Cc: Eilon Greenstein <eilong@broadcom.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Signed-off-by:
-
Oleg Nesterov authored
We already have list_first_entry(), it makes sense to also add list_last_entry() for consistency. And we use both helpers in list_for_each_*(). Signed-off-by:
-
Oleg Nesterov authored
Now that we have list_{next,prev}_entry() we can change list_for_each_entry*() and list_safe_reset_next() to use the new helpers to improve the readability. Signed-off-by: -
Oleg Nesterov authored
Add two trivial helpers list_next_entry() and list_prev_entry(), they can have a lot of users including list.h itself. In fact the 1st one is already defined in events/core.c and bnx2x_sp.c, so the patch simply moves the definition to list.h. Signed-off-by:
-
Nicolin Chen authored
Since gen_pool_dma_alloc() is introduced, we implement it to simplify code. Signed-off-by:
Nicolin Chen <b42378@freescale.com> Cc: Eric Miao <eric.y.miao@gmail.com> Cc: Russell King <linux@arm.linux.org.uk> Cc: Haojian Zhuang <haojian.zhuang@gmail.com> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Signed-off-by:
-
Nicolin Chen authored
Since gen_pool_dma_alloc() is introduced, we implement it to simplify code. Signed-off-by:
-
Nicolin Chen authored
Since gen_pool_dma_alloc() is introduced, we implement it to simplify code. Signed-off-by:
-
Nicolin Chen authored
Since gen_pool_dma_alloc() is introduced, we implement it to simplify code. Signed-off-by:
Mauro Carvalho Chehab <m.chehab@samsung.com> Cc: Grant Likely <grant.likely@linaro.org> Cc: Rob Herring <rob.herring@calxeda.com> Signed-off-by:
-
Nicolin Chen authored
Since gen_pool_dma_alloc() is introduced, we implement it to simplify code. Signed-off-by:
-
Nicolin Chen authored
Since gen_pool_dma_alloc() is introduced, we implement it to simplify code. Signed-off-by:
-
Nicolin Chen authored
When using pool space for DMA buffer, there might be duplicated calling of gen_pool_alloc() and gen_pool_virt_to_phys() in each implementation. Thus it's better to add a simple helper function, a compatible one to the common dma_alloc_coherent(), to save some code. Signed-off-by:
-
Duan Jiong authored
Signed-off-by:
Duan Jiong <duanj.fnst@cn.fujitsu.com> Cc: James Morris <james.l.morris@oracle.com> Signed-off-by:
-
Olof Johansson authored
Looks like these were added to Documentation/printk-formats.txt but not the in-file table. Signed-off-by:
Olof Johansson <olof@lixom.net> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by:
-
Xie XiuQi authored
Remove unnecessary work pending test before calling schedule_work(). It has been tested in queue_work_on() already. No functional changed. Signed-off-by:
Xie XiuQi <xiexiuqi@huawei.com> Reviewed-by:
Tejun Heo <tj@kernel.org> Signed-off-by:
-
Cody P Schafer authored
Add return value documentation and clarify the units of the @size parameter. Signed-off-by:
Cody P Schafer <cody@linux.vnet.ibm.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Cody P Schafer <cody@linux.vnet.ibm.com> Signed-off-by:
-
Sachin Kamat authored
'hx8357_dt_ids' is always compiled in. Hence of_match_ptr is not needed. Signed-off-by:
Sachin Kamat <sachin.kamat@linaro.org> Acked-by:
Maxime Ripard <maxime.ripard@free-electrons.com> Acked-by:
Jingoo Han <jg1.han@samsung.com> Signed-off-by:
-
Johan Hovold authored
Use devm_gpio_request_one rather than requesting and setting direction in two calls. Signed-off-by:
Johan Hovold <jhovold@gmail.com> Cc: Jingoo Han <jg1.han@samsung.com> Signed-off-by:
-
Johan Hovold authored
Add helper function to control the gpio_on signal. Signed-off-by:
-
Johan Hovold authored
Use gpio_is_valid rather than open coding the more restrictive != -1 test. Signed-off-by:
-
Johan Hovold authored
Remove unused include of clk.h. Signed-off-by:
-
Johan Hovold authored
Clean up get_intensity to increase readability. Signed-off-by:
-
Johan Hovold authored
Clean up probe error handling by checking parameters before any allocations and removing an obsolete error label. Also remove unnecessary reset of private gpio number. Signed-off-by:
-
Johan Hovold authored
Add missing module alias which is needed for module autoloading. Signed-off-by:
-
Johan Hovold authored
Make sure to honour gpio polarity also at remove so that the backlight is actually disabled on boards with active-low enable pin. Signed-off-by:
-
Johan Hovold authored
The driver supports 16-bit brightness values, but the value returned from get_brightness was truncated to eight bits. Signed-off-by:
-
Wei Yongjun authored
drivers/video/backlight/lm3630a_bl.c: add missing destroy_workqueue() on error in lm3630a_intr_config() Add the missing destroy_workqueue() before return from lm3630a_intr_config() in the error handling case. Signed-off-by:
Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by:
-
Jingoo Han authored
Use devm_backlight_device_register() and devm_lcd_device_register() to make cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
Use devm_backlight_device_register() and devm_lcd_device_register() to make cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
Use devm_backlight_device_register() and devm_lcd_device_register() to make cleanup paths simpler. Signed-off-by:
-
Jingoo Han authored
Use devm_backlight_device_register() and devm_lcd_device_register() to make cleanup paths simpler. Signed-off-by:
-
