1. 08 Oct, 2018 8 commits
    • Ayala Beker's avatar
      iwlwifi: mvm: use fast balance scan in case of DCM mode with P2P GO · 2ec3ef46
      Ayala Beker authored
      Currently in case of DCM with P2P GO where BSS DTIM interval < 220 msec
      the fw fails to allocate events for the P2P GO dtim due to long passive
      scan events.
      
      Fix this by requesting all scans in this scenario to be fragmented with
      fast balance scan time settings.  The only exception is in case
      fragmented scan was planned to be set due to low latency or high
      throughput reason, set the scan timing as planned.
      Signed-off-by: default avatarAyala Beker <ayala.beker@intel.com>
      Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
      2ec3ef46
    • Ayala Beker's avatar
      iwlwifi: mvm: introduce a new fragmented scan type: fast balance · 6ff80f18
      Ayala Beker authored
      Fast balance scan is similar to SCAN_TYPE_MILD, but this scan is
      fragmented and has shorter out of operating channel time,
      and therefore better match low latency scenarios.
      Signed-off-by: default avatarAyala Beker <ayala.beker@intel.com>
      Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
      6ff80f18
    • Sara Sharon's avatar
      iwlwifi: trace: change trace to trace one TB at a time · bf77ee2e
      Sara Sharon authored
      Split TX tracing to be per TB. This is needed now that
      AMSDUs can be sent and skb can be larger than trace
      limit.
      Signed-off-by: default avatarSara Sharon <sara.sharon@intel.com>
      Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
      bf77ee2e
    • Sara Sharon's avatar
      iwlwifi: pcie: don't pad AMSDU packets · ea74b19d
      Sara Sharon authored
      When we TX AMSDU, we shouldn't pad the packet. In the past,
      we were building AMSDU only in transport layer, and gen2
      functions are built based on this. However, now that op mode
      may build AMSDUs, we need to take care of padding also in
      gen2 "non-pcie-amsdu" path.
      Signed-off-by: default avatarSara Sharon <sara.sharon@intel.com>
      Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
      ea74b19d
    • Sara Sharon's avatar
      iwlwifi: mvm: don't send keys when entering D3 · 8c7fd6a3
      Sara Sharon authored
      In the past, we needed to program the keys when entering D3. This was
      since we replaced the image. However, now that there is a single
      image, this is no longer needed.  Note that RSC is sent separately in
      a new command.  This solves issues with newer devices that support PN
      offload. Since driver re-sent the keys, the PN got zeroed and the
      receiver dropped the next packets, until PN caught up again.
      Signed-off-by: default avatarSara Sharon <sara.sharon@intel.com>
      Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
      8c7fd6a3
    • Tonghao Zhang's avatar
      abf1a08f
    • Leslie Monis's avatar
      net: sched: pie: fix coding style issues · ac4a02c5
      Leslie Monis authored
      Fix 5 warnings and 14 checks issued by checkpatch.pl:
      
      CHECK: Logical continuations should be on the previous line
      +	if ((q->vars.qdelay < q->params.target / 2)
      +	    && (q->vars.prob < MAX_PROB / 5))
      
      WARNING: line over 80 characters
      +		q->params.tupdate = usecs_to_jiffies(nla_get_u32(tb[TCA_PIE_TUPDATE]));
      
      CHECK: Blank lines aren't necessary after an open brace '{'
      +{
      +
      
      CHECK: braces {} should be used on all arms of this statement
      +			if (qlen < QUEUE_THRESHOLD)
      [...]
      +			else {
      [...]
      
      CHECK: Unbalanced braces around else statement
      +			else {
      
      CHECK: No space is necessary after a cast
      +	if (delta > (s32) (MAX_PROB / (100 / 2)) &&
      
      CHECK: Unnecessary parentheses around 'qdelay == 0'
      +	if ((qdelay == 0) && (qdelay_old == 0) && update_prob)
      
      CHECK: Unnecessary parentheses around 'qdelay_old == 0'
      +	if ((qdelay == 0) && (qdelay_old == 0) && update_prob)
      
      CHECK: Unnecessary parentheses around 'q->vars.prob == 0'
      +	if ((q->vars.qdelay < q->params.target / 2) &&
      +	    (q->vars.qdelay_old < q->params.target / 2) &&
      +	    (q->vars.prob == 0) &&
      +	    (q->vars.avg_dq_rate > 0))
      
      CHECK: Unnecessary parentheses around 'q->vars.avg_dq_rate > 0'
      +	if ((q->vars.qdelay < q->params.target / 2) &&
      +	    (q->vars.qdelay_old < q->params.target / 2) &&
      +	    (q->vars.prob == 0) &&
      +	    (q->vars.avg_dq_rate > 0))
      
      CHECK: Blank lines aren't necessary before a close brace '}'
      +
      +}
      
      CHECK: Comparison to NULL could be written "!opts"
      +	if (opts == NULL)
      
      CHECK: No space is necessary after a cast
      +			((u32) PSCHED_TICKS2NS(q->params.target)) /
      
      WARNING: line over 80 characters
      +	    nla_put_u32(skb, TCA_PIE_TUPDATE, jiffies_to_usecs(q->params.tupdate)) ||
      
      CHECK: Blank lines aren't necessary before a close brace '}'
      +
      +}
      
      CHECK: No space is necessary after a cast
      +		.delay		= ((u32) PSCHED_TICKS2NS(q->vars.qdelay)) /
      
      WARNING: Missing a blank line after declarations
      +	struct sk_buff *skb;
      +	skb = qdisc_dequeue_head(sch);
      
      WARNING: Missing a blank line after declarations
      +	struct pie_sched_data *q = qdisc_priv(sch);
      +	qdisc_reset_queue(sch);
      
      WARNING: Missing a blank line after declarations
      +	struct pie_sched_data *q = qdisc_priv(sch);
      +	q->params.tupdate = 0;
      Signed-off-by: default avatarLeslie Monis <lesliemonis@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ac4a02c5
    • Gustavo A. R. Silva's avatar
      bnxt_en: Remove unnecessary unsigned integer comparison and initialize variable · 5fc7c12f
      Gustavo A. R. Silva authored
      There is no need to compare *val.vu32* with < 0 because
      such variable is of type u32 (32 bits, unsigned), making it
      impossible to hold a negative value. Fix this by removing
      such comparison.
      
      Also, initialize variable *max_val* to -1, just in case
      it is not initialized to either BNXT_MSIX_VEC_MAX or
      BNXT_MSIX_VEC_MIN_MAX before using it in a comparison
      with val.vu32 at line 159:
      
      	if (val.vu32 > max_val)
      
      Addresses-Coverity-ID: 1473915 ("Unsigned compared against 0")
      Addresses-Coverity-ID: 1473920 ("Uninitialized scalar variable")
      Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5fc7c12f
  2. 07 Oct, 2018 1 commit
    • David S. Miller's avatar
      Merge tag 'wireless-drivers-next-for-davem-2018-10-07' of... · 5057ef7f
      David S. Miller authored
      Merge tag 'wireless-drivers-next-for-davem-2018-10-07' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next
      
      Kalle Valo says:
      
      ====================
      wireless-drivers-next patches for 4.20
      
      Second set of patches for 4.20. Heavy refactoring on mt76 continues
      and the usual drivers in active development (iwlwifi, qtnfmac, ath10k)
      getting new features. And as always, fixes and cleanup all over.
      
      Major changes:
      
      mt76
      
      * more major refactoring to make it easier add new hardware support
      
      * more work on mt76x0e support
      
      * support for getting firmware version via ethtool
      
      * add mt7650 PCI ID
      
      iwlwifi
      
      * HE radiotap cleanup and improvements
      
      * reorder channel optimization for scans
      
      * bump the FW API version
      
      qtnfmac
      
      * fixes for 'iw' output: rates for enabled SGI, 'dump station'
      
      * expose more scan features to host: scan flush and dwell time
      
      * inform cfg80211 when OBSS is not supported by firmware
      
      wlcore
      
      * add support for optional wakeirq
      
      ath10k
      
      * retrieve MAC address from system firmware if provided
      
      * support extended board data download for dual-band QCA9984
      
      * extended per sta tx statistics support via debugfs
      
      * average ack rssi support for data frames
      
      * speed up QCA6174 and QCA9377 firmware download using diag Copy
        Engine
      
      * HTT High Latency mode support needed by SDIO and USB support
      
      * get STA power save state via debugfs
      
      ath9k
      
      * add reset functionality for airtime station debugfs file
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5057ef7f
  3. 06 Oct, 2018 31 commits