An error occurred fetching the project authors.
- 03 Jan, 2008 1 commit
-
-
David Dillow authored
Add a missing call to srp_remove_host() in srp_remove_one() so that we don't leak SRP transport class list entries. Tested-by:
David Dillow <dillowda@ornl.gov> Acked-by:
FUJITA Tomonori <tomof@acm.org> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 12 Oct, 2007 2 commits
-
-
FUJITA Tomonori authored
This adds a 'roles' attribute to rport like transport_fc. The role can be initiator or target. That is, the initiator driver creates target remote ports and the target driver creates initiator remote ports. Signed-off-by:
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> Signed-off-by:
Mike Christie <michaelc@cs.wisc.edu> Signed-off-by:
James Bottomley <James.Bottomley@SteelEye.com>
-
FUJITA Tomonori authored
This converts ib_srp to use the srp transport class. I don't have ib hardware so I've not tested this patch. Signed-off-by:
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> Cc: Roland Dreier <rolandd@cisco.com> Signed-off-by:
James Bottomley <James.Bottomley@SteelEye.com>
-
- 10 Oct, 2007 1 commit
-
-
Sean Hefty authored
Provide the target service ID when performing a path record query to support optional QoS capability. QoS requires support from the SA. Signed-off-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 03 Aug, 2007 2 commits
-
-
Raghava Kondapalli authored
New Cisco IB SRP targets use the Cisco OUI 00-1b-0d but still need the Topspin workarounds. Add this OUI to srp_target_is_topspin(). Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Roland Dreier authored
Wrap the checking for Mellanox and Topspin OUIs to decide whether to use a workaround into helper functions. This will make it cleaner to add a new OUI to check (as we need to do now that some targets with a Cisco OUI still need the Topspin workarounds). Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 07 Jun, 2007 1 commit
-
-
FUJITA Tomonori authored
- remove the unnecessary map_single path. - convert to use the new accessors for the sg lists and the parameters. Jens Axboe <jens.axboe@oracle.com> did the for_each_sg cleanup. Signed-off-by:
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> Acked-by:
Roland Dreier <rdreier@cisco.com> Signed-off-by:
James Bottomley <James.Bottomley@SteelEye.com>
-
- 07 May, 2007 3 commits
-
-
Michael S. Tsirkin authored
Add a num_comp_vectors member to struct ib_device and extend ib_create_cq() to pass in a comp_vector parameter -- this parallels the userspace libibverbs API. Update all hardware drivers to set num_comp_vectors to 1 and have all ULPs pass 0 for the comp_vector value. Pass the value of num_comp_vectors to userspace rather than hard-coding a value of 1. We want multiple CQ event vector support (via MSI-X or similar for adapters that can generate multiple interrupts), but it's not clear how many vectors we want, or how we want to deal with policy issues such as how to decide which vector to use or how to set up interrupt affinity. This patch is useful for experimenting, since no core changes will be necessary when updating a driver to support multiple vectors, and we know that we want to make at least these changes anyway. Signed-off-by:
Michael S. Tsirkin <mst@dev.mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Roland Dreier authored
Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Ishai Rabinovitz authored
Add an orig_dgid attribute in sysfs for SRP scsi_hosts, so that userspace can tell what the original dgid value written to the add_target file was, even if the connection is redirected to a different port while connecting. Signed-off-by:
Ishai Rabinovitz <ishai@mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 04 Feb, 2007 1 commit
-
-
Ishai Rabinovitz authored
When there is a call to send_tsk_mgmt SRP posts a send and waits for 5 seconds to get a response. When the QP is in the error state it is obvious that there will be no response so it is quite useless to wait. In fact, the timeout causes SRP to wait a long time to reconnect when a QP error occurs. (Each abort and each reset_device calls send_tsk_mgmt, which waits for the timeout). The following patch solves this problem by identifying the failure and returning an immediate error code. Signed-off-by:
Ishai Rabinovitz <ishai@mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 23 Jan, 2007 1 commit
-
-
Ishai Rabinovitz authored
Checks if the kmalloc in match_strdup() was successful, and bail out on looking at the token if it failed. Signed-off-by:
Ishai Rabinovitz <ishai@mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 15 Dec, 2006 1 commit
-
-
Roland Dreier authored
struct srp_device.fmr_page_mask was unsigned long, which means that the top part of addresses above 4G was being chopped off on 32-bit architectures. Of course nothing good happens when data from SRP targets is DMAed to the wrong place. Fix this by changing fmr_page_mask to u64, to match the addresses actually used by IB devices. Thanks to Brian Cain <Brian.Cain@ge.com> and David McMillen <davem@systemfabricworks.com> for help diagnosing the bug and testing the fix. Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 12 Dec, 2006 1 commit
-
-
Ralph Campbell authored
Convert SRP to use the new verbs DMA mapping functions for kernel verbs consumers. Signed-off-by:
Ralph Campbell <ralph.campbell@qlogic.com> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 29 Nov, 2006 2 commits
-
-
Vu Pham authored
SRP reallocates the IU buffers for tx_ring and rx_ring without freeing the old buffers when it reconnects to a target. Fix this by keeping the old IU buffers around. Signed-off-by:
Vu Pham <vu@mellanox.com> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Arne Redlich authored
Set the Scsi_Host's max_cmd_len from 12 (default) to 16 for SRP. Otherwise scsi_dispatch_cmd() won't pass down certain commands such as READ CAPACITY 16, required for supporting disks > 2TB. Signed-off-by:
Arne Redlich <arne.redlich@xiranet.com> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 22 Nov, 2006 1 commit
-
-
David Howells authored
Fix up for make allyesconfig. Signed-Off-By:
David Howells <dhowells@redhat.com>
-
- 10 Oct, 2006 2 commits
-
-
Ishai Rabinovitz authored
Enable multiple concurrent connections to the same SRP target: 1) Use port GUID instead of node GUID in the initiator port identifier. This allows connections to be made from multiple HCA ports at the same time. 2) Let the user specify the identifier extention when adding the device. This allows userspace to make multiple connections even from the same port, if it wants too. Without this, only one connection can be made from any given HCA, even if it has multiple ports, because we don't use multi-channel mode, so targets will only allow one connection from a given initiator port ID. Signed-off-by:
Ishai Rabinovitz <ishai@mellanox.co.il> Signed-off-by:
Michael S. Tsirkin <mst@mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Ishai Rabinovitz authored
scsi_host_alloc() already allocates with kzalloc(), so the struct Scsi_Host is zeroed out, including the private data portion. Remove the redundant memset that zeros this out again in the SRP initiator. Signed-off-by:
Ishai Rabinovitz <ishai@mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 22 Sep, 2006 4 commits
-
-
Michael S. Tsirkin authored
Require users to register with SA module, to prevent the sa_query module text from going away while an SA query callback is still running. Update all in-tree users for the new interface. Signed-off-by:
Michael S. Tsirkin <mst@mellanox.co.il> Signed-off-by:
Sean Hefty <sean.hefty@intel.com> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Tom Tucker authored
Modifications to the existing rdma header files, core files, drivers, and ulp files to support iWARP, including: - Hook iWARP CM into the build system and use it in rdma_cm. - Convert enum ib_node_type to enum rdma_node_type, which includes the possibility of RDMA_NODE_RNIC, and update everything for this. Signed-off-by:
Tom Tucker <tom@opengridcomputing.com> Signed-off-by:
Steve Wise <swise@opengridcomputing.com> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Roland Dreier authored
Remove some trailing whitespace that has snuck in despite the best efforts of whitespace=error-all. Also fix a few other whitespace bogosities. Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Ishai Rabinovitz authored
Add local_ib_device and local_ib_port attributes to srp scsi_host. These are needed when we want to connect to the same target through multiple distinct ports. Signed-off-by:
Ishai Rabinovitz <ishai@mellanox.co.il> Signed-off-by:
Michael S. Tsirkin <mst@mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 14 Sep, 2006 1 commit
-
-
Ishai Rabinovitz authored
If there is a problem in the connection, the SCSI mid-layer will eventually call srp_reset_host(), which will call srp_reconnect(), so we do not need to schedule a call to srp_reconnect_work() from srp_completion(). Removing this prevents srp_reset_host() from failing if a reconnect scheduled from srp_completion() is already in progress, which in turn was causing crashes as both SCSI midlayer and srp_reconnect() were cancelling commands. Signed-off-by:
Ishai Rabinovitz <ishai@mellanox.co.il> Signed-off-by:
Michael S. Tsirkin <mst@mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 03 Aug, 2006 2 commits
-
-
Ishai Rabinovitz authored
Data corruption has been seen with Mellanox SRP targets when FMRs create a memory region with I/O virtual address != 0. Add a workaround that disables FMR merging for Mellanox targets (OUI 0002c9). Signed-off-by:
Ishai Rabinovitz <ishai@mellanox.co.il> Signed-off-by:
Michael S. Tsirkin <mst@mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Ishai Rabinovitz authored
Protect against srp_reset_device() clearing the req_queue while srp_reconnect_target() is in progress (note that state change at the top of srp_reconnect_target() is not sufficient for this since srp_reset_device() ignores the state). Signed-off-by:
Ishai Rabinovitz <ishai@mellanox.co.il> Signed-off-by:
Michael S. Tsirkin <mst@mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 15 Jul, 2006 2 commits
-
-
Michael S. Tsirkin authored
ib_fmr_pool_map_phys gets the virtual address by pointer but never writes there, and users (e.g. srp) seem to assume this and ignore the value returned. This patch cleans up the API to get the VA by value, and updates all users. Signed-off-by:
Michael S. Tsirkin <mst@mellanox.co.il> Acked-by:
Roland Dreier <rolandd@cisco.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
Vu Pham authored
srp_unmap_data assumes req->fmr is NULL if the request is not mapped, so we must clean it out in case of an error. Signed-off-by:
Vu Pham <vu@mellanox.com> Signed-off-by:
Michael S. Tsirkin <mst@mellanox.co.il> Acked-by:
Roland Dreier <rolandd@cisco.com> Cc: Roland Dreier <rolandd@cisco.com> Signed-off-by:
Andrew Morton <akpm@osdl.org> Signed-off-by:
Linus Torvalds <torvalds@osdl.org>
-
- 18 Jun, 2006 11 commits
-
-
Ishai Rabinovitz authored
Misc cleanups in ib_srp: 1) I think that it is more efficient to move the req entries from req_list to free_list in srp_reconnect_target (rather than rebuild the free_list). (In any case this code is shorter). 2) This allows us to reuse code in srp_reset_device and srp_reconnect_target and call a new function srp_reset_req. Signed-off-by:
Ishai Rabinovitz <ishai@mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Ramachandra K authored
There has been a change in the format of port identifiers between revision 10 of the SRP specification and the current revision 16A. Revision 10 specifies port identifier format as lower 8 bytes : GUID upper 8 bytes : Extension Whereas revision 16A specifies it as lower 8 bytes : Extension upper 8 bytes : GUID There are older targets (e.g. SilverStorm Virtual Fibre Channel Bridge) which conform to revision 10 of the SRP specification. The I/O class of revision 10 is 0xFF00 and the I/O class of revision 16A is 0x0100. For supporting older targets, this patch: 1) Adds a new optional target creation parameter "io_class". Default value of io_class is 0x0100 (i.e. revision 16A) 2) Uses the correct port identifier format for targets with IO class of 0xFF00 (i.e. conforming to revision 10) Signed-off-by:
Ramachandra K <rkuchimanchi@silverstorm.com> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Roland Dreier authored
It's perfectly valid for a connection to an SRP target to have a request limit of 0, so get rid of the message about it, which can spam kernel logs even with printk_ratelimit(). Keep a count of such events in a "zero_req_lim" SCSI host attribute instead, so someone who cares can look at the statistics. Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Ishai Rabinovitz authored
Handle IB_CM_DREQ_ERROR and IB_CM_DREQ_RECEIVED events from the CM, instead of just printing "Unhandled CM event". In the case of DREQ_ERROR, just ignore the event -- a TIMEWAIT_EXIT will be generated also. For DREQ_RECEIVED, send a DREP in response to shut the connection down cleanly. Signed-off-by:
Ishai Rabinovitz <ishai@mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Vu Pham authored
Make the sg_tablesize used by SRP adjustable at module load time via a module parameter. Calculate the corresponding IU length required to support this. Signed-off-by:
Vu Pham <vu@mellanox.com> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Vu Pham authored
Allow userspace to throttle traffic on a given connection to a target port by adding "max_cmd_per_lun=xyz" to lower the cmd_per_lun value set for that scsi_host. Signed-off-by:
Vu Pham <vu@mellanox.com> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Ishai Rabinovitz authored
Interrupts will always be enabled in srp_remove_one(), so spin_lock_irq() can be used instead of spin_lock_irqsave(). Also, the loop takes target->scsi_host->host_lock, so target->state can just be set to SRP_TARGET_REMOVED witout testing the old value. Signed-off-by:
Ishai Rabinovitz <ishai@mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Matthew Wilcox authored
The SRP driver never sleeps while holding target_mutex, and it's just used to protect some simple list operations, so hold times will be short. So just convert it to a spinlock, which is smaller and faster. Signed-off-by:
Matthew Wilcox <matthew@wil.cx> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Matthew Wilcox authored
list_for_each_entry_safe() is used in one place where the list isn't modified. So just change it to list_for_each_entry(). Signed-off-by:
Matthew Wilcox <matthew@wil.cx> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Matthew Wilcox authored
SCAN_WILD_CARD is indeed available from <scsi/scsi.h>, which is already included. So get rid of private hack. Signed-off-by:
Matthew Wilcox <matthew@wil.cx> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
Roland Dreier authored
Create an SRP FMR pool on HCAs that support FMRs, and use FMRs to map gather/scatter lists that have more than one entry into a single memory region that appears virtually contiguous to the SRP target (which is the RDMA initiator). This patch bails out on FMR mapping for SCSI commands where the gather/scatter list cannot be mapped into a single FMR because there are sub-page-sized entries in middle of the list. An unaligned start or end of the list is OK. Based on a patch by Vu Pham <vuhuong@mellanox.com>. Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-
- 17 May, 2006 1 commit
-
-
Ishai Rabinovitz authored
When flushing out queued commands after a successful device reset, make sure that SRP completes the right commands, instead of calling scsi_done on the command passed into the device reset handler over and over. Signed-off-by:
Ishai Rabinovitz <ishai@mellanox.co.il> Signed-off-by:
Roland Dreier <rolandd@cisco.com>
-