Commits · 318a5b2a505fe7a99f0d89889e7a84d57ec49b15 · nexedi / linux

11 May, 2010 40 commits

Staging: comedi: cb_pcidas64: fix up build warnings · 318a5b2a

Greg Kroah-Hartman authored May 05, 2010

Now that the 8255.h file is being included properly, we were
using the incorrect function prototypes, which causes a build
warning now.  This fixes it up and preserves the __iomem markings that
sparse wants to see.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

318a5b2a

Staging: comedi: 8255: fix up previous static markings. · c5efe58b

Greg Kroah-Hartman authored May 05, 2010

Ian pointed out that exported symbols should not be marked as static :)

Fixed this up by properly including the 8255.h file, and fixing
the function prototypes there, as the CONFIG variables were not getting
set so users of the header file were seeing the incorrect function
prototypes.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

c5efe58b

Staging: line6: driver: fix up sparse warnings · 1e18c0d5

Greg Kroah-Hartman authored May 04, 2010

minor stuff.

Cc: Markus Grabner <grabner@icg.tugraz.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1e18c0d5

Staging: iio: industrialio-trigger.c: minor fixups · 74112d3f

Greg Kroah-Hartman authored May 04, 2010

We needed to include a header file that declared the functions that are
being exported in this file.

Also fix up an indentation problem, and some sparse warnings.

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

74112d3f

Staging: iio: ring_sw.c: fix up sparse warnings · 19ca92e0

Greg Kroah-Hartman authored May 04, 2010

NULL usage, static stuff, etc.

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

19ca92e0

Staging: iio: industrialio-ring.c: fix up sparse warnings · 0deebb4f
Greg Kroah-Hartman authored May 04, 2010
```
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```
0deebb4f

Staging: iio: accel: fix up some sparse warnings. · 7cfce527

Greg Kroah-Hartman authored May 04, 2010

Minor stuff (static, NULL, etc.)

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

7cfce527

Staging: iio: trigger: fix up some global variables · d1d8abdb

Greg Kroah-Hartman authored May 04, 2010

These should be static.

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

d1d8abdb

Staging: iio: light: tsl2563: fix static sparse warning · 341713f2
Greg Kroah-Hartman authored May 04, 2010
```
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```
341713f2
Staging: iio: adc: max1363_ring.c: fix up sparse warnings · acbbfe23
Greg Kroah-Hartman authored May 04, 2010
```
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```
acbbfe23

Staging: iio: max1363_core: fix bug in kzalloc call · f03de82b

Greg Kroah-Hartman authored May 04, 2010

The operands were switched around :(

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

f03de82b

Staging: iio: adc: max1363_core: fix up some sparse warnings · 1b183e4b

Greg Kroah-Hartman authored May 04, 2010

Also fix a minor coding style issue.

Cc: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1b183e4b

Staging: iio: light trivial whitespace fix · cb6405b1

Jonathan Cameron authored May 04, 2010

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

cb6405b1

Staging: iio: accelerometers trivial checkpatch related fixes · 26de7208
Jonathan Cameron authored May 04, 2010
```
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```
26de7208
Staging: iio: Trivial - remove pointless semi colon (checkpatch found) · 5f87404d
Jonathan Cameron authored May 04, 2010
```
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```
5f87404d

Staging: hv: add basic ethtool support · f82f4ad7

Stephen Hemminger authored May 04, 2010

Ethtool allows querying device information and controlling parameters.
For now just add ability to turn on/off scatter/gather.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

f82f4ad7

Staging: hv: add transmit flow control · b220f5f9

Stephen Hemminger authored May 04, 2010

Keep track of the number of pages sent over transmit and stop
before going over.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

b220f5f9

Staging: hv: transmit scatter gather support · 6048718d

Stephen Hemminger authored May 04, 2010

The transmit management of pages was confusing for handling
fragmented SKB's. (But since NETIF_F_SG was never set, the code was never hit).

The parameter AdditionalRequestPageBufferCount is always one,
(and leads to ugly code), so just inline and add comments.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

6048718d

Staging: hv: use existing Ethernet header size · 9f8bd8ba

Stephen Hemminger authored May 04, 2010

Use ETH_ALEN to indicate that MAC address is Ethernet.
Also use Linux printk format for mac addresses.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

9f8bd8ba

Staging: hv: ring parameter · 450d7a4b

Stephen Hemminger authored May 04, 2010

The ring size parameter should be number of pages (not bytes).
Add module parameter information as well.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

450d7a4b

Staging: hv: cleanup network driver · 7880fc54

Stephen Hemminger authored May 04, 2010

Minor stuff:
   * Add module description
   * Remove variable set but never used.
   * Move variable inside conditional
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

7880fc54

Staging: comedi: hwdrv_apci3xxx.c: loads of sparse cleanups · 4e4b592c

Greg Kroah-Hartman authored May 04, 2010

__iomem pointer fixes, and static cleanups.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

4e4b592c

Staging: comedi: hwdrv_apci3501.h: make a variable static. · a6dc6d0d

Greg Kroah-Hartman authored May 04, 2010

Cleans up the sparse warning.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

a6dc6d0d

Staging: comedi: hwdrv_apci2032.c: static sparse fix · 88298013

Greg Kroah-Hartman authored May 04, 2010

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

88298013

Staging: comedi: hwdrv_apci1564.c: static sparse cleanups. · 0b437fc4

Greg Kroah-Hartman authored May 04, 2010

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

0b437fc4

Staging: comedi: hwdrv_apci1500.c: sparse static cleanups · a9435326

Greg Kroah-Hartman authored May 04, 2010

Mark a bunch of variables and functions as static.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

a9435326

Staging: comedi: hwdrv_apci1032.c: sparse warning fixups · 2179b4c8

Greg Kroah-Hartman authored May 04, 2010

Mark a variable as static.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

2179b4c8

Staging: comedi: hwdrv_apci035.h: fix sparse warnings · 1a538dfd

Greg Kroah-Hartman authored May 04, 2010

This let us delete two variables and mark one as static.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1a538dfd

Staging: comedi: hwdrv_apci035.c: fix sparse warnings · 08b93e7b

Greg Kroah-Hartman authored May 04, 2010

Some variables should be static.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

08b93e7b

Staging: comedi: adl_pci9111.c: fix sparse warnings · 525d1b13

Greg Kroah-Hartman authored May 04, 2010

divisor and other problems fixed.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

525d1b13

Staging: comedi: adl_pci9118.c: fix unsigned problem with divisors · 5f35f3f1

Greg Kroah-Hartman authored May 04, 2010

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

5f35f3f1

Staging: comedi: adv_pci1710.c: fix unsigned problem with divisors · a8cb9ad9

Greg Kroah-Hartman authored May 04, 2010

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

a8cb9ad9

Staging: comedi: amplc_dio200.c: fix NULL sparse warnings · a7f22a84

Greg Kroah-Hartman authored May 04, 2010

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

a7f22a84

Staging: comedi: cb_pcidas64.c: fix sparse warnings · f31d0008

Greg Kroah-Hartman authored May 04, 2010

This fixes a bunch of iomem and other sparse warnings.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

f31d0008

Staging: comedi: das1800.c: fix a locking error on the error path. · d18c5906

Greg Kroah-Hartman authored May 04, 2010

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

d18c5906

Staging: comedi: plx9080.h: properly mark iomem variables · b74a9670

Greg Kroah-Hartman authored May 04, 2010

It's a __iomem *, so mark it as such.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

b74a9670

Staging: comedi: quatech_daqp_cs.c: fix up the irq · e3752a1d

Greg Kroah-Hartman authored May 04, 2010

The irq needs to return the correct type.  Also fix up some other
sparse warnings that were found.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

e3752a1d

Staging: comedi: addi_amcc_s5933.h: sparse cleanup · ad2d4714

Greg Kroah-Hartman authored May 04, 2010

Mark a variable static that does not need to be global.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

ad2d4714

Staging: comedi: addi_common.c: sparse cleanups · 2f78c642

Greg Kroah-Hartman authored May 04, 2010

Now that we are properly marking the variable as __iomem, don't
cast it.

Also fix up some other sparse warnings.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

2f78c642

Staging: comedi: addi_common.h: properly mark this variable as __iomem · 6dd22814

Greg Kroah-Hartman authored May 04, 2010

It's not an unsigned long, it's a __iomem pointer, so mark it as
such.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

6dd22814