An error occurred fetching the project authors.
  1. 21 Mar, 2019 3 commits
  2. 15 Dec, 2018 2 commits
  3. 02 Nov, 2018 2 commits
    • Len Brown's avatar
      tools/power turbostat: reduce debug output · 0ec712e3
      Len Brown authored
      A recent turbostat release increased topo.max_cpu_num
      to make it convenient to handle sysfs bitmaps of 32-cpus.
      
      But users, who regularly make use of "--debug", then saw a bunch of output
      for cpus that were not present.
      
      Remove that extra output by checking a cpu is online before dumping its info.
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      Cc: Prarit Bhargava <prarit@redhat.com>
      0ec712e3
    • Len Brown's avatar
      tools/power turbosat: fix AMD APIC-id output · 34041551
      Len Brown authored
      turbostat recently gained a feature adding APIC and X2APIC columns.
      While they are disabled by-default, they are enabled with --debug
      or when explicitly requested, eg.
      
      $ sudo turbostat --quiet --show Package,Node,Core,CPU,APIC,X2APIC date
      
      But these columns erroneously showed zeros on AMD hardware.
      This patch corrects the APIC and X2APIC [sic] columns on AMD.
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      34041551
  4. 02 Oct, 2018 1 commit
    • Peter Zijlstra's avatar
      x86/cpu: Sanitize FAM6_ATOM naming · f2c4db1b
      Peter Zijlstra authored
      Going primarily by:
      
        https://en.wikipedia.org/wiki/List_of_Intel_Atom_microprocessors
      
      with additional information gleaned from other related pages; notably:
      
       - Bonnell shrink was called Saltwell
       - Moorefield is the Merriefield refresh which makes it Airmont
      
      The general naming scheme is: FAM6_ATOM_UARCH_SOCTYPE
      
        for i in `git grep -l FAM6_ATOM` ; do
      	sed -i  -e 's/ATOM_PINEVIEW/ATOM_BONNELL/g'		\
      		-e 's/ATOM_LINCROFT/ATOM_BONNELL_MID/'		\
      		-e 's/ATOM_PENWELL/ATOM_SALTWELL_MID/g'		\
      		-e 's/ATOM_CLOVERVIEW/ATOM_SALTWELL_TABLET/g'	\
      		-e 's/ATOM_CEDARVIEW/ATOM_SALTWELL/g'		\
      		-e 's/ATOM_SILVERMONT1/ATOM_SILVERMONT/g'	\
      		-e 's/ATOM_SILVERMONT2/ATOM_SILVERMONT_X/g'	\
      		-e 's/ATOM_MERRIFIELD/ATOM_SILVERMONT_MID/g'	\
      		-e 's/ATOM_MOOREFIELD/ATOM_AIRMONT_MID/g'	\
      		-e 's/ATOM_DENVERTON/ATOM_GOLDMONT_X/g'		\
      		-e 's/ATOM_GEMINI_LAKE/ATOM_GOLDMONT_PLUS/g' ${i}
        done
      Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Linus Torvalds <torvalds@linux-foundation.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Vince Weaver <vincent.weaver@maine.edu>
      Cc: dave.hansen@linux.intel.com
      Cc: len.brown@intel.com
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      f2c4db1b
  5. 27 Jul, 2018 2 commits
  6. 26 Jul, 2018 3 commits
    • Prarit Bhargava's avatar
      tools/power turbostat: Fix logical node enumeration to allow for non-sequential physical nodes · 2ffbb224
      Prarit Bhargava authored
      turbostat fails on some multi-package topologies because the logical node
      enumeration assumes that the nodes are sequentially numbered,
      which causes the logical numa nodes to not be enumerated, or enumerated incorrectly.
      
      Use a more robust enumeration algorithm which allows for non-seqential physical nodes.
      Signed-off-by: default avatarPrarit Bhargava <prarit@redhat.com>
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      2ffbb224
    • Len Brown's avatar
      tools/power turbostat: fix x2apic debug message output file · cfce494d
      Len Brown authored
      A recently added x2apic debug message was hard-coded to stderr.
      That doesn't work with "-o outfile".
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      cfce494d
    • Artem Bityutskiy's avatar
      tools/power turbostat: fix bogus summary values · 4f206a0f
      Artem Bityutskiy authored
      This patch fixes a regression introduced in
      
      commit 8cb48b32 ("tools/power turbostat: track thread ID in cpu_topology")
      
      Turbostat uses incorrect cores number ('topo.num_cores') - its value is count
      of logical CPUs, instead of count of physical cores. So it is twice as large as
      it should be on a typical Intel system. For example, on a 6 core Xeon system
      'topo.num_cores' is 12, and on a 52 core Xeon system 'topo.num_cores' is 104.
      
      And interestingly, on a 68-core Knights Landing Intel system 'topo.num_cores'
      is 272, because this system has 4 logical CPUs per core.
      
      As a result, some of the turbostat calculations are incorrect. For example,
      on idle 52-core Xeon system when all cores are ~99% in Core C6 (CPU%c6), the
      summary (very first) line shows ~48% Core C6, while it should be ~99%.
      
      This patch fixes the problem by fixing 'topo.num_cores' calculation.
      
      Was:
      
      1. Init 'thread_id' for all CPUs to -1
      2. Run 'get_thread_siblings()' which sets it to 0 or 1
      3. Increment 'topo.num_cores' when thread_id != -1 (bug!)
      
      Now:
      
      1. Init 'thread_id' for all CPUs to -1
      2. Run 'get_thread_siblings()' which sets it to 0 or 1
      3. Increment 'topo.num_cores' when thread_id is not 0
      
      I did not have a chance to test this on an AMD machine, and only tested on a
      couple of Intel Xeons (6 and 52 cores).
      Reported-by: default avatarVladislav Govtva <vladislav.govtva@intel.com>
      Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      4f206a0f
  7. 20 Jul, 2018 1 commit
  8. 20 Jun, 2018 8 commits
  9. 02 Jun, 2018 16 commits
  10. 01 Jun, 2018 2 commits