On Mon, 17 Nov 2003, Geert Uytterhoeven wrote:
> On Sun, 16 Nov 2003, Jeff Garzik wrote:
> > Yet more updates.  Syncing with Andrew Morton, and more syncing with Al
> > Viro.
> >
> > No users of init_etherdev remain in the tree.  (yay!)
>
> Here are some (untested, except for cross-gcc) fixes for the m68k-related
> drivers:

I forget to test the Sun-3 drivers:
  - sun3_82586.c:
      o add missing casts to iounmap() calls
      o fix parameter of free_netdev()
  - sun3lance.c: add missing casts to iounmap() calls

Note that sun3_82586.c no longer compiles since SUN3_82586_TOTAL_SIZE is not
defined. Sammy, is it OK to use PAGE_SIZE for that, since that's what's passed
to ioremap()?

On Sun, 16 Nov 2003, Jeff Garzik wrote:
> Yet more updates.  Syncing with Andrew Morton, and more syncing with Al
> Viro.
>
> No users of init_etherdev remain in the tree.  (yay!)

Here are some (untested, except for cross-gcc) fixes for the m68k-related
drivers:
  - Space.c: fix incorrect prototypes for atarilance_probe() and mace_probe()
  - a2065.c: kill superfluous argument of alloc_etherdev()
  - apne.c:
      o fix incorrect prototype for apne_probe()
      o kill unused variable err
  - mac8390.c:
      o kill unused variable probed
      o fix typos ENDOEV -> ENODEV and ERR_PTE -> ERR_PTR
      o add missing variable slots
  - macmace.c: use ERR_PTR() where needed
  - macsonic.c: kill unused variable lp
  - mvme147.c:
      o kill conversion warning and kill a cast by making ram unsigned long
      o add missing variable err

Note: The use of `slots' in mac8390.c is not in my tree. Do you know where that
change comes from?

Mostly removing unneeded calls to ether_setup(), which alloc_etherdev()
already does for us.

Also handle ioremap failure.

* s/int/unsigned long/ for 'flags' arg passed to spin_lock_irqsave
* s/unsigned int/unsigned long/ for I/O port addresses
* no need to prevent tc35815_probe from being called multiple times...
  PCI layer will do things properly for us.
* call pci_enable_device before accessing hardware, before obtaining
  irq number, and before obtaining I/O port addresses.
* remove bogus 'if (pdev)' check in PCI API ->probe function
* call SET_M0DULE_OWNER, remove MOD_{INC,DEC}_USE_COUNT
* (cleanup) don't bother casting from a void*
* (cleanup) mark debugging function with #if 0, just like the caller
* Fix many printk statements to indicate that tc_readl() returns
  a long, not an int.
* (cleanup) remove unused tc35815_proc_info function

NE68-atarilance
	* switched to dynamic allocation
	* fixed resource leaks on failure exits
	* also kill off last usage of probe_list

NE67-sun3lance
	* switched to dynamic allocation
	* fixed resource leaks on failure exits

NE66-sun3_82586
	* switched to dynamic allocation
	* fixed resource leaks on failure exits

NE64-apne
	* switched to dynamic allocation
	* fixed resource leaks on failure exits

NE63-bionet
	* switched to dynamic allocation
	* fixed resource leaks on failure exits