- 04 Mar, 2010 40 commits
-
-
Roel Kluin authored
Regardless of the condition, the branches executed the same code Signed-off-by:
Roel Kluin <roel.kluin@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Roel Kluin authored
Regardless of the condition, the branches execute the same code Signed-off-by:
-
Ian Abbott authored
For AI command testing, the driver does not need to range-check the length of the channel list as the comedi core has already checked it. Signed-off-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Ian Abbott authored
Check the channel list is valid in step 5 of the AI command test. Split function check_and_setup_channel_list() in two. Also, remove unnecessary chanlist_len tests in step 3 of the AI command test as the comedi core has already checked it. Signed-off-by:
-
Ian Abbott authored
For multi-channel AI commands, the interrupt handler is missing code to switch to the next channel. Add some (untested) code to handle this. Signed-off-by:
-
Ian Abbott authored
For AI command testing, the driver does not need to range-check the length of the channel list as the comedi core has already checked it. Signed-off-by:
-
Ian Abbott authored
For AI commands, the internal channel list used to check incoming data was only set up partially if the channel list contained repeats. Set it up fully. Also the current scan position was not updated properly when moving a block of data from the FIFO unless a whole number of scans was moved. Signed-off-by:
-
Ian Abbott authored
For AI commands, the scan counter should be updated after every scan. It was being updated after every sample except for DMA mode where it was being updated after every repeated segment of the channel list. Also AI commands with multiple channels were being terminated with an error prematurely except in DMA mode. This was because the driver was comparing channel numbers received from the hardware (combined with the sample value) with the expected channel numbers to check for a "channel dropout". This test was failing incorrectly because the driver was not keeping the current position within the (repeated segment of the) channel list up to date. Signed-off-by:
-
Ian Abbott authored
For AI commands, the scan counter should be updated after every scan. In DMA mode, it was being updated after every repeated segment of the channel list. In non-DMA mode, it was being updated after every sample. Signed-off-by:
-
Ian Abbott authored
The AI scan counter should be updated after every completed scan, not after every channel. Keep track of current channel. Signed-off-by:
-
Roel Kluin authored
Read from the right status register Signed-off-by:
-
Benjamin Adolphi authored
This fixes all checkpatch issues in the pcl730 comedi driver. Signed-off-by:
Benjamin Adolphi <b.adolphi@gmail.com> Signed-off-by:
-
Benjamin Adolphi authored
This fixes all checkpatch issues in the pcl725 comedi driver. Signed-off-by:
-
Benjamin Adolphi authored
This fixes all checkpatch issues in the pcl724 comedi driver. Signed-off-by:
-
Benjamin Adolphi authored
This fixes some checkpatch issues in the pcl711 comedi driver. Signed-off-by:
-
Julia Lawall authored
The variable s is initialized twice to the same (side effect-free) expression. Drop one initialization. A simplified version of the semantic match that finds this problem is: (http://coccinelle.lip6.fr/) // <smpl> @forall@ idexpression *x; identifier f!=ERR_PTR; @@ x = f(...) ... when != x ( x = f(...,<+...x...+>,...) | * x = f(...) ) // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
-
Benjamin Adolphi authored
This fixes some checkpatch issues in the rti800 comedi driver. Signed-off-by:
-
Benjamin Adolphi authored
This fixes some checkpatch issues and some spelling mistakes in the c6xdigio comedi driver. Signed-off-by:
-
Benjamin Adolphi authored
This fixes some checkpatch issues in the adq12b comedi driver. Signed-off-by:
-
Roel Kluin authored
CurrentMPDUDensity was designed to itself. Signed-off-by:
-
Wu Zhangjin authored
When scrolling the screen on the console with the 2D acceleration support, the whole system may hang. for example, when copying some files from another machine to YeeLoong netbook with the sm7xx video driver via scp and when the screen output is enabled, the system may hang. Before the bug is fixed, remove the 2D acceleration! Signed-off-by:
Wu Zhangjin <wuzhangjin@gmail.com> Cc: Teddy Wang <teddy.wang@siliconmotion.com.cn> Signed-off-by:
-
Uwe Kleine-König authored
This patch was generated by git grep -l 'couter' drivers/staging | xargs -r perl -p -i -e 's/couter/counter/' Signed-off-by:Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by:
-
Uwe Kleine-König authored
This patch was generated by git grep -E -i -l '[Aa]quire' drivers/staging | xargs -r perl -p -i -e 's/([Aa])quire/$1cquire/' Signed-off-by: -
Uwe Kleine-König authored
This patch was generated by git grep -E -i -l 's(le|el)ct' drivers/staging | xargs -r perl -p -i -e 's/([Ss])(le|el)ct/$1elect/' Signed-off-by:
-
Uwe Kleine-König authored
This patch was generated by git grep -E -l 'enalbe' drivers/staging | xargs -r perl -p -i -e 's/enalbe/enable/g' Signed-off-by:
-
Andy Shevchenko authored
Kernel has its own method called simple_strtoul() to do such things. Here we are using simple_strtoul(value, NULL, 0) because in original function the recognized base is 10 or 16 and input data is assumed to be unsigned. Signed-off-by:
Andy Shevchenko <ext-andriy.shevchenko@nokia.com> Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
Ben Hutchings <ben@decadent.org.uk> Signed-off-by:
-
Ben Hutchings authored
The current names "cache.image.bin" and "resident.image.bin" are far too generic. Signed-off-by:
-
Ben Hutchings authored
Signed-off-by:
-
Pavel Vasilyev authored
http://bugzilla.kernel.org/show_bug.cgi?id=14825 sizeof(extlen), always will be sizeof( unit32_t) or 4 It seems that something is wrong?!?! Signed-off-by:
Pavel Vasilyev <pavel@pavlinux.ru> Signed-off-by:
-
Jeff Mahoney authored
This driver depends on virt_to_bus working correctly, but it doesn't exist on ppc64 (and probably other arches). Signed-off-by:
Jeff Mahoney <jeffm@suse.com> Signed-off-by:
-
Jeff Mahoney authored
This patch fixes some %x pointer printing to %p. It also uses the skb_tail_pointer and skb_mac_header macros for accessing thos members. Signed-off-by:
-
Jeff Mahoney authored
rtl8192u uses -mhard-float, which doesn't exist on ia64. Since in-kernel floating-point isn't allowed, this is implied anyway. Signed-off-by:
-
Jeff Mahoney authored
rtl8192e uses skb->tail directly. This patch uses the tail pointer macros instead. Signed-off-by:
-
Jeff Mahoney authored
rt2860 uses skb->tail directly. This patch uses the tail pointer macros instead. Signed-off-by:
-
Minchan Kim authored
If create_device is failed, it can't free gendisk and request_queue of preceding devices. It cause memory leak. This patch fixes it. Signed-off-by:
Minchan Kim <minchan.kim@gmail.com> Acked-by:
Nitin Gupta <ngupta@vflare.org> Signed-off-by:
-
Németh Márton authored
The id_table field of the struct i2c_driver is constant in <linux/i2c.h> so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by:
Németh Márton <nm127@freemail.hu> Cc: Julia Lawall <julia@diku.dk> Cc: cocci@diku.dk Signed-off-by:
-
Németh Márton authored
The id_table field of the struct usb_device_id is constant in <linux/usb.h> so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by:
-
Németh Márton authored
The id_table field of the struct pci_driver is constant in <linux/pci.h> so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by:
-
Jonathan Cameron authored
A second smatch detected error. First part fixes in a typo in the comment directly above that I noticed whilst trying to remember what this code actually does. Second part is the actual fix. I'm fairly amazed this one never caused trouble in testing as it is in one of the most common paths. Signed-off-by:
Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by:
-
