- 09 Mar, 2020 4 commits
-
-
Jiri Pirko authored
As there is one set of counters for the whole action chain, forbid to mix the HW stats types. Signed-off-by:
Jiri Pirko <jiri@mellanox.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Jiri Pirko authored
Introduce flow_action_basic_hw_stats_types_check() helper and use it in drivers. That sanitizes the drivers which do not have support for action HW stats types. Signed-off-by:
-
Jiri Pirko authored
Instead of directly checking number of action entries, use flow_offload_has_one_action() helper. Signed-off-by:
Vladimir Oltean <vladimir.oltean@nxp.com> Signed-off-by:
-
Jiri Pirko authored
Initially, pass "ANY" (struct is zeroed) to the drivers as that is the current implicit value coming down to flow_offload. Add a bool indicating that entries have mixed HW stats type. Signed-off-by:
-
- 07 Mar, 2020 10 commits
-
-
David S. Miller authored
Jakub Kicinski says: ==================== ethtool: consolidate irq coalescing - other drivers Convert more drivers following the groundwork laid in a recent patch set [1]. The aim of the effort is to consolidate irq coalescing parameter validation in the core. This set converts all the drivers outside of drivers/net/ethernet. Only vmxnet3 them was checking unsupported parameters. The aim is to merge this via the net-next tree so we can convert all drivers and make the checking mandatory. [1] https://lore.kernel.org/netdev/20200305051542.991898-1-kuba@kernel.org/ ==================== Signed-off-by:
-
Jakub Kicinski authored
Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by:
Jakub Kicinski <kuba@kernel.org> Acked-by:
Kalle Valo <kvalo@codeaurora.org> Signed-off-by:
-
Jakub Kicinski authored
Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by:
-
Jakub Kicinski authored
Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver correctly rejects all unsupported parameters. As a side effect of these changes the error code for unsupported params changes from EINVAL to EOPNOTSUPP. Signed-off-by:
-
Jakub Kicinski authored
Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by:
Hayes Wang <hayeswang@realtek.com> Signed-off-by:
-
Jakub Kicinski authored
Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by:
Jason Wang <jasowang@redhat.com> Signed-off-by:
-
Jakub Kicinski authored
Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by:
Leon Romanovsky <leonro@mellanox.com> Signed-off-by:
-
Jakub Kicinski authored
Set ethtool_ops->supported_coalesce_params to let the core reject unsupported coalescing parameters. This driver did not previously reject unsupported parameters. Signed-off-by:
Anton Ivanov <anton.ivanov@cambridgegreys.com> Signed-off-by:
-
Ansuel Smith authored
Add documentations for ipq806x mdio driver. Signed-off-by:
Ansuel Smith <ansuelsmth@gmail.com> Signed-off-by:
-
Ansuel Smith authored
Currently ipq806x soc use generic bitbang driver to comunicate with the gmac ethernet interface. Add a dedicated driver created by chunkeey to fix this. Co-developed-by:
Christian Lamparter <chunkeey@gmail.com> Signed-off-by:
-
- 06 Mar, 2020 17 commits
-
-
David S. Miller authored
Michal Kubecek says: ==================== tun: debug messages cleanup While testing ethtool output for "strange" devices, I noticed confusing and obviously incorrect message level information for a tun device and sent a quick fix. The result of the upstream discussion was that tun driver would rather deserve a more complex cleanup of the way it handles debug messages. The main problem is that all debugging statements and setting of message level are controlled by TUN_DEBUG macro which is only defined if one edits the source and rebuilds the module, otherwise all DBG1() and tun_debug() statements do nothing. This series drops the TUN_DEBUG switch and replaces custom tun_debug() macro with standard netif_info() so that message level (mask) set and displayed using ethtool works as expected. Some debugging messages are dropped as they only notify about entering a function which can be done easily using ftrace or kprobe. Patch 1 is a trivial fix for compilation warning with W=1. ==================== Signed-off-by: -
Michal Kubecek authored
TUN_DEBUG and tun_debug() are no longer used anywhere, drop them. Signed-off-by:
Michal Kubecek <mkubecek@suse.cz> Signed-off-by:
-
Michal Kubecek authored
The tun driver uses custom macro tun_debug() which is only available if TUN_DEBUG is set. Replace it by standard netif_ifinfo(). For that purpose, rename tun_struct::debug to msg_enable and make it u32 and always present. Finally, make tun_get_msglevel(), tun_set_msglevel() and TUNSETDEBUG ioctl independent of TUN_DEBUG. Signed-off-by:
-
Michal Kubecek authored
Some of the tun_debug() statements only inform us about entering a function which can be easily achieved with ftrace or kprobe. As tun_debug() is no-op unless TUN_DEBUG is set which requires editing the source and recompiling, setting up ftrace or kprobe is easier. Drop these debug statements. Also drop the tun_debug() statement informing about SIOCSIFHWADDR ioctl. We can monitor these through rtnetlink and it makes little sense to log address changes through ioctl but not changes through rtnetlink. Moreover, this tun_debug() is called even if the actual address change fails which makes it even less useful. Signed-off-by:
-
Michal Kubecek authored
This macro is no-op unless TUN_DEBUG is defined (which requires editing and recompiling the source) and only does something if variable debug is 2 but that variable is zero initialized and never set to anything else. Moreover, the only use of the macro informs about entering function tun_chr_open() which can be easily achieved using ftrace or kprobe. Drop DBG1() macro, its only use and global variable debug. Signed-off-by:
-
Michal Kubecek authored
The comment above tun_flow_save_rps_rxhash() starts with "/**" which makes it look like kerneldoc comment and results in warnings when building with W=1. Fix the format to make it look like a normal comment. Signed-off-by:
-
Roman Mashak authored
Signed-off-by:
Roman Mashak <mrv@mojatatu.com> Signed-off-by:
-
Roman Mashak authored
Signed-off-by:
-
David S. Miller authored
Jacob Keller says: ==================== PCI: Implement function to read Device Serial Number Several drivers read the Device Serial Number from the PCIe extended configuration space. Each of these drivers implements a similar approach to finding the position and then extracting the 8 bytes of data. Implement a new helper function, pci_get_dsn, which can be used to extract this data into an 8 byte array. Modify the bnxt_en, qedf, ice, ixgbe and nfp drivers to use this new function. The intent for this is to reduce duplicate code across the various drivers, and make it easier to write future code that wants to read the DSN. In particular the ice driver will be using the DSN as its serial number when implementing the DEVLINK_CMD_INFO_GET. The new implementation in v2 significantly simplifies some of the callers which just want to print the value out in MSB order. By returning things as a u64 in CPU Endian order, the "%016llX" printf format specifier can be used to correctly format the value. Per patch changes since v1 PCI: Introduce pci_get_dsn * Update commit message based on feedback from Bjorn Helgaas * Modify the function to return a u64 (zero on no capability) * This new implementation ensures that the first dword is the lower 32 bits and the second dword is the upper 32 bits. bnxt_en: Use pci_get_dsn() * Use the u64 return value from pci_get_dsn() * Copy it into the dsn[] array by using put_unaligned_le64 * Fix a pre-existing typo in the netdev_info error message scsi: qedf: Use pci_get_dsn() * Use the u64 return value from pci_get_dsn() * simplify the snprintf to use "%016llX" * remove the unused 'i' variable ice: Use pci_get_dsn() * Use the u64 return value from pci_get_dsn() * simplify the snprintf to use "%016llX" ixgbe: Use pci_get_dsn() * Use the u64 return value from pci_get_dsn() * simplify the snprintf to use "%016llX" nfp: Use pci_get_dsn() * Added in v2 ==================== Signed-off-by: -
Jacob Keller authored
Use the newly added pci_get_dsn() function for obtaining the 64-bit Device Serial Number in the nfp6000_read_serial and nfp_6000_get_interface functions. pci_get_dsn() reports the Device Serial number as a u64 value created by combining two pci_read_config_dword functions. The lower 16 bits represent the device interface value, and the next 48 bits represent the serial value. Use put_unaligned_be32 and put_unaligned_be16 to convert the serial value portion into a Big Endian formatted serial u8 array. Signed-off-by:
Jacob Keller <jacob.e.keller@intel.com> Cc: Jakub Kicinski <kuba@kernel.org> Reviewed-by:
-
Jacob Keller authored
Replace the open-coded implementation for reading the PCIe DSN with pci_get_dsn(). The original code used a simple for-loop to read the bytes in order into a buffer one byte at a time. The pci_get_dsn() function returns the DSN as a u64, correctly ordering the upper and lower 32 bit dwords. Simplify the display code by using %016llX to display the u64 DSN. This should have equivalent behavior on both Little and Big Endian systems. The bus will have correctly ordered the dwords in the CPU endian format, while pci_get_dsn() will correctly order the lower and higher dwords into a u64. Signed-off-by:
-
Jacob Keller authored
Replace the open-coded implementation for reading the PCIe DSN with pci_get_dsn(). The pci_get_dsn() function will perform two pci_read_config_dword calls to read the lower and upper config dwords. It bitwise ORs them into a u64 value. Instead of using put_unaligned_le32 to convert the value to LE32 format, just use the %016llX printf specifier. This will print the u64 correct, putting the most significant byte of the value first. Since pci_get_dsn() correctly orders the two dwords into a u64, this should produce equivalent results in less code. Signed-off-by:
-
Jacob Keller authored
Replace the open-coded implementation for reading the PCIe DSN with pci_get_dsn(). The original code used a for-loop that looped over each of the 8 bytes and copied them into a temporary buffer. pci_get_dsn() uses two calls to pci_read_config_dword, and correctly bitwise ORs them into a u64. Thus, we can simplify the snprintf significantly using %016llX on a u64 value. Signed-off-by:
-
Jacob Keller authored
Replace the open-coded implementation for reading the PCIe DSN with pci_get_dsn(). Use of put_unaligned_le64 should be correct. pci_get_dsn() will perform two pci_read_config_dword calls. The first dword will be placed in the first 32 bits of the u64, while the second dword will be placed in the upper 32 bits of the u64. On Little Endian systems, the least significant byte comes first, which will be the least significant byte of the first dword, followed by the least significant byte of the second dword. Since the _le32 variations do not perform byte swapping, we will correctly copy the dwords into the dsn[] array in the same order as before. On Big Endian systems, the most significant byte of the second dword will come first. put_unaligned_le64 will perform a CPU_TO_LE64, which will swap things correctly before copying. This should also end up with the correct bytes in the dsn[] array. While at it, fix a small typo in the netdev_info error message when the DSN cannot be read. Signed-off-by:
-
Jacob Keller authored
Several device drivers read their Device Serial Number from the PCIe extended config space. Introduce a new helper function, pci_get_dsn(). This function reads the eight bytes of the DSN and returns them as a u64. If the capability does not exist for the device, the function returns 0. Signed-off-by:
Bjorn Helgaas <bhelgaas@google.com> Signed-off-by:
-
Matthew Wilcox (Oracle) authored
We already have a function called page_offset(), and this macro is unused, so just delete it. Signed-off-by:
Matthew Wilcox (Oracle) <willy@infradead.org> Signed-off-by:
-
Vivek Thampi authored
Add a PTP clock driver called ptp_vmw, for guests running on VMware ESXi hypervisor. The driver attaches to a VMware virtual device called "precision clock" that provides a mechanism for querying host system time. Similar to existing virtual PTP clock drivers (e.g. ptp_kvm), ptp_vmw utilizes the kernel's PTP hardware clock API to implement a clock device that can be used as a reference in Chrony for synchronizing guest time with host. The driver is only applicable to x86 guests running in VMware virtual machines with precision clock virtual device present. It uses a VMware specific hypercall mechanism to read time from the device. Reviewed-by:
Thomas Hellstrom <thellstrom@vmware.com> Signed-off-by:
Vivek Thampi <vithampi@vmware.com> Signed-off-by:
-
- 05 Mar, 2020 9 commits
-
-
David S. Miller authored
Merge tag 'wireless-drivers-next-2020-03-05' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next Kalle Valo says: ==================== wireless-drivers-next patches for v5.7 First set of patches for v5.7. Lots of mt76 patches as they missed the v5.6 deadline and hence they were postponed to the next version. Otherwise nothing special standing out. mt76 Major changes: * dual-band concurrent support for MT7615 * fixes for rx path race conditions * coverage class support for MT7615 * beacon fixes for USB devices * MT7615 LED support * set_antenna support for MT7615 * tracing improvements * preparation for supporting new USB devices * tx power fixes brcmfmac * support BRCM 4364 found in MacBook Pro 15,2 ==================== Signed-off-by:
-
tangbin authored
in this function,‘ret’ is always assigned,so this's definition 'ret = 0' make no sense. Signed-off-by:
tangbin <tangbin@cmss.chinamobile.com> Acked-by:
Florian Fainelli <f.fainelli@gmail.com> Signed-off-by:
-
Gustavo A. R. Silva authored
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by:Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by:
-
David S. Miller authored
Ido Schimmel says: ==================== mlxsw: Offload FIFO Petr says: If an ETS or PRIO band contains an offloaded qdisc, it is possible to obtain offloaded counters for that band. However, some of the bands will likely simply contain the default invisible FIFO qdisc, which does not present the counters. To remedy this situation, make FIFO offloadable, and offload it by mlxsw when below PRIO and ETS for the sole purpose of providing counters for the bands that do not include other qdiscs. - In patch #1, FIFO is extended to support offloading. - Patches #2 and #3 restructure bits of mlxsw to facilitate the offload logic. - Patch #4 then implements the offload itself. - Patch #5 changes the ETS selftest to use the new counters. ==================== Signed-off-by: -
Petr Machata authored
Currently the SW-datapath ETS selftests use "ip link" stats to obtain the number of packets that went through a given band. mlxsw then uses ethtool per-priority counters. Instead, change both to use qdiscs. In SW datapath this is the obvious choice, and now that mlxsw offloads FIFO, this should work on the offloaded datapath as well. This has the effect of verifying that the FIFO offload works. Signed-off-by:
Petr Machata <petrm@mellanox.com> Signed-off-by:
Ido Schimmel <idosch@mellanox.com> Signed-off-by:
-
Petr Machata authored
There are two peculiarities about offloading FIFO: - sometimes the qdisc has an unspecified handle (it is "invisible") - it may be created before the qdisc that it will be a child of These features make the offload a bit more tricky. The approach chosen in this patch is to make note of all the FIFOs that needed to be rejected because their parents were not known. Later when the parent is created, they are offloaded FIFO is only offloaded for its counters, queue length is ignored. Signed-off-by:
-
Petr Machata authored
PRIO and ETS will need to check the value of qdisc handle in their handlers. Add it to the callback and propagate through. Signed-off-by:
-
Petr Machata authored
In order to have a tidy structure where to put information related to Qdisc offloads, introduce a new structure. Move there the two existing pieces of data: root_qdisc and tclass_qdiscs. Embed them directly, because there's no reason to go through pointer anymore. Convert users, update init/fini functions. Signed-off-by:
-
Petr Machata authored
Invoke ndo_setup_tc() as appropriate to signal init / replacement, destroying and dumping of pFIFO / bFIFO Qdisc. A lot of the FIFO logic is used for pFIFO_head_drop as well, but that's a semantically very different Qdisc that isn't really in the same boat as pFIFO / bFIFO. Split some of the functions to keep the Qdisc intact. Signed-off-by:
-
