1. 24 Jan, 2011 1 commit
    • Jesper Juhl's avatar
      CIFS: Remove pointless variable assignment in cifs_dfs_do_automount() · 3f391c79
      Jesper Juhl authored
      In fs/cifs/cifs_dfs_ref.c::cifs_dfs_do_automount() we have this code:
      
      	...
      	mnt = ERR_PTR(-EINVAL);
      	if (IS_ERR(tlink)) {
      		mnt = ERR_CAST(tlink);
      		goto free_full_path;
      	}
      	ses = tlink_tcon(tlink)->ses;
      
      	rc = get_dfs_path(xid, ses, full_path + 1, cifs_sb->local_nls,
      		&num_referrals, &referrals,
      		cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR);
      
      	cifs_put_tlink(tlink);
      
      	mnt = ERR_PTR(-ENOENT);
      	...
      
      The assignment of 'mnt = ERR_PTR(-EINVAL);' is completely pointless. If we
      take the 'if (IS_ERR(tlink))' branch we'll set 'mnt' again and we'll also
      do so if we do not take the branch. There is no way we'll ever use 'mnt'
      with the assigned 'ERR_PTR(-EINVAL)' value, so we may as well just remove
      the pointless assignment.
      Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
      Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
      3f391c79
  2. 22 Jan, 2011 2 commits
    • Linus Torvalds's avatar
      Linux 2.6.38-rc2 · 1bae4ce2
      Linus Torvalds authored
      1bae4ce2
    • Linus Torvalds's avatar
      Merge branch 'media_fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6 · 13a3cec8
      Linus Torvalds authored
      * 'media_fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6: (101 commits)
        [media] staging/lirc: fix mem leaks and ptr err usage
        [media] hdpvr: reduce latency of i2c read/write w/recycled buffer
        [media] hdpvr: enable IR part
        [media] rc/mceusb: timeout should be in ns, not us
        [media] v4l2-device: fix 'use-after-freed' oops
        [media] v4l2-dev: don't memset video_device.dev
        [media] zoran: use video_device_alloc instead of kmalloc
        [media] w9966: zero device state after a detach
        [media] v4l: Fix a use-before-set in the control framework
        [media] v4l: Include linux/videodev2.h in media/v4l2-ctrls.h
        [media] DocBook/v4l: update V4L2 revision and update copyright years
        [media] DocBook/v4l: fix validation error in dev-rds.xml
        [media] v4l2-ctrls: queryctrl shouldn't attempt to replace V4L2_CID_PRIVATE_BASE IDs
        [media] v4l2-ctrls: fix missing 'read-only' check
        [media] pvrusb2: Provide more information about IR units to lirc_zilog and ir-kbd-i2c
        [media] ir-kbd-i2c: Add back defaults setting for Zilog Z8's at addr 0x71
        [media] lirc_zilog: Update TODO.lirc_zilog
        [media] lirc_zilog: Add Andy Walls to copyright notice and authors list
        [media] lirc_zilog: Remove useless struct i2c_driver.command function
        [media] lirc_zilog: Remove unneeded tests for existence of the IR Tx function
        ...
      13a3cec8
  3. 21 Jan, 2011 37 commits